From: Tatuya JINMEI 神明達哉 <jinmei@isc.org>
Date: Wed, 25 Jun 2008 22:56:33 +0000 (+0000)
Subject: work around HP-UX UDP connect behavior [RT #18202]
X-Git-Tag: v9.3.6b1~36^2~127
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=7b0bb3bdc96dca1b8fd0571121e90a81a1bfabe2;p=thirdparty%2Fbind9.git

work around HP-UX UDP connect behavior [RT #18202]
---

diff --git a/lib/isc/unix/socket.c b/lib/isc/unix/socket.c
index ebd81976411..03f0f804d05 100644
--- a/lib/isc/unix/socket.c
+++ b/lib/isc/unix/socket.c
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: socket.c,v 1.284 2008/06/25 00:09:50 jinmei Exp $ */
+/* $Id: socket.c,v 1.285 2008/06/25 22:56:33 jinmei Exp $ */
 
 /*! \file */
 
@@ -4390,6 +4390,16 @@ isc_socket_connect(isc_socket_t *sock, isc_sockaddr_t *addr,
 	sock->peer_address = *addr;
 	cc = connect(sock->fd, &addr->type.sa, addr->length);
 	if (cc < 0) {
+		/*
+		 * HP-UX "fails" to connect a UDP socket and sets errno to
+		 * EINPROGRESS if it's non-blocking.  We'd rather regard this as
+		 * a success and let the user detect it if it's really an error
+		 * at the time of sending a packet on the socket.
+		 */
+		if (sock->type == isc_sockettype_udp && errno == EINPROGRESS) {
+			cc = 0;
+			goto success;
+		}
 		if (SOFT_ERROR(errno) || errno == EINPROGRESS)
 			goto queue;
 
@@ -4431,6 +4441,7 @@ isc_socket_connect(isc_socket_t *sock, isc_sockaddr_t *addr,
 	/*
 	 * If connect completed, fire off the done event.
 	 */
+ success:
 	if (cc == 0) {
 		sock->connected = 1;
 		sock->bound = 1;