From: Mark Andrews <marka@isc.org>
Date: Thu, 20 Nov 2008 00:54:45 +0000 (+0000)
Subject: 2479.   [bug]           xfrout:covers was not properly initalized. [RT #18801]
X-Git-Tag: v9.4.3-P1~1^5~120
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=7b9b9b6c304bbe36f1a64e3cf30f60fd16ac379a;p=thirdparty%2Fbind9.git

2479.   [bug]           xfrout:covers was not properly initalized. [RT #18801]
---

diff --git a/CHANGES b/CHANGES
index 86846c7ea84..c2f40074e93 100644
--- a/CHANGES
+++ b/CHANGES
@@ -3,8 +3,10 @@
 			warning or crash named with the debug 1 level
 			of logging. [RT #18917]
 
+2479.	[bug]		xfrout:covers was not properly initalized. [RT #18801]
+
 2478.	[bug]		'addresses' could be used uninitalized in
-			configure_forward(). [RT 18800]
+			configure_forward(). [RT #18800]
 	
 	--- 9.4.3 released ---
 
diff --git a/bin/named/xfrout.c b/bin/named/xfrout.c
index 9fe90a2b47b..9c0f392909c 100644
--- a/bin/named/xfrout.c
+++ b/bin/named/xfrout.c
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: xfrout.c,v 1.115.18.8 2006/03/05 23:58:51 marka Exp $ */
+/* $Id: xfrout.c,v 1.115.18.9 2008/11/20 00:54:45 marka Exp $ */
 
 #include <config.h>
 
@@ -303,6 +303,11 @@ log_rr(dns_name_t *name, dns_rdata_t *rdata, isc_uint32_t ttl) {
 	rdl.type = rdata->type;
 	rdl.rdclass = rdata->rdclass;
 	rdl.ttl = ttl;
+	if (rdata->type == dns_rdatatype_sig ||
+	    rdata->type == dns_rdatatype_rrsig)
+		rdl.covers = dns_rdata_covers(rdata);
+	else
+		rdl.covers = dns_rdatatype_none;
 	ISC_LIST_INIT(rdl.rdata);
 	ISC_LINK_INIT(&rdl, link);
 	dns_rdataset_init(&rds);
@@ -1573,6 +1578,11 @@ sendstream(xfrout_ctx_t *xfr) {
 		msgrdl->type = rdata->type;
 		msgrdl->rdclass = rdata->rdclass;
 		msgrdl->ttl = ttl;
+		if (rdata->type == dns_rdatatype_sig ||
+		    rdata->type == dns_rdatatype_rrsig)
+			msgrdl->covers = dns_rdata_covers(rdata);
+		else
+			msgrdl->covers = dns_rdatatype_none;
 		ISC_LINK_INIT(msgrdl, link);
 		ISC_LIST_INIT(msgrdl->rdata);
 		ISC_LIST_APPEND(msgrdl->rdata, msgrdata, link);