From: Neil Horman <nhorman@openssl.org>
Date: Fri, 26 Jun 2026 15:17:09 +0000 (-0400)
Subject: use evp_asym_cipher_free in evp_asym_cipher_from_algorithm
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=8a072a3dabe4df116460f8910735569df321b97b;p=thirdparty%2Fopenssl.git

use evp_asym_cipher_free in evp_asym_cipher_from_algorithm

evp_asym_cipher_from_algorithm, in its error path frees the allocated
cipher with EVP_ASM_CIPHER_free, but thats a no-op now, and we actually want to
free it to avoid leaks, so we should use evp_asym_cipher_free (the internal
function that acutally does free the alg) instead.

Fixes https://scan5.scan.coverity.com/#/project-view/60762/10222?selectedIssue=1695449

Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Norbert Pocs <norbertp@openssl.org>
MergeDate: Wed Jul  1 15:32:25 2026
(Merged from https://github.com/openssl/openssl/pull/31748)
---

diff --git a/crypto/evp/asymcipher.c b/crypto/evp/asymcipher.c
index 78dbb7e2f58..c449848ae03 100644
--- a/crypto/evp/asymcipher.c
+++ b/crypto/evp/asymcipher.c
@@ -453,7 +453,7 @@ static void *evp_asym_cipher_from_algorithm(int name_id,
 
     return cipher;
 err:
-    EVP_ASYM_CIPHER_free(cipher);
+    evp_asym_cipher_free(cipher);
     return NULL;
 }