From: Rob Herring (Arm) Date: Fri, 12 Jun 2026 21:53:32 +0000 (-0500) Subject: hwmon: tmp401: Read "ti,n-factor" as signed X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=9955c92abe72564a49c293b1c15cd3b4f02ea6a0;p=thirdparty%2Flinux.git hwmon: tmp401: Read "ti,n-factor" as signed The "ti,n-factor" binding and examples allow negative correction values. Reading it as u32 makes the helper type disagree with the documented signed value and hides real schema mismatches. Use the signed helper so the DT access matches the s32 value stored by the driver. Assisted-by: Codex:gpt-5-5 Signed-off-by: Rob Herring (Arm) Link: https://lore.kernel.org/r/20260612215332.1889497-1-robh@kernel.org Signed-off-by: Guenter Roeck --- diff --git a/drivers/hwmon/tmp401.c b/drivers/hwmon/tmp401.c index a09225a87355d..ca0ff525ea29f 100644 --- a/drivers/hwmon/tmp401.c +++ b/drivers/hwmon/tmp401.c @@ -560,7 +560,7 @@ static int tmp401_init_client(struct tmp401_data *data) return ret; } - ret = of_property_read_u32(data->client->dev.of_node, "ti,n-factor", &nfactor); + ret = of_property_read_s32(data->client->dev.of_node, "ti,n-factor", &nfactor); if (!ret) { if (data->kind == tmp401) { dev_err(&data->client->dev, "ti,tmp401 does not support n-factor correction\n");