From: Ondřej Surý <ondrej@isc.org>
Date: Sun, 6 Mar 2022 09:16:29 +0000 (+0100)
Subject: Fix null pointer dereferences in udp_ready()
X-Git-Tag: v9.19.0~81^2
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=9d8e8a4fcc70577db8bf1350310f5014398f131d;p=thirdparty%2Fbind9.git

Fix null pointer dereferences in udp_ready()

The query pointer was detached too early leading to null pointer
reference.  Move the query_detach() after the query->canceled check.
---

diff --git a/bin/dig/dighost.c b/bin/dig/dighost.c
index faad62c13c6..c736a3357a4 100644
--- a/bin/dig/dighost.c
+++ b/bin/dig/dighost.c
@@ -2900,10 +2900,10 @@ udp_ready(isc_nmhandle_t *handle, isc_result_t eresult, void *arg) {
 		dig_lookup_t *l = query->lookup;
 
 		debug("in cancel handler");
-		query_detach(&query);
 		if (!query->canceled) {
 			cancel_lookup(l);
 		}
+		query_detach(&query);
 		lookup_detach(&l);
 		return;
 	} else if (eresult != ISC_R_SUCCESS) {