From: Mukund Sivaraman <muks@isc.org>
Date: Tue, 11 Nov 2014 01:44:20 +0000 (+0530)
Subject: [master] close() fd when done (Coverity report)
X-Git-Tag: v9.11.0a1~1276
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=a3157f3c75e22240231eb285ad35507647bdaf2c;p=thirdparty%2Fbind9.git

[master] close() fd when done (Coverity report)
---

diff --git a/lib/isc/tests/file_test.c b/lib/isc/tests/file_test.c
index a6f55ef4556..b252b50580e 100644
--- a/lib/isc/tests/file_test.c
+++ b/lib/isc/tests/file_test.c
@@ -46,6 +46,7 @@ ATF_TC_HEAD(isc_file_sanitize, tc) {
 ATF_TC_BODY(isc_file_sanitize, tc) {
 	isc_result_t result;
 	char buf[1024];
+	int fd;
 
 	ATF_CHECK(chdir(TESTS) != -1);
 
@@ -56,15 +57,19 @@ ATF_TC_BODY(isc_file_sanitize, tc) {
 	ATF_CHECK_EQ(result, ISC_R_SUCCESS);
 	ATF_CHECK(strcmp(buf, F(NAME)) == 0);
 
-	ATF_CHECK(creat(F(TRUNC_SHA), 0644) != -1);
+	fd = creat(F(TRUNC_SHA), 0644);
+	ATF_CHECK(fd != -1);
 	result = isc_file_sanitize("testdata/file", NAME, "test", buf, 1024);
 	ATF_CHECK_EQ(result, ISC_R_SUCCESS);
 	ATF_CHECK(strcmp(buf, F(TRUNC_SHA)) == 0);
+	close(fd);
 
-	ATF_CHECK(creat(F(SHA), 0644) != -1);
+	fd = creat(F(SHA), 0644);
+	ATF_CHECK(fd != -1);
 	result = isc_file_sanitize("testdata/file", NAME, "test", buf, 1024);
 	ATF_CHECK_EQ(result, ISC_R_SUCCESS);
 	ATF_CHECK(strcmp(buf, F(SHA)) == 0);
+	close(fd);
 
 	result = isc_file_sanitize("testdata/file", BAD1, "test", buf, 1024);
 	ATF_CHECK_EQ(result, ISC_R_SUCCESS);