From: Evan Hunt <each@isc.org>
Date: Wed, 7 Sep 2022 00:12:14 +0000 (-0700)
Subject: when creating an interface, set magic before linking
X-Git-Tag: v9.18.7~10^2
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=acfca3f4fa6c22f28a2178de0eca30a9d8a0763f;p=thirdparty%2Fbind9.git

when creating an interface, set magic before linking

set the magic number in a newly-created interface object
before appending it to mgr->interfaces in order to prevent
a possible assertion.

(cherry picked from commit 8c01662048bbdb36c671c210183d7eecedd69e05)
---

diff --git a/lib/ns/interfacemgr.c b/lib/ns/interfacemgr.c
index 1bd684126f9..d02493244ec 100644
--- a/lib/ns/interfacemgr.c
+++ b/lib/ns/interfacemgr.c
@@ -477,12 +477,12 @@ interface_create(ns_interfacemgr_t *mgr, isc_sockaddr_t *addr, const char *name,
 	ISC_LINK_INIT(ifp, link);
 
 	ns_interfacemgr_attach(mgr, &ifp->mgr);
+	ifp->magic = IFACE_MAGIC;
+
 	LOCK(&mgr->lock);
 	ISC_LIST_APPEND(mgr->interfaces, ifp, link);
 	UNLOCK(&mgr->lock);
 
-	ifp->magic = IFACE_MAGIC;
-
 	*ifpret = ifp;
 }