From: Tony Finch Date: Mon, 15 May 2023 14:35:57 +0000 (+0100) Subject: Check the return value from uv_async_send() X-Git-Tag: v9.19.14~48^2 X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=afae41aa40a5d71b7863eaccc06faaffed00c217;p=thirdparty%2Fbind9.git Check the return value from uv_async_send() An omission pointed out by the following report from Coverity: /lib/isc/loop.c: 483 in isc_loopmgr_pause() >>> CID 455002: Error handling issues (CHECKED_RETURN) >>> Calling "uv_async_send" without checking return value (as is done elsewhere 5 out of 6 times). 483 uv_async_send(&loop->pause_trigger); --- diff --git a/lib/isc/loop.c b/lib/isc/loop.c index 0b3918a00f3..ddbc83d37b6 100644 --- a/lib/isc/loop.c +++ b/lib/isc/loop.c @@ -480,7 +480,8 @@ isc_loopmgr_pause(isc_loopmgr_t *loopmgr) { continue; } - uv_async_send(&loop->pause_trigger); + int r = uv_async_send(&loop->pause_trigger); + UV_RUNTIME_CHECK(uv_async_send, r); } RUNTIME_CHECK(atomic_compare_exchange_strong(&loopmgr->paused,