From: Tatuya JINMEI 神明達哉 <jinmei@isc.org>
Date: Fri, 17 Oct 2008 21:49:23 +0000 (+0000)
Subject: 2467.	[bug]		Failure of fcntl(F_DUPFD) wasn't logged. [RT #18740]
X-Git-Tag: v9.6.0-P1~94
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=b05585dcfe270c40e309ff7304cf6b69d7390bda;p=thirdparty%2Fbind9.git

2467.	[bug]		Failure of fcntl(F_DUPFD) wasn't logged. [RT #18740]
---

diff --git a/CHANGES b/CHANGES
index 88a41150159..9a89655405f 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,5 @@
+2467.	[bug]		Failure of fcntl(F_DUPFD) wasn't logged. [RT #18740]
+
 2466.	[doc]		ARM: explain max-cache-ttl 0 SERVFAIL issue.
 			[RT #18302]
 
diff --git a/lib/isc/unix/socket.c b/lib/isc/unix/socket.c
index 531bac1a467..67f34c8d313 100644
--- a/lib/isc/unix/socket.c
+++ b/lib/isc/unix/socket.c
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: socket.c,v 1.303 2008/09/23 02:20:21 marka Exp $ */
+/* $Id: socket.c,v 1.304 2008/10/17 21:49:23 jinmei Exp $ */
 
 /*! \file */
 
@@ -1894,6 +1894,13 @@ opensocket(isc_socketmgr_t *manager, isc_socket_t *sock) {
 		switch (errno) {
 		case EMFILE:
 		case ENFILE:
+			isc__strerror(errno, strbuf, sizeof(strbuf));
+			isc_log_iwrite(isc_lctx, ISC_LOGCATEGORY_GENERAL,
+				       ISC_LOGMODULE_SOCKET, ISC_LOG_ERROR,
+				       isc_msgcat, ISC_MSGSET_SOCKET,
+				       ISC_MSG_TOOMANYFDS,
+				       "%s: %s", err, strbuf);
+			/* fallthrough */
 		case ENOBUFS:
 			return (ISC_R_NORESOURCES);