From: Matthijs Mekking <matthijs@isc.org>
Date: Mon, 12 Jul 2021 08:10:12 +0000 (+0200)
Subject: Fix leak in checkds code
X-Git-Tag: v9.17.17~29^2~1
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=b67616393398a107f0d359cce225b64bda3979b3;p=thirdparty%2Fbind9.git

Fix leak in checkds code

In 'checkds_send_toaddr' there is a goto bug that causes the TSIG key
and DNS message to not be detached. Remove the offending goto statement.
---

diff --git a/lib/dns/zone.c b/lib/dns/zone.c
index 6f32655a187..309afb05927 100644
--- a/lib/dns/zone.c
+++ b/lib/dns/zone.c
@@ -21231,7 +21231,6 @@ checkds_send_toaddr(isc_task_t *task, isc_event_t *event) {
 			checkds->zone, ISC_LOG_DEBUG(3),
 			"checkds: dns_request_createvia() to %s failed: %s",
 			addrbuf, dns_result_totext(result));
-		goto cleanup;
 	}
 
 cleanup_key: