From: Willy Tarreau <w@1wt.eu>
Date: Mon, 8 Jun 2026 06:54:37 +0000 (+0200)
Subject: MINOR: pools: reject creation of pools containing invalid chars in their name
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=b9fa07bd205ddd993c84e29d5b0324a84d032578;p=thirdparty%2Fhaproxy.git

MINOR: pools: reject creation of pools containing invalid chars in their name

In order to preventively avoid issues that complicate debugging, let's
report to developers early if a pool name is not acceptable. This patch
does it in create_pool_from_reg() which catches both direct and declared
registrations. Aside the previous case, this didn't catch any other
occurrence.
---

diff --git a/src/pool.c b/src/pool.c
index 391c755b7..8e7937191 100644
--- a/src/pool.c
+++ b/src/pool.c
@@ -370,6 +370,13 @@ struct pool_head *create_pool_from_reg(const char *name, struct pool_registratio
 		return NULL;
 	}
 
+	if (invalid_char(name)) {
+		ha_alert("Pool '%s' declared at %s:%u contains invalid chars in its name and "
+			 "cannot be registered. Please report to developers. Aborting.\n",
+			 name, reg->file, reg->line);
+		return NULL;
+	}
+
 	extra_mark = (pool_debugging & POOL_DBG_TAG) ? POOL_EXTRA_MARK : 0;
 	extra_caller = (pool_debugging & POOL_DBG_CALLER) ? POOL_EXTRA_CALLER : 0;
 	extra = extra_mark + extra_caller;