From: Mark Andrews <marka@isc.org>
Date: Sun, 15 Feb 2009 23:39:53 +0000 (+0000)
Subject: 2553.   [bug]           Reference leak on DNSSEC validation errors. [RT #19291]
X-Git-Tag: v9.4.3-P1~1^5~10
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=bace9ed24dd5dbea145f13792dbe4642abec5ed7;p=thirdparty%2Fbind9.git

2553.   [bug]           Reference leak on DNSSEC validation errors. [RT #19291]
---

diff --git a/CHANGES b/CHANGES
index a0742e8f128..4916f0e35fb 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,5 @@
+2553.	[bug]		Reference leak on DNSSEC validation errors. [RT #19291]
+
 2552.	[bug]		zero-no-soa-ttl-cache was not being honoured.
 			[RT #19340]
 
diff --git a/lib/dns/validator.c b/lib/dns/validator.c
index 4e8080e1444..f7e0630cd78 100644
--- a/lib/dns/validator.c
+++ b/lib/dns/validator.c
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: validator.c,v 1.119.18.46 2009/01/19 00:36:27 marka Exp $ */
+/* $Id: validator.c,v 1.119.18.47 2009/02/15 23:39:53 marka Exp $ */
 
 /*! \file */
 
@@ -1606,6 +1606,7 @@ dlv_validatezonekey(dns_validator_t *val) {
 				break;
 		}
 		if (result != ISC_R_SUCCESS) {
+			dns_rdataset_disassociate(&trdataset);
 			validator_log(val, ISC_LOG_DEBUG(3),
 				      "no DNSKEY matching DLV");
 			continue;
@@ -1947,6 +1948,7 @@ validatezonekey(dns_validator_t *val) {
 				break;
 		}
 		if (result != ISC_R_SUCCESS) {
+			dns_rdataset_disassociate(&trdataset);
 			validator_log(val, ISC_LOG_DEBUG(3),
 				      "no DNSKEY matching DS");
 			continue;