From: Ondřej Surý <ondrej@sury.org>
Date: Thu, 10 Jun 2021 06:14:57 +0000 (+0200)
Subject: Move NAME_MAX and PATH_MAX from isc/platform.h to isc/dir.h
X-Git-Tag: v9.17.17~45^2~1
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=bf4a0e26dcd0b9a2e80e496ae64f53f56d96f50e;p=thirdparty%2Fbind9.git

Move NAME_MAX and PATH_MAX from isc/platform.h to isc/dir.h

The last remaining defines needed for platforms without NAME_MAX and
PATH_MAX (I'm looking at you, GNU Hurd) were moved to isc/dir.h where
it's prevalently used.
---

diff --git a/bin/dig/dig.c b/bin/dig/dig.c
index fbcd9737d7b..69cc7e0bf25 100644
--- a/bin/dig/dig.c
+++ b/bin/dig/dig.c
@@ -19,6 +19,7 @@
 
 #include <isc/app.h>
 #include <isc/attributes.h>
+#include <isc/dir.h>
 #include <isc/netaddr.h>
 #include <isc/parseint.h>
 #include <isc/platform.h>
diff --git a/bin/dnssec/dnssec-cds.c b/bin/dnssec/dnssec-cds.c
index 4da36c5f9e5..b58e62d78e3 100644
--- a/bin/dnssec/dnssec-cds.c
+++ b/bin/dnssec/dnssec-cds.c
@@ -24,6 +24,7 @@
 #include <isc/attributes.h>
 #include <isc/buffer.h>
 #include <isc/commandline.h>
+#include <isc/dir.h>
 #include <isc/file.h>
 #include <isc/hash.h>
 #include <isc/mem.h>
diff --git a/bin/dnssec/dnssec-dsfromkey.c b/bin/dnssec/dnssec-dsfromkey.c
index 618ab03cdc8..3d607299838 100644
--- a/bin/dnssec/dnssec-dsfromkey.c
+++ b/bin/dnssec/dnssec-dsfromkey.c
@@ -18,6 +18,7 @@
 #include <isc/attributes.h>
 #include <isc/buffer.h>
 #include <isc/commandline.h>
+#include <isc/dir.h>
 #include <isc/hash.h>
 #include <isc/mem.h>
 #include <isc/print.h>
diff --git a/bin/dnssec/dnssec-signzone.c b/bin/dnssec/dnssec-signzone.c
index d1ee147277f..4329fe7f0a2 100644
--- a/bin/dnssec/dnssec-signzone.c
+++ b/bin/dnssec/dnssec-signzone.c
@@ -36,6 +36,7 @@
 #include <isc/attributes.h>
 #include <isc/base32.h>
 #include <isc/commandline.h>
+#include <isc/dir.h>
 #include <isc/event.h>
 #include <isc/file.h>
 #include <isc/hash.h>
diff --git a/bin/named/geoip.c b/bin/named/geoip.c
index f38b2005053..e949d209e9a 100644
--- a/bin/named/geoip.c
+++ b/bin/named/geoip.c
@@ -15,6 +15,7 @@
 #include <maxminddb.h>
 #endif /* if defined(HAVE_GEOIP2) */
 
+#include <isc/dir.h>
 #include <isc/print.h>
 #include <isc/string.h>
 #include <isc/util.h>
diff --git a/fuzz/fuzz.h b/fuzz/fuzz.h
index 15b2592f7c2..abbce372edc 100644
--- a/fuzz/fuzz.h
+++ b/fuzz/fuzz.h
@@ -13,6 +13,7 @@
 #include <stddef.h>
 #include <stdint.h>
 
+#include <isc/dir.h>
 #include <isc/lang.h>
 #include <isc/mem.h>
 #include <isc/once.h>
diff --git a/lib/bind9/check.c b/lib/bind9/check.c
index 50ed64b48e9..a67f68a3560 100644
--- a/lib/bind9/check.c
+++ b/lib/bind9/check.c
@@ -23,6 +23,7 @@
 #include <isc/aes.h>
 #include <isc/base64.h>
 #include <isc/buffer.h>
+#include <isc/dir.h>
 #include <isc/file.h>
 #include <isc/hex.h>
 #include <isc/log.h>
diff --git a/lib/dns/journal.c b/lib/dns/journal.c
index 36ebbd17189..567692e7a44 100644
--- a/lib/dns/journal.c
+++ b/lib/dns/journal.c
@@ -15,6 +15,7 @@
 #include <stdlib.h>
 #include <unistd.h>
 
+#include <isc/dir.h>
 #include <isc/file.h>
 #include <isc/mem.h>
 #include <isc/print.h>
diff --git a/lib/dns/tests/geoip_test.c b/lib/dns/tests/geoip_test.c
index b7020ccc1d1..810f8378a68 100644
--- a/lib/dns/tests/geoip_test.c
+++ b/lib/dns/tests/geoip_test.c
@@ -24,6 +24,7 @@
 #include <cmocka.h>
 #include <maxminddb.h>
 
+#include <isc/dir.h>
 #include <isc/print.h>
 #include <isc/string.h>
 #include <isc/types.h>
diff --git a/lib/dns/view.c b/lib/dns/view.c
index dacb875a53d..5de3108d45d 100644
--- a/lib/dns/view.c
+++ b/lib/dns/view.c
@@ -20,6 +20,7 @@
 #endif /* ifdef HAVE_LMDB */
 
 #include <isc/atomic.h>
+#include <isc/dir.h>
 #include <isc/file.h>
 #include <isc/hash.h>
 #include <isc/lex.h>
diff --git a/lib/isc/include/isc/dir.h b/lib/isc/include/isc/dir.h
index f42ebe69592..8473f9bba8b 100644
--- a/lib/isc/include/isc/dir.h
+++ b/lib/isc/include/isc/dir.h
@@ -9,12 +9,12 @@
  * information regarding copyright ownership.
  */
 
-#ifndef ISC_DIR_H
-#define ISC_DIR_H 1
+#pragma once
 
 /*! \file */
 
 #include <dirent.h>
+#include <limits.h>
 
 #include <isc/lang.h>
 #include <isc/platform.h>
@@ -22,6 +22,14 @@
 
 #include <sys/types.h> /* Required on some systems. */
 
+#ifndef NAME_MAX
+#define NAME_MAX 256
+#endif
+
+#ifndef PATH_MAX
+#define PATH_MAX 1024
+#endif
+
 /*% Directory Entry */
 typedef struct isc_direntry {
 	char	     name[NAME_MAX];
@@ -69,5 +77,3 @@ isc_dir_createunique(char *templet);
  */
 
 ISC_LANG_ENDDECLS
-
-#endif /* ISC_DIR_H */
diff --git a/lib/isc/include/isc/platform.h.in b/lib/isc/include/isc/platform.h.in
index 73dbe80836c..ce32692f031 100644
--- a/lib/isc/include/isc/platform.h.in
+++ b/lib/isc/include/isc/platform.h.in
@@ -18,24 +18,6 @@
  ***** Platform-dependent defines.
  *****/
 
-/***
- *** System limitations
- ***/
-
-#include <limits.h>
-
-#ifndef NAME_MAX
-#define NAME_MAX 256
-#endif
-
-#ifndef PATH_MAX
-#define PATH_MAX 1024
-#endif
-
-#ifndef IOV_MAX
-#define IOV_MAX 1024
-#endif
-
 /*
  * Tell emacs to use C mode for this file.
  *
diff --git a/lib/ns/tests/plugin_test.c b/lib/ns/tests/plugin_test.c
index bf0af1cfd50..0e6296c601a 100644
--- a/lib/ns/tests/plugin_test.c
+++ b/lib/ns/tests/plugin_test.c
@@ -24,6 +24,7 @@
 #include <cmocka.h>
 
 #include <isc/attributes.h>
+#include <isc/dir.h>
 #include <isc/mem.h>
 #include <isc/platform.h>
 #include <isc/result.h>