From: Egor Shestakov <egor@ved1.me>
Date: Wed, 8 Apr 2026 15:24:56 +0000 (+0000)
Subject: MINOR: tools: memvprintf(): remove <out> check that always true
X-Git-Tag: v3.4-dev9~51
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=c82b10b8d28e4303e7de5da8362a90bca5713acc;p=thirdparty%2Fhaproxy.git

MINOR: tools: memvprintf(): remove <out> check that always true

memvprintf() exits early if the <out> is NULL, so the further NULL check is
redundant.

No backport needed.
---

diff --git a/src/tools.c b/src/tools.c
index 49398ae3d..12481ce1e 100644
--- a/src/tools.c
+++ b/src/tools.c
@@ -4678,10 +4678,8 @@ char *memvprintf(char **out, const char *format, va_list orig_args)
 		ha_free(&ret);
 	}
 
-	if (out) {
-		free(*out);
-		*out = ret;
-	}
+	free(*out);
+	*out = ret;
 
 	return ret;
 }