From: Mark Andrews <marka@isc.org>
Date: Tue, 2 Jan 2018 23:07:42 +0000 (+1100)
Subject: 4854.   [bug]           query_synthcnamewildcard should stop generating the
X-Git-Tag: v9.13.0~310
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=c9ee9718aeb203ce54824852b34f37f471849f40;p=thirdparty%2Fbind9.git

4854.   [bug]           query_synthcnamewildcard should stop generating the
                        response if query_synthwildcard fails. [RT #46939]
---

diff --git a/CHANGES b/CHANGES
index 2c4b3285226..322f65d4004 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,6 @@
+4854.	[bug]		query_synthcnamewildcard should stop generating the
+			response if query_synthwildcard fails. [RT #46939]
+
 4853.	[bug]		Add REQUIRE's and INSIST's to isc_time_formatISO8601L
 			and isc_time_formatISO8601Lms. [RT #46916]
 
diff --git a/lib/ns/query.c b/lib/ns/query.c
index 6f8df29dcea..356ca9aa13f 100644
--- a/lib/ns/query.c
+++ b/lib/ns/query.c
@@ -8549,6 +8549,10 @@ query_synthcnamewildcard(query_ctx_t *qctx, dns_rdataset_t *rdataset,
 	dns_rdata_cname_t cname;
 
 	result = query_synthwildcard(qctx, rdataset, sigrdataset);
+	if (result != ISC_R_SUCCESS) {
+		return (result);
+	}
+
 	qctx->client->query.attributes |= NS_QUERYATTR_PARTIALANSWER;
 
 	/*