From: Florian Mickler <florian@mickler.org>
Date: Mon, 13 Jan 2020 00:44:24 +0000 (+0100)
Subject: openssl ca: make index.txt parsing error more verbose
X-Git-Tag: openssl-3.0.0-beta1~408
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=ca29cc1453945fe92c86a312c0f94a8976a46856;p=thirdparty%2Fopenssl.git

openssl ca: make index.txt parsing error more verbose

If index.txt exists but has some problems (like for example a single \n character in it) openssl will just exit without any error message.

Bug at least expirienced twice: https://superuser.com/questions/1327848/openssl-ca-fails-after-password-without-error-message

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/15360)
---

diff --git a/apps/ca.c b/apps/ca.c
index 923ede4cde0..32abc021a6b 100755
--- a/apps/ca.c
+++ b/apps/ca.c
@@ -556,8 +556,10 @@ end_of_options:
             goto end;
 
         db = load_index(dbfile, &db_attr);
-        if (db == NULL)
+        if (db == NULL) {
+            BIO_printf(bio_err, "Problem with index file: %s (could not load/parse file)\n", dbfile);
             goto end;
+        }
 
         if (index_index(db) <= 0)
             goto end;
@@ -684,8 +686,10 @@ end_of_options:
         goto end;
 
     db = load_index(dbfile, &db_attr);
-    if (db == NULL)
+    if (db == NULL) {
+        BIO_printf(bio_err, "Problem with index file: %s (could not load/parse file)\n", dbfile);
         goto end;
+    }
 
     /* Lets check some fields */
     for (i = 0; i < sk_OPENSSL_PSTRING_num(db->db->data); i++) {