From: Michał Kępień <michal@isc.org>
Date: Thu, 21 May 2026 09:52:56 +0000 (+0200)
Subject: Drop redundant uses of authoritative=True
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=cfa16e3f247ce35e7d78f3c1c62a9721b7f924eb;p=thirdparty%2Fbind9.git

Drop redundant uses of authoritative=True

The ans3 custom server instance is created with default_aa=True.  Do not
pass the authoritative=True keyword argument to the DnsResponseSend
constructor in CookieHandler.get_responses() as it is redundant.

(cherry picked from commit c61539279d4ecc04f9816b2ae62d63ed8a143c19)
---

diff --git a/bin/tests/system/resend_loop/ans3/ans.py b/bin/tests/system/resend_loop/ans3/ans.py
index f6543e0eace..f3c6c9fec16 100644
--- a/bin/tests/system/resend_loop/ans3/ans.py
+++ b/bin/tests/system/resend_loop/ans3/ans.py
@@ -73,13 +73,13 @@ class CookieHandler(DomainHandler):
         # If missing cookie entirely, just return SERVFAIL
         if cookie is None:
             qctx.response.set_rcode(dns.rcode.SERVFAIL)
-            yield DnsResponseSend(qctx.response, authoritative=True)
+            yield DnsResponseSend(qctx.response)
 
         # If there is a client cookie, mock BADCOOKIE to trigger
         # the resend loop logic.
         qctx.response.use_edns(options=[cookie])
         qctx.response.set_rcode(dns.rcode.BADCOOKIE)
-        yield DnsResponseSend(qctx.response, authoritative=True)
+        yield DnsResponseSend(qctx.response)
 
 
 def resend_server() -> AsyncDnsServer: