From: Evan Hunt <each@isc.org>
Date: Fri, 28 Sep 2012 20:46:47 +0000 (-0700)
Subject: improve logging of ecdsa errors
X-Git-Tag: v9.10.0a1~859
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=d1ac7adb3e2620b7a22d6141e814800aefc7e844;p=thirdparty%2Fbind9.git

improve logging of ecdsa errors

3384.	[bug]		Improved logging of crypto errors. [RT #30963]
---

diff --git a/CHANGES b/CHANGES
index d62a87de9fc..4db4d2f5f52 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,5 @@
+3384.	[bug]		Improved logging of crypto errors. [RT #30963]
+
 3383.	[security]	A certain combination of records in the RBT could
                         cause named to hang while populating the additional
                         section of a response. [RT #31090]
diff --git a/lib/dns/openssl_link.c b/lib/dns/openssl_link.c
index d186761c2ca..bac910af166 100644
--- a/lib/dns/openssl_link.c
+++ b/lib/dns/openssl_link.c
@@ -286,40 +286,63 @@ dst__openssl_destroy() {
 	}
 }
 
-isc_result_t
-dst__openssl_toresult(isc_result_t fallback) {
+static isc_result_t
+toresult(isc_result_t fallback) {
 	isc_result_t result = fallback;
 	unsigned long err = ERR_get_error();
+	int lib = ERR_GET_LIB(err);
+	int reason = ERR_GET_REASON(err);
 
-	switch (ERR_GET_REASON(err)) {
+	switch (reason) {
+	/*
+	 * ERR_* errors are globally unique; others
+	 * are unique per sublibrary
+	 */
 	case ERR_R_MALLOC_FAILURE:
 		result = ISC_R_NOMEMORY;
 		break;
 	default:
+#ifdef ERR_R_ECDSA_LIB
+		if (lib == ERR_R_ECDSA_LIB && 
+		    reason == ECDSA_R_RANDOM_NUMBER_GENERATION_FAILED) {
+			result = ISC_R_NOENTROPY;
+			break;
+		}
+#endif
 		break;
 	}
+
+	return (result);
+}
+
+isc_result_t
+dst__openssl_toresult(isc_result_t fallback) {
+	isc_result_t result;
+
+	result = toresult(fallback);
+
 	ERR_clear_error();
 	return (result);
 }
 
 isc_result_t
 dst__openssl_toresult2(const char *funcname, isc_result_t fallback) {
-	isc_result_t result = fallback;
+	isc_result_t result;
 	unsigned long err = ERR_peek_error();
 	const char *file, *data;
 	int line, flags;
 	char buf[256];
 
-	switch (ERR_GET_REASON(err)) {
-	case ERR_R_MALLOC_FAILURE:
-		result = ISC_R_NOMEMORY;
-		goto done;
-	default:
-		break;
-	}
+	result = toresult(fallback);
+
 	isc_log_write(dns_lctx, DNS_LOGCATEGORY_GENERAL,
 		      DNS_LOGMODULE_CRYPTO, ISC_LOG_WARNING,
-		      "%s failed", funcname);
+		      "%s failed (%s)", funcname,
+		      isc_result_totext(result));
+
+	if (result == ISC_R_NOMEMORY)
+		goto done;
+
 	for (;;) {
 		err = ERR_get_error_line_data(&file, &line, &data, &flags);
 		if (err == 0U)