From: Evan Hunt <each@isc.org>
Date: Thu, 21 Jan 2016 01:30:27 +0000 (-0800)
Subject: [master] cacluate TCP packet sizes correctly
X-Git-Tag: v9.11.0a1~185
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=d40154cab71b0c774d80df2c0091e1f8edcaa7d4;p=thirdparty%2Fbind9.git

[master] cacluate TCP packet sizes correctly

4296.	[bug]		TCP packet sizes were calculated incorrectly in the
			stats channel; they could be counted in the wrong
			histogram bucket. [RT #40587]
---

diff --git a/CHANGES b/CHANGES
index 7a91b5a2af9..5fb07156e7e 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,7 @@
+4296.	[bug]		TCP packet sizes were calculated incorrectly in the
+			stats channel; they could be counted in the wrong
+			histogram bucket. [RT #40587]
+
 4295.	[bug]		An unchecked result in dns_message_pseudosectiontotext()
 			could allow incorrect text formatting of EDNS EXPIRE
 			options. [RT #41437]
diff --git a/bin/named/client.c b/bin/named/client.c
index 242e4a30fc6..21dabd2d28e 100644
--- a/bin/named/client.c
+++ b/bin/named/client.c
@@ -1166,7 +1166,8 @@ client_send(ns_client_t *client) {
 		isc_buffer_putuint16(&tcpbuffer, (isc_uint16_t) r.length);
 		isc_buffer_add(&tcpbuffer, r.length);
 
-		respsize = isc_buffer_usedlength(&tcpbuffer);
+		/* don't count the 2-octet length header */
+		respsize = isc_buffer_usedlength(&tcpbuffer) - 2;
 		result = client_sendpkg(client, &tcpbuffer);
 
 #ifdef HAVE_DNSTAP
@@ -2145,6 +2146,9 @@ client_request(isc_task_t *task, isc_event_t *event) {
 	}
 
 	reqsize = isc_buffer_usedlength(buffer);
+	/* don't count the length header */
+	if (TCP_CLIENT(client))
+		reqsize -= 2;
 
 	if (exit_check(client))
 		goto cleanup;
diff --git a/bin/tests/system/statschannel/traffic.expect.5 b/bin/tests/system/statschannel/traffic.expect.5
index d29db3496a5..15911b16254 100644
--- a/bin/tests/system/statschannel/traffic.expect.5
+++ b/bin/tests/system/statschannel/traffic.expect.5
@@ -1,6 +1,6 @@
 tcp request-size 16-31: 1
 tcp request-size 48-63: 1
-tcp response-size 128-143: 1
+tcp response-size 112-127: 1
 tcp response-size 64-79: 1
 udp request-size 48-63: 2
 udp response-size 112-127: 1
diff --git a/bin/tests/system/statschannel/traffic.expect.6 b/bin/tests/system/statschannel/traffic.expect.6
index d75b3c1ef48..73fc8f1831d 100644
--- a/bin/tests/system/statschannel/traffic.expect.6
+++ b/bin/tests/system/statschannel/traffic.expect.6
@@ -1,6 +1,6 @@
 tcp request-size 16-31: 1
 tcp request-size 48-63: 2
-tcp response-size 128-143: 1
+tcp response-size 112-127: 1
 tcp response-size 64-79: 1
 tcp response-size 848-863: 1
 udp request-size 48-63: 2