From: Al Viro <viro@zeniv.linux.org.uk>
Date: Tue, 26 May 2026 23:23:56 +0000 (-0400)
Subject: create_default_group(): pass parent's dentry instead of config_group
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=d53ac61b6120fa596d758ff6e22b5dcb6db21ce8;p=thirdparty%2Fkernel%2Flinux.git

create_default_group(): pass parent's dentry instead of config_group

the only way parent_group is used there...

Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---

diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c
index 8fc05fe69992..4d82375b0cfd 100644
--- a/fs/configfs/dir.c
+++ b/fs/configfs/dir.c
@@ -701,14 +701,14 @@ static void detach_groups(struct dentry *dentry)
  * We could, perhaps, tweak our parent's ->mkdir for a minute and
  * try using vfs_mkdir.  Just a thought.
  */
-static int create_default_group(struct config_group *parent_group,
+static int create_default_group(struct dentry *parent,
 				struct config_group *group,
 				struct configfs_fragment *frag)
 {
 	int ret;
 	struct configfs_dirent *sd;
 	/* We trust the caller holds a reference to parent */
-	struct dentry *child, *parent = parent_group->cg_item.ci_dentry;
+	struct dentry *child;
 
 	if (!group->cg_item.ci_name)
 		group->cg_item.ci_name = group->cg_item.ci_namebuf;
@@ -735,10 +735,11 @@ static int create_default_group(struct config_group *parent_group,
 static int populate_groups(struct config_group *group,
 			   struct configfs_fragment *frag)
 {
+	struct dentry *parent = group->cg_item.ci_dentry;
 	struct config_group *new_group;
 
 	list_for_each_entry(new_group, &group->default_groups, group_entry) {
-		int ret = create_default_group(group, new_group, frag);
+		int ret = create_default_group(parent, new_group, frag);
 		if (ret)
 			return ret;
 	}
@@ -1767,7 +1768,7 @@ int configfs_register_group(struct config_group *parent_group,
 	parent = parent_group->cg_item.ci_dentry;
 
 	inode_lock_nested(d_inode(parent), I_MUTEX_PARENT);
-	ret = create_default_group(parent_group, group, frag);
+	ret = create_default_group(parent, group, frag);
 	if (ret)
 		goto err_out;