From: Rafael J. Wysocki Date: Mon, 1 Jun 2026 17:00:47 +0000 (+0200) Subject: ACPI: button: Eliminate redundant conditional statement X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=d9fa7b95d11d7cdf2930ebac155f7ee8f2d6ebdd;p=thirdparty%2Flinux.git ACPI: button: Eliminate redundant conditional statement Simplify do_update initialization in acpi_lid_notify_state() by assigning the value of the condition it depends on directly to it. No intentional functional impact. Signed-off-by: Rafael J. Wysocki Link: https://patch.msgid.link/10868292.nUPlyArG6x@rafael.j.wysocki --- diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c index fcb2eed823c15..236eb025bb0dc 100644 --- a/drivers/acpi/button.c +++ b/drivers/acpi/button.c @@ -217,12 +217,8 @@ static void acpi_lid_notify_state(struct acpi_button *button, bool state) * So "last_time" is only updated after a timeout or an actual * switch. */ - if (lid_init_state != ACPI_BUTTON_LID_INIT_IGNORE || - button->last_state != state) - do_update = true; - else - do_update = false; - + do_update = lid_init_state != ACPI_BUTTON_LID_INIT_IGNORE || + button->last_state != state; next_report = ktime_add(button->last_time, ms_to_ktime(lid_report_interval)); if (button->last_state == state &&