From: Mark Andrews Date: Wed, 9 Sep 2020 05:28:57 +0000 (+1000) Subject: LOCK should be UNLOCK X-Git-Tag: v9.11.24~29^2 X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=e075ae082c695f0092764e68c093c03f5658ebe8;p=thirdparty%2Fbind9.git LOCK should be UNLOCK *** CID 306731: Program hangs (LOCK) /lib/dns/resolver.c: 8943 in spillattimer_countdown() 8937 result = isc_timer_reset(res->spillattimer, 8938 isc_timertype_inactive, NULL, 8939 NULL, true); 8940 RUNTIME_CHECK(result == ISC_R_SUCCESS); 8941 } 8942 count = res->spillat; CID 306731: Program hangs (LOCK) "pthread_mutex_lock" locks "res->spill_lock" while it is locked. 8943 LOCK(&res->spill_lock); 8944 UNLOCK(&res->lock); 8945 if (logit) 8946 isc_log_write(dns_lctx, DNS_LOGCATEGORY_RESOLVER, 8947 DNS_LOGMODULE_RESOLVER, ISC_LOG_NOTICE, 8948 "clients-per-query decreased to %u", count); --- diff --git a/lib/dns/resolver.c b/lib/dns/resolver.c index 5984e00ab8c..ecac678192e 100644 --- a/lib/dns/resolver.c +++ b/lib/dns/resolver.c @@ -8940,7 +8940,7 @@ spillattimer_countdown(isc_task_t *task, isc_event_t *event) { RUNTIME_CHECK(result == ISC_R_SUCCESS); } count = res->spillat; - LOCK(&res->spill_lock); + UNLOCK(&res->spill_lock); UNLOCK(&res->lock); if (logit) isc_log_write(dns_lctx, DNS_LOGCATEGORY_RESOLVER,