From: Mukund Sivaraman <muks@isc.org>
Date: Wed, 18 Mar 2015 01:12:54 +0000 (+0530)
Subject: Fix a crash due to use-after-free (#38495)
X-Git-Tag: v9.11.0a1~911
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=ebeb4b3e094f36121e05d7cc8226047db96ba4f6;p=thirdparty%2Fbind9.git

Fix a crash due to use-after-free (#38495)
---

diff --git a/CHANGES b/CHANGES
index b458bced4fa..d915355e45b 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,6 @@
+4087.	[bug]		Fix a crash due to use-after-free due to sequencing
+			of tasks actions. [RT #38495]
+
 4086.	[bug]		Fix out-of-srcdir build with native pkcs11. [RT #38831]
 
 4085.	[bug]		ISC_PLATFORM_HAVEXADDQ could be inconsistently set.
diff --git a/lib/dns/adb.c b/lib/dns/adb.c
index f235879b5ce..4e8785d696b 100644
--- a/lib/dns/adb.c
+++ b/lib/dns/adb.c
@@ -1519,6 +1519,7 @@ clean_finds_at_name(dns_adbname_t *name, isc_eventtype_t evtype,
 			   ev, task, find);
 
 			isc_task_sendanddetach(&task, (isc_event_t **)&ev);
+			find->flags |= FIND_EVENT_SENT;
 		} else {
 			DP(DEF_LEVEL, "cfan: skipping find %p", find);
 		}
diff --git a/lib/dns/zone.c b/lib/dns/zone.c
index 57ced0c541f..e2419cc639d 100644
--- a/lib/dns/zone.c
+++ b/lib/dns/zone.c
@@ -10206,9 +10206,6 @@ static void
 notify_destroy(dns_notify_t *notify, isc_boolean_t locked) {
 	isc_mem_t *mctx;
 
-	/*
-	 * Caller holds zone lock.
-	 */
 	REQUIRE(DNS_NOTIFY_VALID(notify));
 
 	if (notify->zone != NULL) {