From: Lukáš Ondráček <lukas.ondracek@nic.cz>
Date: Tue, 2 Apr 2024 15:47:27 +0000 (+0200)
Subject: fixup! rrl: allow changing configuration on reload
X-Git-Tag: v6.0.9~1^2~66
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=refs%2Fenvironments%2Fdocs-develop-rrl-8r8r8r%2Fdeployments%2F3660;p=thirdparty%2Fknot-resolver.git

fixup! rrl: allow changing configuration on reload
---

diff --git a/daemon/rrl/api.c b/daemon/rrl/api.c
index d6b332933..264f16905 100644
--- a/daemon/rrl/api.c
+++ b/daemon/rrl/api.c
@@ -120,11 +120,11 @@ void kr_rrl_deinit(void)
 	fl.l_type = F_WRLCK;
 	if (fcntl(fd, F_SETLK, &fl) != -1) {
 
-		/* If the RRL configuration is updated at runtime, manager should remove the file (TODO)
-		 * and keep new processes create it again while old processes are still using the old data.
+		/* If the RRL configuration is updated at runtime, manager removes the file
+		 * and the new processes create it again while old processes are still using the old data.
 		 * Here we keep zero-size file not to accidentally remove the new file instead of the old one.
 		 * Still truncating the file will cause currently starting processes waiting for read lock on the same file to fail,
-		 * but this is not expected to happen. */
+		 * but such processes are not expected to exist. */
 		ftruncate(fd, 0);
 
 		fl.l_type = F_UNLCK;