From: Stefan Schantl <stefan.schantl@ipfire.org>
Date: Sat, 10 Oct 2015 18:00:10 +0000 (+0200)
Subject: pppoe-server: Check for valid network
X-Git-Url: http://git.ipfire.org/gitweb/?a=commitdiff_plain;h=refs%2Fheads%2Fpppoe-server-fix;p=people%2Fstevee%2Fnetwork.git

pppoe-server: Check for valid network

The pppoe-server did not proper check if a valid
IPv4 or IPv6 network has been specified.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
---

diff --git a/src/hooks/configs/pppoe-server b/src/hooks/configs/pppoe-server
index 1ef3ba9c..ac9b90a0 100644
--- a/src/hooks/configs/pppoe-server
+++ b/src/hooks/configs/pppoe-server
@@ -42,6 +42,12 @@ hook_check_config_settings() {
 	assert isset SUBNET
 	assert isset MAX_SESSIONS
 
+	# Check input.
+	if ! ip_is_network "${SUBNET}"; then
+		log ERROR "Invalid subnet. Please provide a valid IPv6 or IPv4 network."
+		return ${EXIT_ERROR}
+	fi
+
 	local server
 	for server in ${DNS_SERVERS}; do
 		assert ipv4_is_valid "${server}"