Damien Miller [Fri, 10 May 2013 03:41:33 +0000 (13:41 +1000)]
- djm@cvs.openbsd.org 2013/04/11 02:27:50
[packet.c]
quiet disconnect notifications on the server from error() back to logit()
if it is a normal client closure; bz#2057 ok+feedback dtucker@
Darren Tucker [Fri, 5 Apr 2013 00:18:57 +0000 (11:18 +1100)]
- dtucker@cvs.openbsd.org 2013/02/22 04:45:09
[ssh.c readconf.c readconf.h]
Don't complain if IdentityFiles specified in system-wide configs are
missing. ok djm, deraadt
Darren Tucker [Fri, 5 Apr 2013 00:13:30 +0000 (11:13 +1100)]
- dtucker@cvs.openbsd.org 2013/02/17 23:16:57
[readconf.c ssh.c readconf.h sshconnect2.c]
Keep track of which IndentityFile options were manually supplied and which
were default options, and don't warn if the latter are missing.
ok markus@
Darren Tucker [Thu, 4 Apr 2013 23:53:30 +0000 (10:53 +1100)]
- (dtucker) [openbsd-compat/bsd-cygwin_util.{c,h}] Don't include windows.h
to avoid conflicting definitions of __int64, adding the required bits.
Patch from Corinna Vinschen.
(pulled from HEAD but kept the ChangeLog date as it was)
Darren Tucker [Mon, 1 Apr 2013 01:40:48 +0000 (12:40 +1100)]
- (dtucker) [openbsd-compat/bsd-cygwin_util.{c,h}] Don't include windows.h
to avoid conflicting definitions of __int64, adding the required bits.
Patch from Corinna Vinschen.
Damien Miller [Wed, 20 Mar 2013 01:55:14 +0000 (12:55 +1100)]
- (djm) [configure.ac log.c scp.c sshconnect2.c openbsd-compat/vis.c]
[openbsd-compat/vis.h] FreeBSD's strnvis isn't compatible with OpenBSD's
so mark it as broken. Patch from des AT des.no
Damien Miller [Fri, 15 Mar 2013 00:22:37 +0000 (11:22 +1100)]
- (djm) [session.c] FreeBSD needs setusercontext(..., LOGIN_SETUMASK) to
occur after UID switch; patch from John Marshall via des AT des.no;
ok dtucker@
Darren Tucker [Tue, 12 Mar 2013 00:31:05 +0000 (11:31 +1100)]
- (dtucker) [auth.c configure.ac platform.c platform.h] Accept uid 2 ("bin")
in addition to root as an owner of system directories on AIX and HP-UX.
ok djm@
Darren Tucker [Tue, 12 Mar 2013 00:19:40 +0000 (11:19 +1100)]
- (dtucker) [regress/Makefile regress/cipher-speed.sh regress/test-exec.sh]
Improve portability of cipher-speed test, based mostly on a patch from
Iain Morgan.
Darren Tucker [Wed, 6 Mar 2013 06:48:48 +0000 (17:48 +1100)]
- (dtucker) [configure.ac] test that we can set number of file descriptors
to zero with setrlimit before enabling the rlimit sandbox. This affects
(at least) HPUX 11.11.
Darren Tucker [Tue, 5 Mar 2013 10:50:09 +0000 (21:50 +1100)]
- (dtucker) [Makefile.in] Remove trailing "\" on PATHS, which caused obscure
build breakage on (at least) HP-UX 11.11. Found by Amit Kulkarni and Kevin
Brott.
Damien Miller [Tue, 26 Feb 2013 07:58:06 +0000 (18:58 +1100)]
- djm@cvs.openbsd.org 2013/02/20 08:27:50
[integrity.sh]
Add an option to modpipe that warns if the modification offset it not
reached in it's stream and turn it on for t-integrity. This should catch
cases where the session is not fuzzed for being too short (cf. my last
"oops" commit)
Damien Miller [Wed, 20 Feb 2013 10:13:27 +0000 (21:13 +1100)]
- djm@cvs.openbsd.org 2013/02/20 08:27:50
[regress/integrity.sh regress/modpipe.c]
Add an option to modpipe that warns if the modification offset it not
reached in it's stream and turn it on for t-integrity. This should catch
cases where the session is not fuzzed for being too short (cf. my last
"oops" commit)
Tim Rice [Wed, 20 Feb 2013 03:01:51 +0000 (19:01 -0800)]
- (tim) [krl.c Makefile.in regress/Makefile regress/modpipe.c] remove unneeded
err.h include from krl.c. Additional portability fixes for modpipe. OK djm
Damien Miller [Tue, 19 Feb 2013 02:15:01 +0000 (13:15 +1100)]
- djm@cvs.openbsd.org 2013/02/19 02:14:09
[integrity.sh]
oops, forgot to increase the output of the ssh command to ensure that
we actually reach $offset
Damien Miller [Mon, 18 Feb 2013 22:28:32 +0000 (09:28 +1100)]
- djm@cvs.openbsd.org 2013/02/18 22:26:47
[integrity.sh]
crank the offset yet again; it was still fuzzing KEX one of Darren's
portable test hosts at 2800
Damien Miller [Sun, 17 Feb 2013 23:18:05 +0000 (10:18 +1100)]
- djm@cvs.openbsd.org 2013/02/17 23:16:55
[integrity.sh]
make the ssh command generates some output to ensure that there are at
least offset+tries bytes in the stream.
Damien Miller [Sat, 16 Feb 2013 06:32:31 +0000 (17:32 +1100)]
- djm@cvs.openbsd.org 2013/02/16 06:08:45
[integrity.sh]
make sure the fuzz offset is actually past the end of KEX for all KEX
types. diffie-hellman-group-exchange-sha256 requires an offset around
2700. Noticed via test failures in portable OpenSSH on platforms that
lack ECC and this the more byte-frugal ECDH KEX algorithms.
Damien Miller [Fri, 15 Feb 2013 01:18:32 +0000 (12:18 +1100)]
- dtucker@cvs.openbsd.org 2013/02/15 00:21:01
[sshconnect2.c]
Warn more loudly if an IdentityFile provided by the user cannot be read.
bz #1981, ok djm@
Darren Tucker [Fri, 15 Feb 2013 01:13:01 +0000 (12:13 +1100)]
- (dtucker) [configure.ac openbsd-compat/Makefile.in openbsd-compat/strtoull.c
openbsd-compat/openbsd-compat.h] Add strtoull to compat library for
platforms that don't have it.
Damien Miller [Thu, 14 Feb 2013 23:28:55 +0000 (10:28 +1100)]
- djm@cvs.openbsd.org 2013/02/14 21:35:59
[auth2-pubkey.c]
Correct error message that had a typo and was logging the wrong thing;
patch from Petr Lautrbach
Damien Miller [Wed, 13 Feb 2013 23:32:33 +0000 (10:32 +1100)]
- (djm) [regress/integrity.sh] Start fuzzing from offset 2500 (instead
of 2300) to avoid clobbering the end of (non-MAC'd) KEX. Verified by
Iain Morgan
Damien Miller [Tue, 12 Feb 2013 00:03:58 +0000 (11:03 +1100)]
- djm@cvs.openbsd.org 2013/02/10 23:35:24
[packet.c]
record "Received disconnect" messages at ERROR rather than INFO priority,
since they are abnormal and result in a non-zero ssh exit status; patch
from Iain Morgan in bz#2057; ok dtucker@
Damien Miller [Tue, 12 Feb 2013 00:03:36 +0000 (11:03 +1100)]
- djm@cvs.openbsd.org 2013/02/10 23:32:10
[ssh-keygen.c]
append to moduli file when screening candidates rather than overwriting.
allows resumption of interrupted screen; patch from Christophe Garault
in bz#1957; ok dtucker@
Damien Miller [Tue, 12 Feb 2013 00:02:46 +0000 (11:02 +1100)]
- djm@cvs.openbsd.org 2013/02/08 00:41:12
[sftp.c]
fix NULL deref when built without libedit and control characters
entered as command; debugging and patch from Iain Morgan an
Loganaden Velvindron in bz#1956
Damien Miller [Tue, 12 Feb 2013 00:02:08 +0000 (11:02 +1100)]
- dtucker@cvs.openbsd.org 2013/02/06 00:20:42
[servconf.c sshd_config sshd_config.5]
Change default of MaxStartups to 10:30:100 to start doing random early
drop at 10 connections up to 100 connections. This will make it harder
to DoS as CPUs have come a long way since the original value was set
back in 2000. Prompted by nion at debian org, ok markus@
Damien Miller [Tue, 12 Feb 2013 00:00:34 +0000 (11:00 +1100)]
- djm@cvs.openbsd.org 2013/01/26 06:11:05
[Makefile.in acss.c acss.h cipher-acss.c cipher.c]
[openbsd-compat/openssl-compat.h]
remove ACSS, now that it is gone from libcrypto too
Damien Miller [Mon, 11 Feb 2013 23:56:42 +0000 (10:56 +1100)]
- djm@cvs.openbsd.org 2013/01/25 10:22:19
[krl.c]
redo last commit without the vi-vomit that snuck in:
skip serial lookup when cert's serial number is zero
(now with 100% better comment)
Damien Miller [Wed, 6 Feb 2013 23:11:05 +0000 (10:11 +1100)]
- (djm) [configure.ac] Don't probe seccomp capability of running kernel
at configure time; the seccomp sandbox will fall back to rlimit at
runtime anyway. Patch from plautrba AT redhat.com in bz#2011