]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
3 months agoIncrease jlibtool test timeout to 600s under sanitizers ci-debug
Arran Cudbard-Bell [Tue, 24 Feb 2026 04:10:09 +0000 (21:10 -0700)] 
Increase jlibtool test timeout to 600s under sanitizers

The O2-g3 sanitizer build was hitting the 300s jlibtool timeout
on unit_test_module tests (e.g. modules/files/vendor).  Double
the timeout when sanitizers are enabled to account for ASAN overhead.

3 months agoIncrease eapol_test timeout to 30s under sanitizers
Arran Cudbard-Bell [Tue, 24 Feb 2026 03:58:21 +0000 (20:58 -0700)] 
Increase eapol_test timeout to 30s under sanitizers

The 10 second eapol_test timeout is too tight when running under
address sanitizer with detect_stack_use_after_return=1 and
fast_unwind_on_malloc=0.  Multi-round-trip EAP-TLS handshakes
with certificate verification can exceed 10s under this load,
causing the most frequent CI-Sanitizers failure
(ttls-client-eap-tls timeout).

Set EAPOL_TEST_TIMEOUT conditionally: 30s when sanitizers are
enabled, 10s otherwise.

3 months agoAdd Claude Code GitHub Workflow (#5752)
Arran Cudbard-Bell [Mon, 23 Feb 2026 23:11:12 +0000 (16:11 -0700)] 
Add Claude Code GitHub Workflow (#5752)

* "Claude PR Assistant workflow"

* "Claude Code Review workflow"

3 months agoshut up clang scan
Alan T. DeKok [Mon, 23 Feb 2026 17:18:05 +0000 (12:18 -0500)] 
shut up clang scan

which claims some bizarre things if the check for !secret is
hoisted to the top of the do_challenge() function.

3 months agominor bug fixes in radius decoder
Alan T. DeKok [Mon, 23 Feb 2026 17:10:18 +0000 (12:10 -0500)] 
minor bug fixes in radius decoder

3 months agodecode continued attributes into the correct parent
Alan T. DeKok [Mon, 23 Feb 2026 17:07:19 +0000 (12:07 -0500)] 
decode continued attributes into the correct parent

3 months agoprint name2 if we can't find the section
Alan T. DeKok [Mon, 23 Feb 2026 16:04:45 +0000 (11:04 -0500)] 
print name2 if we can't find the section

unused sections are a warning without -C, and an error with -C

Unless the unused section is a case difference from a known one,
in which case it's an error even without -C.

We don't want people to make typos, and have the server silently
ignore critical pieces of the config.

3 months agovarious bug fixes and tweaks to unlang
Alan T. DeKok [Sun, 22 Feb 2026 17:48:33 +0000 (12:48 -0500)] 
various bug fixes and tweaks to unlang

3 months agoadd partial page for "this isn't RADIUS"
Alan T. DeKok [Sun, 22 Feb 2026 17:47:01 +0000 (12:47 -0500)] 
add partial page for "this isn't RADIUS"

and various other minor tweaks

3 months agotweak proxy-state missing -> proxy state without MA
Alan T. DeKok [Sun, 22 Feb 2026 17:01:14 +0000 (12:01 -0500)] 
tweak proxy-state missing -> proxy state without MA

3 months agovarious bug fixes in radmin.c
Alan T. DeKok [Fri, 20 Feb 2026 16:25:43 +0000 (11:25 -0500)] 
various bug fixes in radmin.c

3 months agotypos
Alan T. DeKok [Sat, 21 Feb 2026 00:45:16 +0000 (19:45 -0500)] 
typos

3 months agoPacify Coverity (CID #1681443)
Nick Porter [Mon, 23 Feb 2026 08:33:30 +0000 (08:33 +0000)] 
Pacify Coverity (CID #1681443)

3 months agoPacify Coverity (CID #1681444)
Nick Porter [Mon, 23 Feb 2026 08:27:48 +0000 (08:27 +0000)] 
Pacify Coverity (CID #1681444)

3 months agoreword and touchup
Alan T. DeKok [Sat, 21 Feb 2026 15:23:16 +0000 (10:23 -0500)] 
reword and touchup

3 months agotypo
Alan T. DeKok [Sat, 21 Feb 2026 15:08:04 +0000 (10:08 -0500)] 
typo

3 months agodocs-v4: update troubleshooting with common errors page HIVE 7914
nolade [Thu, 19 Feb 2026 21:27:12 +0000 (16:27 -0500)] 
docs-v4: update troubleshooting with common errors page HIVE 7914

3 months agopull changes back into raddb, and regenerate from "make doc.raddb"
Alan T. DeKok [Sat, 21 Feb 2026 14:47:22 +0000 (09:47 -0500)] 
pull changes back into raddb, and regenerate from "make doc.raddb"

3 months agodocs-v4: correct typos from Alan's first report Hive 8329
nolade [Fri, 20 Feb 2026 20:02:10 +0000 (15:02 -0500)] 
docs-v4: correct typos from Alan's first report Hive 8329

3 months agodocs-v4: convert american spelling to UK spelling Hive 8329
nolade [Fri, 20 Feb 2026 19:34:11 +0000 (14:34 -0500)] 
docs-v4: convert american spelling to UK spelling Hive 8329

3 months agodocs-v4: fix spelling errors Hive 8329 (excluded raddb)
nolade [Fri, 20 Feb 2026 18:27:12 +0000 (13:27 -0500)] 
docs-v4: fix spelling errors Hive 8329 (excluded raddb)

3 months agocheck that the packet is OK
Alan T. DeKok [Sat, 21 Feb 2026 14:25:45 +0000 (09:25 -0500)] 
check that the packet is OK

3 months agoadd Net.* attributes
Alan T. DeKok [Sat, 21 Feb 2026 14:22:19 +0000 (09:22 -0500)] 
add Net.* attributes

3 months agotweak code to reduce indentation and redundancy
Alan T. DeKok [Sat, 21 Feb 2026 12:54:04 +0000 (07:54 -0500)] 
tweak code to reduce indentation and redundancy

3 months agomove checks to quiet analyzer
Alan T. DeKok [Sat, 21 Feb 2026 01:40:29 +0000 (20:40 -0500)] 
move checks to quiet analyzer

3 months agomessage type can have only one octet according to RFC2132
Alan T. DeKok [Sat, 21 Feb 2026 01:37:04 +0000 (20:37 -0500)] 
message type can have only one octet according to RFC2132

3 months agovarious bug fixes in proto_tacacs
Alan T. DeKok [Sat, 21 Feb 2026 01:25:17 +0000 (20:25 -0500)] 
various bug fixes in proto_tacacs

3 months agovarious bug fixes in proto_detail
Alan T. DeKok [Sat, 21 Feb 2026 00:55:34 +0000 (19:55 -0500)] 
various bug fixes in proto_detail

3 months agovarious bug fixes in proto_bfd
Alan T. DeKok [Sat, 21 Feb 2026 00:42:53 +0000 (19:42 -0500)] 
various bug fixes in proto_bfd

3 months agomake input const
Alan T. DeKok [Fri, 20 Feb 2026 23:25:06 +0000 (18:25 -0500)] 
make input const

3 months agoupdate notes for static analyzer
Alan T. DeKok [Fri, 20 Feb 2026 19:02:37 +0000 (14:02 -0500)] 
update notes for static analyzer

3 months agouse MEM() for allocation failure
Alan T. DeKok [Fri, 20 Feb 2026 18:55:16 +0000 (13:55 -0500)] 
use MEM() for allocation failure

3 months agovarious bug fixes for cron
Alan T. DeKok [Fri, 20 Feb 2026 18:54:35 +0000 (13:54 -0500)] 
various bug fixes for cron

3 months agovarious bug fixes for DNS listener
Alan T. DeKok [Fri, 20 Feb 2026 18:41:39 +0000 (13:41 -0500)] 
various bug fixes for DNS listener

3 months agoDNS opcodes 7..15 are unassigned
Alan T. DeKok [Fri, 20 Feb 2026 18:39:11 +0000 (13:39 -0500)] 
DNS opcodes 7..15 are unassigned

3 months agovarious bug fixes in proto_radius
Alan T. DeKok [Fri, 20 Feb 2026 14:33:49 +0000 (09:33 -0500)] 
various bug fixes in proto_radius

3 months agoports are short, so use ntohs
Alan T. DeKok [Fri, 20 Feb 2026 14:26:29 +0000 (09:26 -0500)] 
ports are short, so use ntohs

3 months agovarious minor tweaks to radiusd.c
Alan T. DeKok [Fri, 20 Feb 2026 12:22:04 +0000 (07:22 -0500)] 
various minor tweaks to radiusd.c

3 months agovarious bug fixes in rlm_digest
Alan T. DeKok [Thu, 19 Feb 2026 20:23:28 +0000 (15:23 -0500)] 
various bug fixes in rlm_digest

check lengths of the various attributes, in case the local admin
wants to manually create attributes which can't go into a
RADIUS packet.

3 months agoFix memory leak and deadlock on error path in cache module
Arran Cudbard-Bell [Sat, 21 Feb 2026 07:04:26 +0000 (00:04 -0700)] 
Fix memory leak and deadlock on error path in cache module

3 months agoSync hashing functions
Arran Cudbard-Bell [Sat, 21 Feb 2026 07:03:43 +0000 (00:03 -0700)] 
Sync hashing functions

3 months agoExtend timeout for radiusd
Arran Cudbard-Bell [Sat, 21 Feb 2026 05:08:49 +0000 (22:08 -0700)] 
Extend timeout for radiusd

3 months agoCorrectly terminate the buffer we use to parse generalized time in DER, and support...
Arran Cudbard-Bell [Sat, 21 Feb 2026 04:52:48 +0000 (21:52 -0700)] 
Correctly terminate the buffer we use to parse generalized time in DER, and support precision up to 9 digits

3 months agoRespect always_string
Arran Cudbard-Bell [Sat, 21 Feb 2026 02:53:53 +0000 (19:53 -0700)] 
Respect always_string

3 months agojson: Refactor base16/base64 conversions
Arran Cudbard-Bell [Sat, 21 Feb 2026 02:32:57 +0000 (19:32 -0700)] 
json: Refactor base16/base64 conversions

3 months agojson: Split conversion functions into pair/box conversion
Arran Cudbard-Bell [Sat, 21 Feb 2026 02:06:46 +0000 (19:06 -0700)] 
json: Split conversion functions into pair/box conversion

3 months agojson: Remove is_enum from json_afrom_value_box. Sanitise code... generally. Mostly...
Arran Cudbard-Bell [Sat, 21 Feb 2026 01:58:26 +0000 (18:58 -0700)] 
json: Remove is_enum from json_afrom_value_box.  Sanitise code... generally.  Mostly merge b16 and b64 cases.

3 months agojson: Fix multiple other memory leaks and minor issues
Arran Cudbard-Bell [Sat, 21 Feb 2026 01:50:49 +0000 (18:50 -0700)] 
json: Fix multiple other memory leaks and minor issues

3 months agojson: Use the correct format specifier for 64bit integers in json.c
Arran Cudbard-Bell [Sat, 21 Feb 2026 01:29:14 +0000 (18:29 -0700)] 
json: Use the correct format specifier for 64bit integers in json.c

3 months agojson: Correctly escape slashes and double quotes in JSON data
Arran Cudbard-Bell [Sat, 21 Feb 2026 01:28:55 +0000 (18:28 -0700)] 
json: Correctly escape slashes and double quotes in JSON data

3 months agojson: Emit an error on structural types
Arran Cudbard-Bell [Sat, 21 Feb 2026 01:27:17 +0000 (18:27 -0700)] 
json: Emit an error on structural types

3 months agojson: Use correct field access
Arran Cudbard-Bell [Sat, 21 Feb 2026 01:27:05 +0000 (18:27 -0700)] 
json: Use correct field access

3 months agoci: remove unmaintained action
Matthew Newton [Fri, 20 Feb 2026 19:50:19 +0000 (19:50 +0000)] 
ci: remove unmaintained action

addnab/docker-run-action is broken and hasn't been updated in five years

3 months agoFeat: Allow octets boxes to be encoded as base16 (hex) in JSON blobs (#5750)
Ethan Thompson [Fri, 20 Feb 2026 22:35:46 +0000 (17:35 -0500)] 
Feat: Allow octets boxes to be encoded as base16 (hex) in JSON blobs (#5750)

3 months agoAllow octets boxes to be encoded as base64 in JSON blobs
Arran Cudbard-Bell [Fri, 20 Feb 2026 05:31:56 +0000 (22:31 -0700)] 
Allow octets boxes to be encoded as base64 in JSON blobs

3 months agoSimilar fixups in radclient-ng
Arran Cudbard-Bell [Sat, 14 Feb 2026 01:37:32 +0000 (17:37 -0800)] 
Similar fixups in radclient-ng

3 months agoMinor cleanups in radclient
Arran Cudbard-Bell [Sat, 14 Feb 2026 00:40:39 +0000 (16:40 -0800)] 
Minor cleanups in radclient

3 months agoAnnotate return overflow (CID #1680684)
Nick Porter [Fri, 20 Feb 2026 09:59:56 +0000 (09:59 +0000)] 
Annotate return overflow (CID #1680684)

Coverity doesn't have the context of how negative slen is built to
understand that these will not overflow.

3 months agoPacify Coverity (CID #1520867, #1520875)
Nick Porter [Fri, 20 Feb 2026 09:27:54 +0000 (09:27 +0000)] 
Pacify Coverity (CID #1520867, #1520875)

It doesn't identify that paths which set request->reply->code only set
to valid packet codes.

3 months agoRe-sequence code to check before dereference (CID #1681438)
Nick Porter [Fri, 20 Feb 2026 08:54:58 +0000 (08:54 +0000)] 
Re-sequence code to check before dereference (CID #1681438)

3 months agoCurrent FreeBSD 14 is 14.3
Nick Porter [Thu, 19 Feb 2026 19:29:26 +0000 (19:29 +0000)] 
Current FreeBSD 14 is 14.3

3 months agoUpdate cross platform action version
Nick Porter [Fri, 20 Feb 2026 08:11:41 +0000 (08:11 +0000)] 
Update cross platform action version

3 months agoPass pipe fd array to pipe() not a pointer to the array
Nick Porter [Fri, 20 Feb 2026 08:32:50 +0000 (08:32 +0000)] 
Pass pipe fd array to pipe() not a pointer to the array

3 months agoTidy control_test
Nick Porter [Thu, 19 Feb 2026 19:25:07 +0000 (19:25 +0000)] 
Tidy control_test

3 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/der.tar
github-actions[bot] [Fri, 20 Feb 2026 05:00:16 +0000 (05:00 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/der.tar

3 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/cbor.tar
github-actions[bot] [Fri, 20 Feb 2026 04:59:40 +0000 (04:59 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/cbor.tar

3 months agovarious bug fixes in master.c
Alan T. DeKok [Thu, 19 Feb 2026 20:04:31 +0000 (15:04 -0500)] 
various bug fixes in master.c

3 months agodon't use smart quotes, etc.
Alan T. DeKok [Thu, 19 Feb 2026 19:51:10 +0000 (14:51 -0500)] 
don't use smart quotes, etc.

3 months agoupdate EAP-MD5 tutorial
98manu [Thu, 19 Feb 2026 14:29:13 +0000 (19:59 +0530)] 
update EAP-MD5 tutorial

doc:add new files to the eap-md5 tutorial

doc:add overview section to the eap-md5 tutorial

doc:add diagram to the eap-md5 tutorial

doc:add configuration steps to the eap-md5 tutorial

doc:add expected output section to the eap-md5 tutorial

doc:add eapol-test to the eap-md5 tutorial

3 months agouse fr_cloexec()
Alan T. DeKok [Thu, 19 Feb 2026 19:31:58 +0000 (14:31 -0500)] 
use fr_cloexec()

3 months agovarious bug fixes in network.c
Alan T. DeKok [Thu, 19 Feb 2026 16:52:04 +0000 (11:52 -0500)] 
various bug fixes in network.c

3 months agobetter handle pipe full
Alan T. DeKok [Thu, 19 Feb 2026 19:31:10 +0000 (14:31 -0500)] 
better handle pipe full

3 months agoonly free message once we're done with it
Alan T. DeKok [Thu, 19 Feb 2026 13:22:41 +0000 (08:22 -0500)] 
only free message once we're done with it

we should really delay the decode until after the various other
checks have been done.

3 months agoremove unused variables
Alan T. DeKok [Thu, 19 Feb 2026 13:19:49 +0000 (08:19 -0500)] 
remove unused variables

3 months agocheck return code of set timeout
Alan T. DeKok [Thu, 19 Feb 2026 13:18:28 +0000 (08:18 -0500)] 
check return code of set timeout

3 months agofix various bugs in worker.c
Alan T. DeKok [Thu, 19 Feb 2026 04:21:52 +0000 (23:21 -0500)] 
fix various bugs in worker.c

use MEM() rather than assert

release request on failure

unlink request from listen entry when channel is closed

only call time once.

stop / clean up all requests.

don't divide by zero in corner cases

use correct channel message

3 months agouse size_t rather than uint32_t to over overflow
Alan T. DeKok [Thu, 19 Feb 2026 04:05:01 +0000 (23:05 -0500)] 
use size_t rather than uint32_t to over overflow

3 months agotweak control message send
Alan T. DeKok [Thu, 19 Feb 2026 04:02:30 +0000 (23:02 -0500)] 
tweak control message send

arguably we should use a method which is better at high performance

3 months agouse util functions for nonblock
Alan T. DeKok [Thu, 19 Feb 2026 03:47:11 +0000 (22:47 -0500)] 
use util functions for nonblock

3 months agoset FD_CLOEXEC properly
Alan T. DeKok [Thu, 19 Feb 2026 03:44:09 +0000 (22:44 -0500)] 
set FD_CLOEXEC properly

for F_GETFD / F_SETFD, and not F_GETFL / F_SETFL

3 months agotypo
Alan T. DeKok [Thu, 19 Feb 2026 03:40:33 +0000 (22:40 -0500)] 
typo

3 months agowe can use talloc_set_name_const
Alan T. DeKok [Thu, 19 Feb 2026 03:39:59 +0000 (22:39 -0500)] 
we can use talloc_set_name_const

3 months agodestroy semaphore on failure
Alan T. DeKok [Thu, 19 Feb 2026 03:39:17 +0000 (22:39 -0500)] 
destroy semaphore on failure

3 months agoexport thread pool configuration to scheduler
Alan T. DeKok [Thu, 19 Feb 2026 03:34:40 +0000 (22:34 -0500)] 
export thread pool configuration to scheduler

so that it can find worker-specific configuration

3 months agovarious bug fixes in network.c
Alan T. DeKok [Thu, 19 Feb 2026 03:27:36 +0000 (22:27 -0500)] 
various bug fixes in network.c

fix assertion

fix arguments to memmove(), and NULL out now-unused entry.

return negative for error

3 months agovarious bug fixes in dedup.c
Alan T. DeKok [Wed, 18 Feb 2026 20:35:22 +0000 (15:35 -0500)] 
various bug fixes in dedup.c

3 months agovarious bug fixes in packet.c
Alan T. DeKok [Wed, 18 Feb 2026 20:23:59 +0000 (15:23 -0500)] 
various bug fixes in packet.c

3 months agovarious bug fixes in retry.c
Alan T. DeKok [Wed, 18 Feb 2026 20:20:55 +0000 (15:20 -0500)] 
various bug fixes in retry.c

3 months agovarious bug fixes in haproxy.c
Alan T. DeKok [Wed, 18 Feb 2026 20:13:31 +0000 (15:13 -0500)] 
various bug fixes in haproxy.c

3 months agovarious bug fixes in queue.c
Alan T. DeKok [Wed, 18 Feb 2026 19:44:42 +0000 (14:44 -0500)] 
various bug fixes in queue.c

3 months agovarious bug fixes in fd.c
Alan T. DeKok [Wed, 18 Feb 2026 19:41:50 +0000 (14:41 -0500)] 
various bug fixes in fd.c

3 months agokeep blocked flag if we can't flush when already blocked
Alan T. DeKok [Wed, 18 Feb 2026 18:56:44 +0000 (13:56 -0500)] 
keep blocked flag if we can't flush when already blocked

3 months agostop on error, too
Alan T. DeKok [Wed, 18 Feb 2026 18:55:08 +0000 (13:55 -0500)] 
stop on error, too

3 months agovarious buf fixes in mem.c
Alan T. DeKok [Wed, 18 Feb 2026 18:53:22 +0000 (13:53 -0500)] 
various buf fixes in mem.c

3 months agoclean up on failure, and ensure that "next" is always an FD bio
Alan T. DeKok [Wed, 18 Feb 2026 18:33:49 +0000 (13:33 -0500)] 
clean up on failure, and ensure that "next" is always an FD bio

3 months agoreset buffer just in case
Alan T. DeKok [Wed, 18 Feb 2026 18:28:54 +0000 (13:28 -0500)] 
reset buffer just in case

3 months agovarius bug fixes in fd_open.c
Alan T. DeKok [Wed, 18 Feb 2026 18:27:19 +0000 (13:27 -0500)] 
varius bug fixes in fd_open.c

3 months agoreturn dirfd and filename if we have to create it
Alan T. DeKok [Wed, 18 Feb 2026 17:56:16 +0000 (12:56 -0500)] 
return dirfd and filename if we have to create it

3 months agocheck for errors when reading the password from a file
Alan T. DeKok [Wed, 18 Feb 2026 15:58:40 +0000 (10:58 -0500)] 
check for errors when reading the password from a file

3 months agovarious bug fixes in cache.c
Alan T. DeKok [Wed, 18 Feb 2026 15:47:16 +0000 (10:47 -0500)] 
various bug fixes in cache.c

free resources on failure.  Don't set "request=child", as that
just confuses things.