]> git.ipfire.org Git - thirdparty/curl.git/log
thirdparty/curl.git
2 weeks agolib: drop support for CURLAUTH_DIGEST_IE 21486/head
Daniel Stenberg [Sat, 2 May 2026 20:50:10 +0000 (22:50 +0200)] 
lib: drop support for CURLAUTH_DIGEST_IE

This bit was used to do Digest authentication like Internet Explorer
before version 7 (released on October 18, 2006). Presumably no one uses
this anymore and since it is hard to use and does broken auth, starting
in 8.21.0 this bit does nothing (except setting the actual Digest bit).

Closes #21486

2 weeks agocmake: fix zstd CMake config name
Kai Pastor [Fri, 8 May 2026 15:21:52 +0000 (17:21 +0200)] 
cmake: fix zstd CMake config name

They install `zstdConfig.cmake`,
https://github.com/facebook/zstd/blob/885c79ba4ae8345e006f61bc97b270d4cf7ff076/build/cmake/CMakeModules/ZstdPackage.cmake#L33-L38.
With the `Config.cmake` pattern, this is a case-sensitive package name,
`zstd`.

Follow-up to 8fce3e17e6cb310cd6dbe38ff14869b8fe5827d2 #20814
Closes #21538

2 weeks agotidy-up: sort TLS backends, distros, alphabetically
Viktor Szakats [Fri, 1 May 2026 11:25:49 +0000 (13:25 +0200)] 
tidy-up: sort TLS backends, distros, alphabetically

Also:
- replace stray [Rr]ustls-ffi with Rustls for consistency.
- add AWS-LC to a couple of lists where missing.

Closes #21481

2 weeks agocmake: auto-select static nghttp2/nghttp3/ngtcp2 Config
Viktor Szakats [Wed, 29 Apr 2026 17:09:28 +0000 (19:09 +0200)] 
cmake: auto-select static nghttp2/nghttp3/ngtcp2 Config

When detecting these dependencies via CMake Config and their main
imported target is undefined, automatically assume and use their static
imported target instead.

Adopting from vcpkg downstream, where it's done for nghttp3 and ngtcp2,
but not for nghttp2.

Refs:
https://github.com/microsoft/vcpkg/blob/773e092a82fc3b4c3e73ee7b049a5e119fa45898/ports/curl/dependencies.patch
https://github.com/microsoft/vcpkg/commit/70b941a5d2443e79eeab62507acb41bd22201277

Downstream-patch-by: Kai Pastor
Closes #21470

2 weeks agoftp: avoid accessing EPSV response one byte past the NULL
Daniel Stenberg [Sun, 10 May 2026 22:18:53 +0000 (00:18 +0200)] 
ftp: avoid accessing EPSV response one byte past the NULL

If the response is just a single "(".

Reported-by: Andrew Nesbit
Closes #21545

2 weeks agoGHA: update awslabs/aws-lc to v1.73.0
renovate[bot] [Sun, 10 May 2026 00:33:47 +0000 (00:33 +0000)] 
GHA: update awslabs/aws-lc to v1.73.0

Closes #21542

2 weeks agoschannel_verify: avoid out of blob access
Daniel Stenberg [Sun, 10 May 2026 13:13:59 +0000 (15:13 +0200)] 
schannel_verify: avoid out of blob access

The code would previously read one byte past the provided
CURLOPT_CAINFO_BLOB if the blob ends exactly with -----BEGIN
CERTIFICATE-----

Reported-by: Andrew Nesbit
Closes #21543

2 weeks agocookie: simplify strstore(), remove outdated comment
Daniel Stenberg [Sat, 9 May 2026 13:27:11 +0000 (15:27 +0200)] 
cookie: simplify strstore(), remove outdated comment

Closes #21541

2 weeks agoDockerfile: update debian:bookworm-slim Docker digest to 67b30a6
renovate[bot] [Sat, 9 May 2026 04:45:54 +0000 (04:45 +0000)] 
Dockerfile: update debian:bookworm-slim Docker digest to 67b30a6

Closes #21539

3 weeks agoGHA: update google/boringssl to v0.20260508.0
renovate[bot] [Fri, 8 May 2026 14:24:33 +0000 (14:24 +0000)] 
GHA: update google/boringssl to v0.20260508.0

Closes #21537

3 weeks agoCURLOPT_ECH.md: simplify the description language
Daniel Stenberg [Fri, 8 May 2026 11:13:20 +0000 (13:13 +0200)] 
CURLOPT_ECH.md: simplify the description language

It no longer requires "a special build" of OpenSSL, just OpenSSL 4+.

Emphasize the experimental part a little clearer.

Drop the caveat for wolfSSL from the main description.

Closes #21536

3 weeks agoECH: cleanups
Daniel Stenberg [Thu, 7 May 2026 21:07:54 +0000 (23:07 +0200)] 
ECH: cleanups

- passing an unknown string to CURLOPT_ECH now returns error

  To properly allow applications to spot if they pass in a typo or
  something to libcurl.

- CURLECH_DISABLE is now a plain zero internally, not a dedicated bit which
  simplifies checks for when ECH is enabled

- Dropped the CURLECH_CLA_CFG bit, and just check STRING_ECH_CONFIG

- Turn grease/enable/hard into three different numerical values, no bitmask
  needed

- Convert the struct field 'tls_ech' from an int to a byte.

Closes #21532

3 weeks agox509asn1: fix operator order in do_pubkey
Daniel Stenberg [Thu, 7 May 2026 21:35:40 +0000 (23:35 +0200)] 
x509asn1: fix operator order in do_pubkey

Check the range before reading data, as it would otherwise read one byte
too many.

Reported-by: Andrew Nesbit
Closes #21533

3 weeks agotool_urlglob: avoid overflow at end of range
Daniel Stenberg [Thu, 7 May 2026 15:45:48 +0000 (17:45 +0200)] 
tool_urlglob: avoid overflow at end of range

Due to how the range span globbing code works, a range that ends with
9223372036854775807 (the maximum signed 63 bit value) cannot be used as
it triggers an integer overflow.

Verified in test 2092

Reported-by: Andrew Nesbit
Closes #21529

3 weeks agoldap: fix minor leak on write callback error
Daniel Stenberg [Thu, 7 May 2026 16:02:35 +0000 (18:02 +0200)] 
ldap: fix minor leak on write callback error

The 'ber' pointer could remain allocated in the exit path if the write
callback returned error for one of the Curl_client_write() calls.

Reported-by: Andrew Nesbit
Closes #21530

3 weeks agoftp: simplify ftp_done
Daniel Stenberg [Thu, 7 May 2026 07:44:28 +0000 (09:44 +0200)] 
ftp: simplify ftp_done

Closes #21520

3 weeks agourl: fix connection reuse for starttls protocols
Stefan Eissing [Thu, 7 May 2026 08:30:07 +0000 (10:30 +0200)] 
url: fix connection reuse for starttls protocols

When a connection is tested for reuse in a transfer that *may* upgrade
to TLS (commonly via STARTTLS), the SSL configuration must match the
existing connection.

Reported-by: Andrew Nesbit
Closes #21522

3 weeks agoftp: remove bits.ftp_use_control_ssl
Stefan Eissing [Thu, 7 May 2026 08:00:10 +0000 (10:00 +0200)] 
ftp: remove bits.ftp_use_control_ssl

It's not needed since we can check the connection for SSL use.

Closes #21521

3 weeks agoauth: cleanups
Stefan Eissing [Wed, 6 May 2026 11:44:16 +0000 (13:44 +0200)] 
auth: cleanups

- rename `req->proxyuserpwd` to `req->hd_proxy_auth`
- rename `req->userpwd` to `req->hd_auth`
- rename parameter `proxytunnel` to `is_connect` for Curl_http_output_auth()
- move path+query concatenation into Curl_http_output_auth(), saving an alloc when no auth is in play
- rename `H1_HD_USER_AUTH` into `H1_HD_AUTH`

Closes #21513

3 weeks agoftp: remove 2 Curl_resolv_blocking() calls
Stefan Eissing [Wed, 6 May 2026 07:49:14 +0000 (09:49 +0200)] 
ftp: remove 2 Curl_resolv_blocking() calls

They are no longer needed with the new peers and dns filter.
Connection setup will take care of the resoling and connecting.

Closes #21512

3 weeks agourl: remove ssh_config_matches
Daniel Stenberg [Thu, 7 May 2026 07:04:55 +0000 (09:04 +0200)] 
url: remove ssh_config_matches

The CURLOPT_SSH_HOST_PUBLIC_KEY_* options are documented to verify the
host at connect time and not for connection reuse. Once the SSH host has
been deemed okay, it remains okay as long as the connection survives.

In addition: this function currently always returned TRUE since the
pointers have been NULLed in the SSH backend code before this function
is called.

Follow-up to c31fcf2decfbf1259cc1f31

Reported-by: Andrew Nesbit
Closes #21519

3 weeks agoCURLOPT_HAPROXYPROTOCOL.md: only sent for newly setup connections
Daniel Stenberg [Thu, 7 May 2026 06:19:36 +0000 (08:19 +0200)] 
CURLOPT_HAPROXYPROTOCOL.md: only sent for newly setup connections

Closes #21517

3 weeks agotool_formparse: tool2curlparts is no longer recursive
Daniel Stenberg [Thu, 7 May 2026 06:33:46 +0000 (08:33 +0200)] 
tool_formparse: tool2curlparts is no longer recursive

It could otherwise trigger a stack overflow in extreme cases

Reported-by: Andrew Nesbit
Closes #21518

3 weeks agotool1622: assert width and exact format boundaries
parasol-aser [Thu, 7 May 2026 03:53:34 +0000 (03:53 +0000)] 
tool1622: assert width and exact format boundaries

Convert the silent "was too long!" diagnostics in the timebuf and
max5data width loops into fail_unless assertions, so a regression in
output width fails the unit test directly instead of only printing.

Add small exact-output tables that probe format-transition boundaries
not necessarily hit by the geometric value sweep: the 99999/100000
suffix kick-in for max5data, and the 6d/01h, 51m, 136y, and >99999y roll
points for timebuf.

Closes #21516

3 weeks agosetopt: gate a few proxy TLS options by checking backend support
Daniel Stenberg [Wed, 6 May 2026 21:40:25 +0000 (23:40 +0200)] 
setopt: gate a few proxy TLS options by checking backend support

The same way the corresponding non-proxy options are checked.

Closes #21514

3 weeks agombedtls: null terminate the private key blob
Daniel Stenberg [Wed, 6 May 2026 21:59:22 +0000 (23:59 +0200)] 
mbedtls: null terminate the private key blob

Unfortunately, mbedtls_pk_parse_key() requires the data to be
null-terminated if the data is PEM encoded (even when provided the exact
length), so this function needs to make a copy that has one.

Reported-by: Elise Vance
Closes #21515

3 weeks agotests: fix unit1636 with --disable-progress-meter
Dan Fandrich [Tue, 5 May 2026 03:56:51 +0000 (20:56 -0700)] 
tests: fix unit1636 with --disable-progress-meter

Closes #21500

3 weeks agopeer: fix compare of hostname for uds
Stefan Eissing [Wed, 6 May 2026 07:24:50 +0000 (09:24 +0200)] 
peer: fix compare of hostname for uds

Unix domain socket paths need to be compared case-senstive, in contrast
to DNS hostnames.

Follow-up to bc40e09f63889a8bc14fa8f7221921

Pointed out by Codex Security

Closes #21511

3 weeks agoRELEASE-NOTES: synced
Daniel Stenberg [Wed, 6 May 2026 07:19:12 +0000 (09:19 +0200)] 
RELEASE-NOTES: synced

Also bump pending version to 8.21.0

3 weeks agotool_formparse: polish error message + make two functions static
Daniel Stenberg [Wed, 6 May 2026 06:50:44 +0000 (08:50 +0200)] 
tool_formparse: polish error message + make two functions static

Closes #21510

3 weeks agoprotocol: introduce typedef for the do_more() function 21509/head
Daniel Stenberg [Tue, 5 May 2026 16:39:12 +0000 (18:39 +0200)] 
protocol: introduce typedef for the do_more() function

Instead of using magic values -1, 0 and -1 using enum.

Closes #21509

3 weeks agomulti: make multi_runsingle use sub functions for states
Daniel Stenberg [Tue, 5 May 2026 13:02:32 +0000 (15:02 +0200)] 
multi: make multi_runsingle use sub functions for states

The state machine now calls dedicated sub functions for each state, to
reduce the size and complexity.

Closes #21506

3 weeks agohostip: convert Curl_resolv_unix to static resolv_unix
Daniel Stenberg [Tue, 5 May 2026 15:09:36 +0000 (17:09 +0200)] 
hostip: convert Curl_resolv_unix to static resolv_unix

It was only used within this file

Closes #21508

3 weeks agohsts: rename Curl_hsts() to hsts_check() and make it static
Daniel Stenberg [Tue, 5 May 2026 15:01:41 +0000 (17:01 +0200)] 
hsts: rename Curl_hsts() to hsts_check() and make it static

It is no longer used outside of hsts.c

Closes #21507

3 weeks agoGHA: verify function-lengths
Daniel Stenberg [Mon, 4 May 2026 12:25:47 +0000 (14:25 +0200)] 
GHA: verify function-lengths

No production code function is allowed to be longer than 500 lines.

The lib/setopt.c:setopt_cptr function is currently exempt, as a single
exception until we make it smaller.

Closes #21492

3 weeks agosocks_gssapi: simplify Curl_SOCKS5_gssapi_negotiate
Daniel Stenberg [Tue, 5 May 2026 09:13:07 +0000 (11:13 +0200)] 
socks_gssapi: simplify Curl_SOCKS5_gssapi_negotiate

Also: pass in NULL when 'conf_state' is not wanted for gss_wrap() and
gss_unwrap()

Closes #21502

3 weeks agolib: introduce Curl_peer
Stefan Eissing [Tue, 5 May 2026 10:58:22 +0000 (12:58 +0200)] 
lib: introduce Curl_peer

`struct Curl_peer` keeps information about a communication endpoint
together. It will replace `conn->host` and `conn->conn_to_host` and
proxyinfo host. It will also become part of `struct ssl_peer`.

It has a reference counter, so an instance can be shared between
connections and filters.

Elminiates `conn->host` and `conn->connect_to_host`, used in the
proxyinfo structures. Passed to DNS resolution and socks filters, etc.

Pass peer to http proxy and socks tunnel filters. Use peer in dns filter
and resolving. Make `Curl_peer` a member in the `struct ssl_peer`.

Add `docs/internals/PEERS.md` for documentation.

Closes #21472

3 weeks agothrdqueue.h: minor language polish in comments
Daniel Stenberg [Tue, 5 May 2026 12:34:27 +0000 (14:34 +0200)] 
thrdqueue.h: minor language polish in comments

3 weeks agothrdqueue.h: forward declare curl_thrdq unconditionally
Daniel Stenberg [Tue, 5 May 2026 09:37:03 +0000 (11:37 +0200)] 
thrdqueue.h: forward declare curl_thrdq unconditionally

This allows the unit tests to have a prototype involving such a struct
pointer - even when the build is done without threaded resolver.

Follow-up to 117d50b4bf48ca04908f87dd665ba

Closes #21503

3 weeks agotool_formparse.c: use define instead of magic number
Daniel Stenberg [Tue, 5 May 2026 07:20:47 +0000 (09:20 +0200)] 
tool_formparse.c: use define instead of magic number

The longest header lines accepted for the -F option is now a define
instead of a magic number. I also bumped it to be an even 8K.

When fixing, I noticed that for some OOM errors curl would display two
error messages. Also fixed here.

Closes #21501

3 weeks agothrdqueue: make thrdq_await_done only for unit tests
Daniel Stenberg [Mon, 4 May 2026 21:44:25 +0000 (23:44 +0200)] 
thrdqueue: make thrdq_await_done only for unit tests

It is not used for anything else, so drop Curl_ and make it conditional
accordingly.

Closes #21499

3 weeks agogtls: fix some typos
Daniel Stenberg [Mon, 4 May 2026 21:33:49 +0000 (23:33 +0200)] 
gtls: fix some typos

Also make gtls_get_ietf_proto() static

Found by Copilot

Closes #21498

3 weeks agolib: two minor typos
Daniel Stenberg [Mon, 4 May 2026 14:17:11 +0000 (16:17 +0200)] 
lib: two minor typos

Spotted by Copilot

Closes #21496

3 weeks agoshow-headers.md: mention bold headers and --no-styled-output
Daniel Stenberg [Mon, 4 May 2026 15:19:04 +0000 (17:19 +0200)] 
show-headers.md: mention bold headers and --no-styled-output

Mentioned-by: Sollace on github
Fixes #21495
Closes #21497

3 weeks agosocks_gssapi: tiny Curl_SOCKS5_gssapi_negotiate cleanups
Daniel Stenberg [Mon, 4 May 2026 10:47:12 +0000 (12:47 +0200)] 
socks_gssapi: tiny Curl_SOCKS5_gssapi_negotiate cleanups

- use 'result' instead of 'code' for CURLcode variable
- use aprintf() instead of malloc + snprintf

Closes #21493

3 weeks agolibcurl-easy.md: minor clarifications
Daniel Stenberg [Mon, 4 May 2026 09:13:19 +0000 (11:13 +0200)] 
libcurl-easy.md: minor clarifications

Closes #21491

3 weeks agomime: simplify Curl_mime_prepare_headers
Daniel Stenberg [Mon, 4 May 2026 08:50:50 +0000 (10:50 +0200)] 
mime: simplify Curl_mime_prepare_headers

Make add_content_disposition() a sub function for that single purpose.

Closes #21490

3 weeks agotool_formparse: cleanups
Daniel Stenberg [Mon, 4 May 2026 08:28:10 +0000 (10:28 +0200)] 
tool_formparse: cleanups

- explain the get_param_part() function
- make it parse only blanks like the rest of this code
- check for commas explicitly when scanning multiple files (to help code
  understanding)

Closes #21489

3 weeks agogtls: simplify Curl_gtls_verifyserver
Daniel Stenberg [Mon, 4 May 2026 07:55:26 +0000 (09:55 +0200)] 
gtls: simplify Curl_gtls_verifyserver

Move peer certificate verification logic into gtls_verify_cert()

Closes #21488

3 weeks agosetopt: changing the proxy port is also a proxy change
Daniel Stenberg [Sat, 2 May 2026 15:18:00 +0000 (17:18 +0200)] 
setopt: changing the proxy port is also a proxy change

Test 1589 verifies.

Closes #21485

4 weeks agoGHA: bump actions and pips
dependabot[bot] [Fri, 1 May 2026 17:50:42 +0000 (17:50 +0000)] 
GHA: bump actions and pips

- update action `actions/cache` from 5.0.4 to 5.0.5
- update action `actions/upload-artifact` from 7.0.0 to 7.0.1
- update action `github/codeql-action` from 4.32.4 to 4.35.2
- update action `msys2/setup-msys2` from 2.31.0 to 2.31.1

- update pip `filelock` from 3.25.2 to 3.29.0
- update pip `impacket` to 0.13.0
- update pip `ruff` from 0.15.10 to 0.15.12

Closes #21483
Closes #21482

4 weeks agotool_formparse.c: fix two minor comment typos
Daniel Stenberg [Fri, 1 May 2026 09:28:30 +0000 (11:28 +0200)] 
tool_formparse.c: fix two minor comment typos

Pointed out by Copilot

Closes #21480

4 weeks agourl: simplify parseurlandfillconn
Daniel Stenberg [Fri, 1 May 2026 09:13:27 +0000 (11:13 +0200)] 
url: simplify parseurlandfillconn

Introduce two helper functions:

- hsts_upgrade()
- setup_hostname()

Closes #21479

4 weeks agoRELEASE-NOTES: synced
Daniel Stenberg [Fri, 1 May 2026 09:34:15 +0000 (11:34 +0200)] 
RELEASE-NOTES: synced

Also bump the curlver to tenative 8.20.1

4 weeks agoasyn-thrdd: fix result processing without wakeup socketpair
Stefan Eissing [Thu, 30 Apr 2026 14:53:02 +0000 (16:53 +0200)] 
asyn-thrdd: fix result processing without wakeup socketpair

When building curl 8.20.0 with socketpair disabled, there is no
wakeup socket and the resolve results are not processed.

This fix performs result processing in the absence of a wakeup
socket before checking the resolve result.

Closes #21476

4 weeks agouser-agent.md: mention double quotes too
Daniel Stenberg [Thu, 30 Apr 2026 20:50:27 +0000 (22:50 +0200)] 
user-agent.md: mention double quotes too

Reported-by: Jeremy Nicoll
Bug: https://curl.se/mail/archive-2026-04/0029.html
Closes #21477

4 weeks agotool_formparse: simplify get_param_part
Daniel Stenberg [Thu, 30 Apr 2026 12:51:47 +0000 (14:51 +0200)] 
tool_formparse: simplify get_param_part

Introduce a few sub functions to reduce complexity

Closes #21478

4 weeks agotidy-up: miscellaneous
Viktor Szakats [Wed, 29 Apr 2026 13:27:37 +0000 (15:27 +0200)] 
tidy-up: miscellaneous

- sha256: fix backend priority in comment.
- URLs: link to IETF URLs to the HTML document, to match others.
- VERSIONS.md: use unified date format for recent entries too.
  Ref: https://github.com/curl/curl-www/commit/ce5d32032f8d3d8601f3ef022bbca485020d1bb9
- GHA/labeler.yml: alpha-sort file masks in a label block.
- tests/server/mqttd: fix call arg list in a disabled function.
- tests/server/mqttd: fix comment.

Closes #21473

4 weeks agoGHA/curl-for-win: switch riscv job to debian:stable (testing broke)
Viktor Szakats [Thu, 30 Apr 2026 14:06:35 +0000 (16:06 +0200)] 
GHA/curl-for-win: switch riscv job to debian:stable (testing broke)

```
The following packages have unmet dependencies:
[...]
E: Unable to satisfy dependencies. Reached two conflicting assignments:
   1. musl-dev:amd64=1.2.5-3+b1 is selected for install
   2. musl-dev:amd64 is not selected for install because:
      1. musl-dev:riscv64=1.2.5-3 is selected for install
      2. musl-dev:amd64 Breaks musl-dev:riscv64 (!= 1.2.5-3+b1)
```
Ref: https://github.com/curl/curl/actions/runs/25168601672/job/73785600341#step:3:154

Closes #21475

4 weeks agomqtt: validate PINGRESP and DISCONNECT have remaining_length == 0
Raymond Steen [Wed, 29 Apr 2026 07:27:39 +0000 (10:27 +0300)] 
mqtt: validate PINGRESP and DISCONNECT have remaining_length == 0

Per MQTT 3.1.1 sections 3.13.1 and 3.14.1, PINGRESP and DISCONNECT fixed
headers must have remaining_length set to zero. The previous code
dispatched to mqtt->nextstate based on the queued state alone without
validating remaining_length for these no-payload packet types, allowing
a malicious broker to send a PINGRESP with non-zero remaining_length
whose trailing bytes would be interpreted as the payload of whatever
message type was queued (CONNACK, SUBACK, etc.).

The exploitation path turned out to be narrow — curl sends data to the
server the user chose to talk to — but the spec violation and the
resulting protocol-state error are real. Reject the malformed packets
with CURLE_WEIRD_SERVER_REPLY before state dispatch.

Reported-by: Raymond Steen <raymond@vortiqxconsilium.com>
Found by VORTIQ-X VXF Framework
Bug: https://hackerone.com/reports/3702718

Signed-off-by: Raymond Steen <raymond@vortiqxconsilium.com>
Closes #21465

4 weeks agoGHA/linux: work around Linuxbrew install failure
Viktor Szakats [Wed, 29 Apr 2026 19:51:43 +0000 (21:51 +0200)] 
GHA/linux: work around Linuxbrew install failure

Root cause unknown, it appeared today without any local change:
```
==> Installing dependencies for libssh2: openssl@3 and zlib-ng-compat
==> Installing libssh2 dependency: openssl@3
==> Pouring openssl@3--3.6.2.x86_64_linux.bottle.tar.gz
Error: A `brew install openssl@4 libssh2 libngtcp2 libnghttp3 c-ares` process has already locked /home/linuxbrew/.linuxbrew/Cellar/openssl@4.
Please wait for it to finish or terminate it to continue.
Error: Process completed with exit code 1.
```
Ref: https://github.com/curl/curl/actions/runs/25129061781/job/73650161844?pr=21468#step:2:407

Last known good run: https://github.com/curl/curl/actions/runs/25038989485/job/73337289504

Ref: 1fbffe7f08f0d551038520b569b817f58084f77b #21379

Closes #21469

4 weeks agoRELEASE-NOTES: synced curl-8_20_0
Daniel Stenberg [Wed, 29 Apr 2026 05:45:21 +0000 (07:45 +0200)] 
RELEASE-NOTES: synced

curl 8.20.0 release

plus VERSIONS.md update

4 weeks agoTHANKS: names from the 8.20.0 release
Daniel Stenberg [Wed, 29 Apr 2026 05:45:21 +0000 (07:45 +0200)] 
THANKS: names from the 8.20.0 release

4 weeks agotidy-up: a cmake warning message and a variable name
Viktor Szakats [Mon, 27 Apr 2026 20:21:27 +0000 (22:21 +0200)] 
tidy-up: a cmake warning message and a variable name

Spotted by GitHub Code Quality

Closes #21462

4 weeks agobuild: stop building and installing `runtests.1` and `testcurl.1`
Viktor Szakats [Mon, 27 Apr 2026 15:51:16 +0000 (17:51 +0200)] 
build: stop building and installing `runtests.1` and `testcurl.1`

The corresponding tools are never installed, and both are dev tools.
Refer to their `.md` originals instead.

Also markdownify text in lines nearby.

Ref: https://github.com/curl/curl/pull/21460#issuecomment-4328258450

Closes #21461

4 weeks agocmake: do not install shell completions when `BUILD_CURL_EXE=OFF`
Viktor Szakats [Mon, 27 Apr 2026 15:12:42 +0000 (17:12 +0200)] 
cmake: do not install shell completions when `BUILD_CURL_EXE=OFF`

Follow-up to 74542c1f4bfea75f92562075370fd839891cc440 #21459

Closes #21460

4 weeks agocmake: do not install `wcurl` when `BUILD_CURL_EXE=OFF`
Viktor Szakats [Mon, 27 Apr 2026 15:00:41 +0000 (17:00 +0200)] 
cmake: do not install `wcurl` when `BUILD_CURL_EXE=OFF`

Skip installing `wcurl.1` also.

Reported-by: Daniel Schulte
Fixes #21458
Follow-up to 23bed347b38922779382599f8b72c4d762add7bd #17035

Closes #21459

4 weeks agoGHA/checksrc: switch to zizmor `--persona` option
Viktor Szakats [Mon, 27 Apr 2026 12:55:40 +0000 (14:55 +0200)] 
GHA/checksrc: switch to zizmor `--persona` option

Closes #21457

4 weeks agotidy-up: whitespace
Viktor Szakats [Wed, 15 Apr 2026 21:57:35 +0000 (23:57 +0200)] 
tidy-up: whitespace

Closes #21456

4 weeks agowrite-out.md: minor language fix
Daniel Stenberg [Mon, 27 Apr 2026 09:41:34 +0000 (11:41 +0200)] 
write-out.md: minor language fix

Pointed out by Copilot

Closes #21455

4 weeks agotool_dirhie: fix to create drive-relative directory
Viktor Szakats [Sun, 26 Apr 2026 11:38:47 +0000 (13:38 +0200)] 
tool_dirhie: fix to create drive-relative directory

Fix to create the top directory `foo` when specified as
`X:foo\bar\filename`, on Windows and MS-DOS. Add test to verify.

Caught by Codex Security

Follow-up to 787ee935acd5867bdac836b2043b6095eed2c29e #16566

Closes #21449

4 weeks agotunits: initialize global `tool_stderr`
Viktor Szakats [Mon, 27 Apr 2026 08:49:45 +0000 (10:49 +0200)] 
tunits: initialize global `tool_stderr`

To avoid difficult to track down crashes when a tested function ends up
outputing a message via `errorf()`, `warnf()` or siblings.

Cherry-picked from #21449

Closes #21454

4 weeks agoruntests: fix linefeeds in log messages
Viktor Szakats [Sun, 26 Apr 2026 23:25:37 +0000 (01:25 +0200)] 
runtests: fix linefeeds in log messages

Cherry-picked from #21449

Closes #21452

4 weeks agounits: tidy up dynbuf init
Viktor Szakats [Sun, 26 Apr 2026 20:06:59 +0000 (22:06 +0200)] 
units: tidy up dynbuf init

Init dynbuf after global init to bring closer to use, improve
readability and sync test sources.

Closes #21451

4 weeks agosetopt: clear proxy auth properties when switching
Daniel Stenberg [Mon, 27 Apr 2026 07:14:51 +0000 (09:14 +0200)] 
setopt: clear proxy auth properties when switching

Verify with test 1588

Closes #21453

4 weeks agodocs/cmdline-opts/write-out.md: minor language edit
Daniel Stenberg [Sun, 26 Apr 2026 14:42:31 +0000 (16:42 +0200)] 
docs/cmdline-opts/write-out.md: minor language edit

4 weeks agodocs/cmdline-opts/write-out.md: tls_earlydata was adeded in 8.13.0
Daniel Stenberg [Sun, 26 Apr 2026 14:35:33 +0000 (16:35 +0200)] 
docs/cmdline-opts/write-out.md: tls_earlydata was adeded in 8.13.0

4 weeks agowrite-out.md: fix minor language mistake
Daniel Stenberg [Sun, 26 Apr 2026 14:18:12 +0000 (16:18 +0200)] 
write-out.md: fix minor language mistake

Closes #21450

4 weeks agoKNOWN_BUGS.md: Windows stdin relay accepts unauthenticated local connections
Daniel Stenberg [Fri, 24 Apr 2026 06:49:03 +0000 (08:49 +0200)] 
KNOWN_BUGS.md: Windows stdin relay accepts unauthenticated local connections

A windows developer could have a look at this.

Closes #21433

4 weeks agosectrust: fail on missing OCSP stapling
Stefan Eissing [Sat, 25 Apr 2026 08:34:06 +0000 (10:34 +0200)] 
sectrust: fail on missing OCSP stapling

When using Apple SecTrust, requiring the server to send
an OCSP response and does not, fail correctly.

Reported-by: Carlos Carrillo
Closes #21444

4 weeks agotest_22_httpsrr: avoid class name clash with `test_21_resolve`
Viktor Szakats [Sat, 25 Apr 2026 12:08:12 +0000 (14:08 +0200)] 
test_22_httpsrr: avoid class name clash with `test_21_resolve`

Spotted by GitHub Code Quality

Closes #21448

4 weeks agotidy-up: git options, ECH, HTTP/3 documentation
Viktor Szakats [Sat, 25 Apr 2026 10:59:55 +0000 (12:59 +0200)] 
tidy-up: git options, ECH, HTTP/3 documentation

- prefer `--branch` over `-b`, where missing.
- add `--depth 1` where missing.
- sync option order between docs and GHA.
- bump quiche and rustls-ffi versions in documentation.
- ECH.md: update for OpenSSL 4.

Closes #21447

4 weeks agotest_22_httpsrr: drop duplicate skipif conditions
Viktor Szakats [Sat, 25 Apr 2026 10:42:56 +0000 (12:42 +0200)] 
test_22_httpsrr: drop duplicate skipif conditions

Already set at class-level.

Spotted by GitHub Code Quality

Closes #21446

4 weeks agopytest: drop unused imports
Viktor Szakats [Sat, 25 Apr 2026 10:05:32 +0000 (12:05 +0200)] 
pytest: drop unused imports

Spotted by GitHub Code Quality

Closes #21445

4 weeks agoRELEASE-NOTES: synced
Daniel Stenberg [Sat, 25 Apr 2026 09:37:19 +0000 (11:37 +0200)] 
RELEASE-NOTES: synced

4 weeks agoRELEASE-NOTES: add missing contributors
Daniel Stenberg [Sat, 25 Apr 2026 09:28:08 +0000 (11:28 +0200)] 
RELEASE-NOTES: add missing contributors

From security reports etc

5 weeks agosshserver.pl: tidy up around `AllowUsers` setup
Viktor Szakats [Fri, 24 Apr 2026 20:49:10 +0000 (22:49 +0200)] 
sshserver.pl: tidy up around `AllowUsers` setup

- drop redundant space-to-`?` replacement.
- add parentheses to silence code checker.
- tidy up comments.

Follow-up to e53523fef07894991c69d907a7c7794c7ada4ff4 #14859

Closes #21442

5 weeks agoGHA/windows: bump stunnel to 5.78
Viktor Szakats [Fri, 24 Apr 2026 22:18:54 +0000 (00:18 +0200)] 
GHA/windows: bump stunnel to 5.78

Closes #21443

5 weeks agoconnect: fix typo on error message [ci skip]
Viktor Szakats [Fri, 24 Apr 2026 20:25:07 +0000 (22:25 +0200)] 
connect: fix typo on error message [ci skip]

Pointed out by GitHub Code Quality

5 weeks agosetup connection filter: mark as setup
Stefan Eissing [Fri, 24 Apr 2026 09:34:13 +0000 (11:34 +0200)] 
setup connection filter: mark as setup

Add CF_TYPE_SETUP to the setup connection filter so that it is
removed and destroyed after the connection has been established.

Closes #21437

5 weeks agosocks filter: pass operation parameters
Stefan Eissing [Fri, 24 Apr 2026 08:38:22 +0000 (10:38 +0200)] 
socks filter: pass operation parameters

Pass all operations parameters to a SOCKS filter at creation
time, not relying on "global" connectdata values.

Eliminate modifications to `conn->ip_version` when local resolving
for SOCKS4.

Do not retrieve the socket for GSSAPI blocking calls from connectdata,
but from the filters "below" the SOCKS one.

Closes #21436

5 weeks agombedtls: remove failf() call with first argument as NULL
Daniel Stenberg [Fri, 24 Apr 2026 15:23:05 +0000 (17:23 +0200)] 
mbedtls: remove failf() call with first argument as NULL

failf() needs an easy handle to work. This change removes the call since
there is normnally nowhere to show the output if init fails.

Bonus: improve language in an infof() call

Spotted by Copilot

Closes #21441

5 weeks agosshserver.pl: add option to enable KEX algorithms in sshd
Viktor Szakats [Fri, 24 Apr 2026 11:31:53 +0000 (13:31 +0200)] 
sshserver.pl: add option to enable KEX algorithms in sshd

Necessary when the libssh2/libssh client library does not support KEX
algos offered by default by the OpenSSH server. E.g. libssh2 with WinCNG
combined with OpenSSH 10+.

Also: use this option in GHA/windows.

Follow-up to 3b8bb1a86afbaf967163bf6709b1825e11655bf5 #21219
Follow-up to c98d0a2e9aa7ec87d16af8b056e6e7c0d614feec #21220

Closes #21438

5 weeks agombedtls: cleanup more without care for 'initialized'
Daniel Stenberg [Fri, 24 Apr 2026 14:27:34 +0000 (16:27 +0200)] 
mbedtls: cleanup more without care for 'initialized'

Several mbedTLS resources (entropy/CTR-DRBG, CA/client certs, keys, CRL)
are initialized and may allocate memory before initialized is set, and
must still be cleaned up.

Follow-up to 1c4813c769ea65c128c067004

Caught by Codex Security
Closes #21440

5 weeks agoGHA/windows: disable ssh-ed25519 hostkey in libssh2-wincng jobs
Viktor Szakats [Fri, 24 Apr 2026 12:38:50 +0000 (14:38 +0200)] 
GHA/windows: disable ssh-ed25519 hostkey in libssh2-wincng jobs

libssh2 built with the WinCNG crypto backend does not support ed25519
hostkeys.

Ref: #21438
Follow-up to acda4eae5eeb24a7b0ab9ec7b1783d74eb43687c #21223

Closes #21439

5 weeks agoresolve: pass bool for proxy resolves
Stefan Eissing [Thu, 23 Apr 2026 14:26:13 +0000 (16:26 +0200)] 
resolve: pass bool for proxy resolves

So that CURLcode failure is correct and not figured out later via
`conn->bits.proxy`. Add the flag to the async struct.

`for_proxy` is figured out by the caller of Curl_resolv() when it
figures out which host/proxy name it wants the addresses for.

Remove CONN_IS_PROXIED macro as no longer needed.

Closes #21423

5 weeks agochecksrc: add missing semicolon, fix `IFDEFSINGLE` capture group
Viktor Szakats [Fri, 24 Apr 2026 08:07:40 +0000 (10:07 +0200)] 
checksrc: add missing semicolon, fix `IFDEFSINGLE` capture group

Pointed out by GitHub Code Quality

Closes #21435

5 weeks agotests: drop support for the hex="yes" option in getpart
Daniel Stenberg [Thu, 23 Apr 2026 20:54:01 +0000 (22:54 +0200)] 
tests: drop support for the hex="yes" option in getpart

The remaining datacheck sections using this for MQTT tests were not
actually used anyway!

Closes #21428

5 weeks agochecksrc: add missing items to warnings hash, alpha-sort
Viktor Szakats [Fri, 24 Apr 2026 07:53:21 +0000 (09:53 +0200)] 
checksrc: add missing items to warnings hash, alpha-sort

Closes #21434

5 weeks agochecksrc: fix code quality findings
Viktor Szakats [Thu, 23 Apr 2026 23:24:32 +0000 (01:24 +0200)] 
checksrc: fix code quality findings

- fix counting errors. Update test1185 results accordingly.
- fix an error message.
- tidy up regexp syntax.

Pointed out by GitHub Code Quality

Closes #21429