]> git.ipfire.org Git - thirdparty/cups.git/log
thirdparty/cups.git
23 months agoclient.c: Fix web UI job queries on Classes/Printers pages 974/head
Zdenek Dohnal [Wed, 5 Jun 2024 14:13:28 +0000 (16:13 +0200)] 
client.c: Fix web UI job queries on Classes/Printers pages

Web UI query on Classes/Printers should support:

- search for class/printer (/?QUERY=)
- manage printers (/?)
- listing jobs for the printer/class (/name?Which_jobs=completed)
- show NOT FOUND for non-existing destinations

The PR reworks the code to fix the 3rd point and support all other at
the same time.

Fixes Apple/CUPS #6204

23 months agoFix copyright
Zdenek Dohnal [Tue, 4 Jun 2024 13:13:41 +0000 (15:13 +0200)] 
Fix copyright

23 months agoFix DNS-SD lookups of local services with Avahi (Issue #970)
Michael R Sweet [Thu, 30 May 2024 12:09:52 +0000 (08:09 -0400)] 
Fix DNS-SD lookups of local services with Avahi (Issue #970)

23 months agoRevert Host: header change (Issue #967)
Michael R Sweet [Wed, 29 May 2024 00:43:18 +0000 (20:43 -0400)] 
Revert Host: header change (Issue #967)

23 months agoFix infinite loop if the format buffer is too small.
Michael R Sweet [Tue, 28 May 2024 23:46:08 +0000 (19:46 -0400)] 
Fix infinite loop if the format buffer is too small.

23 months agoFix form decode problems.
Michael R Sweet [Tue, 28 May 2024 21:05:12 +0000 (17:05 -0400)] 
Fix form decode problems.

2 years agoMerge pull request #965 from cjlano/patch-1
zdohnal [Tue, 28 May 2024 15:25:38 +0000 (17:25 +0200)] 
Merge pull request #965 from cjlano/patch-1

Fix typo in fr/printer-default.tmpl

2 years agoFix typo in fr/printer-default.tmpl 965/head
CJlano [Mon, 27 May 2024 09:25:40 +0000 (11:25 +0200)] 
Fix typo in fr/printer-default.tmpl

2 years agoMake cupsJSONAdd public API (needed for making JWK sets)
Michael R Sweet [Sat, 25 May 2024 19:15:42 +0000 (15:15 -0400)] 
Make cupsJSONAdd public API (needed for making JWK sets)

2 years agoMore Coverity fixes.
Michael R Sweet [Wed, 22 May 2024 20:48:31 +0000 (16:48 -0400)] 
More Coverity fixes.

2 years agoMerge Coverity fixes.
Michael R Sweet [Wed, 22 May 2024 19:30:42 +0000 (15:30 -0400)] 
Merge Coverity fixes.

2 years agoMore Avahi changes to fix threading issues (Issue #936)
Michael R Sweet [Tue, 21 May 2024 16:50:39 +0000 (12:50 -0400)] 
More Avahi changes to fix threading issues (Issue #936)

2 years agoFix threading and callback issues with Avahi (Issue #936)
Michael R Sweet [Tue, 21 May 2024 13:57:57 +0000 (09:57 -0400)] 
Fix threading and callback issues with Avahi (Issue #936)

2 years agoSync up DNS-SD code.
Michael R Sweet [Fri, 17 May 2024 19:21:21 +0000 (15:21 -0400)] 
Sync up DNS-SD code.

2 years agoSet SNI extension with OpenSSL.
Michael R Sweet [Fri, 17 May 2024 15:57:29 +0000 (11:57 -0400)] 
Set SNI extension with OpenSSL.

2 years agocups/dest.c: Fix `cupsConnectDest()` return value if we cannot connect and don't...
zdohnal [Fri, 17 May 2024 12:27:46 +0000 (14:27 +0200)] 
cups/dest.c: Fix `cupsConnectDest()` return value if we cannot connect and don't want dest with no connection

Fix wrong cb parameter in `cupsConnectDest()` and return NULL pointer if connection cannnot be established (fixes #958 )

2 years agocgi-bin/var.c: Fix return value if the text is invalid
zdohnal [Thu, 16 May 2024 13:45:53 +0000 (15:45 +0200)] 
cgi-bin/var.c: Fix return value if the text is invalid

In `cgiGetTextfield()`, if the original value contains double quote, which is forbidden for text, we free the variable and move the next variable from array to its place. However, the return value still contains the original value of freed pointer, and shows garbage when used.

Set it NULL, since we don't have any value to return for the requested name.

2 years agocgi-bin/var.c: Fix return value if the text is invalid 961/head
Zdenek Dohnal [Thu, 16 May 2024 13:29:34 +0000 (15:29 +0200)] 
cgi-bin/var.c: Fix return value if the text is invalid

If the original value contains double quote, which is forbidden for
text, we free the variable and move the next variable from array to its
place. However, the return value still contains the original value of
freed pointer.

Set it NULL, since we don't have any value to return for the requested
name.

2 years agoFix wrong cb parameter in `cupsConnectDest()` and return NULL pointer if connection... 960/head
jiang-xiaowen-psh [Thu, 16 May 2024 08:36:45 +0000 (17:36 +0900)] 
Fix wrong cb parameter in `cupsConnectDest()` and return NULL pointer if connection cannnot be established

2 years agoMerge pull request #959 from zdohnal/job-preset-ci-fail
zdohnal [Thu, 16 May 2024 06:23:50 +0000 (08:23 +0200)] 
Merge pull request #959 from zdohnal/job-preset-ci-fail

Fix CI failure due job-presets support

2 years agoFix CI failure due job-presets support 959/head
Zdenek Dohnal [Wed, 15 May 2024 10:57:14 +0000 (12:57 +0200)] 
Fix CI failure due job-presets support

2 years agoclient.c: Allow any query string starting with '?'
Zdenek Dohnal [Wed, 15 May 2024 09:40:22 +0000 (11:40 +0200)] 
client.c: Allow any query string starting with '?'

Allow query strings starting with '?' when accessing the '/printers' and
'/classes' resources.

2 years agoFix HTTP query in web interface (fixes #954)
zdohnal [Wed, 15 May 2024 09:36:33 +0000 (11:36 +0200)] 
Fix HTTP query in web interface (fixes #954)

We can use ?QUERY= in URL for searching for destinations - allow it when checking whether the destination exists.

2 years agoFix HTTP query in web interface (fixes #954) 957/head
Zdenek Dohnal [Tue, 14 May 2024 12:03:44 +0000 (14:03 +0200)] 
Fix HTTP query in web interface (fixes #954)

We can use `?QUERY=` in URL for searching for destinations
- allow it when checking whether the destination exists.

2 years agoFix non-quick copies of collection values.
Michael R Sweet [Fri, 3 May 2024 15:44:56 +0000 (11:44 -0400)] 
Fix non-quick copies of collection values.

2 years agoAdd LDFLAGS for macOS CI.
Michael R Sweet [Fri, 26 Apr 2024 20:19:29 +0000 (16:19 -0400)] 
Add LDFLAGS for macOS CI.

2 years agoInstall prerequisites on macOS, normalize step labels.
Michael R Sweet [Fri, 26 Apr 2024 20:15:07 +0000 (16:15 -0400)] 
Install prerequisites on macOS, normalize step labels.

2 years agoUpdate CHANGES.md based on the recent relevant commits
Zdenek Dohnal [Fri, 26 Apr 2024 08:31:38 +0000 (10:31 +0200)] 
Update CHANGES.md based on the recent relevant commits

2 years agoAdd job-presets-supported to CUPS shared printers (Issue #778)
Michael R Sweet [Thu, 25 Apr 2024 22:16:21 +0000 (18:16 -0400)] 
Add job-presets-supported to CUPS shared printers (Issue #778)

2 years agoAdd job-sheets-col support (Issue #138)
Michael R Sweet [Thu, 25 Apr 2024 20:51:57 +0000 (16:51 -0400)] 
Add job-sheets-col support (Issue #138)

2 years agoAdd --list-all option to cupsfilter (Issue #194)
Michael R Sweet [Thu, 25 Apr 2024 15:18:55 +0000 (11:18 -0400)] 
Add --list-all option to cupsfilter (Issue #194)

2 years agoFix warnings.
Michael R Sweet [Thu, 25 Apr 2024 14:53:36 +0000 (10:53 -0400)] 
Fix warnings.

2 years agoFix finishings support in ippeveps.
Michael R Sweet [Thu, 25 Apr 2024 14:51:54 +0000 (10:51 -0400)] 
Fix finishings support in ippeveps.

2 years agoConvert dnssd backend to use cupsDNSSD APIs.
Michael R Sweet [Wed, 24 Apr 2024 21:27:17 +0000 (17:27 -0400)] 
Convert dnssd backend to use cupsDNSSD APIs.

2 years agoClean up mDNSResponder support.
Michael R Sweet [Sun, 21 Apr 2024 19:54:43 +0000 (15:54 -0400)] 
Clean up mDNSResponder support.

2 years agoFix typos in comments.
Michael R Sweet [Sun, 21 Apr 2024 13:36:29 +0000 (09:36 -0400)] 
Fix typos in comments.

2 years agoFix a deadlocking issue and add some more tests for the newer APIs.
Michael R Sweet [Sun, 21 Apr 2024 13:26:26 +0000 (09:26 -0400)] 
Fix a deadlocking issue and add some more tests for the newer APIs.

2 years agoInitial support for multiple DNS-SD domains and Avahi.
Michael R Sweet [Fri, 19 Apr 2024 21:45:19 +0000 (17:45 -0400)] 
Initial support for multiple DNS-SD domains and Avahi.

2 years agoIncrease the mime.types limit to 8192 bytes and document it (Issue #925)
Michael R Sweet [Thu, 18 Apr 2024 23:06:27 +0000 (19:06 -0400)] 
Increase the mime.types limit to 8192 bytes and document it (Issue #925)

2 years agoUpdate checkbox support code.
Michael R Sweet [Thu, 18 Apr 2024 20:23:54 +0000 (16:23 -0400)] 
Update checkbox support code.

2 years agoAdd some debug logging to the message localization stuff.
Michael R Sweet [Thu, 18 Apr 2024 19:57:57 +0000 (15:57 -0400)] 
Add some debug logging to the message localization stuff.

2 years agoAdd some logging to the new DNS-SD stuff.
Michael R Sweet [Thu, 18 Apr 2024 19:57:33 +0000 (15:57 -0400)] 
Add some logging to the new DNS-SD stuff.

2 years agoAdopt new DNS-SD API for cupsd sharing (Issue #931)
Michael R Sweet [Thu, 18 Apr 2024 18:14:28 +0000 (14:14 -0400)] 
Adopt new DNS-SD API for cupsd sharing (Issue #931)

Note: Still needs more testing.

2 years agoFix support for simple punch finisher (Issue #821)
Michael R Sweet [Wed, 17 Apr 2024 00:08:57 +0000 (20:08 -0400)] 
Fix support for simple punch finisher (Issue #821)

2 years agoFix ippeveprinter issues.
Michael R Sweet [Tue, 16 Apr 2024 23:42:26 +0000 (19:42 -0400)] 
Fix ippeveprinter issues.

2 years agoFix Windows DLL exports.
Michael R Sweet [Tue, 16 Apr 2024 18:02:56 +0000 (14:02 -0400)] 
Fix Windows DLL exports.

2 years agoMove printer-strings-languages-supported to common data.
Michael R Sweet [Tue, 16 Apr 2024 13:59:18 +0000 (09:59 -0400)] 
Move printer-strings-languages-supported to common data.

2 years agoFix typos.
Michael R Sweet [Tue, 16 Apr 2024 13:52:31 +0000 (09:52 -0400)] 
Fix typos.

2 years agoMerge pull request #942 from OpenPrinting/l10n
Michael R Sweet [Tue, 16 Apr 2024 13:01:21 +0000 (09:01 -0400)] 
Merge pull request #942 from OpenPrinting/l10n

Support multiple languages with IPP Everywhere

2 years agoUpdate cups-files.conf man page. 942/head
Michael R Sweet [Tue, 16 Apr 2024 12:51:38 +0000 (08:51 -0400)] 
Update cups-files.conf man page.

Move writing of strings files to cupsdCleanDirty, and add new
CUPSD_DIRTY_STRINGS bit.

Update PPD cache version and check modification time of cups-files.conf to
trigger re-load of strings.

Make sure "strings" subdirectory is created as necessary.

2 years agoUpdate _ppdCacheCreateWithPPD to collect localizable strings for the languages
Michael R Sweet [Tue, 16 Apr 2024 12:29:10 +0000 (08:29 -0400)] 
Update _ppdCacheCreateWithPPD to collect localizable strings for the languages
we are interested in.

Add support for Languages directive in cups-files.conf.

2 years agoUpdate _ppdCacheCreateWithPPD to accept languages to localize.
Michael R Sweet [Mon, 15 Apr 2024 20:00:42 +0000 (16:00 -0400)] 
Update _ppdCacheCreateWithPPD to accept languages to localize.

2 years agoAddress clang warning.
Michael R Sweet [Mon, 15 Apr 2024 19:02:37 +0000 (15:02 -0400)] 
Address clang warning.

2 years agoUpdate _cupsMessageLoad to accept existing strings array.
Michael R Sweet [Mon, 15 Apr 2024 00:37:11 +0000 (20:37 -0400)] 
Update _cupsMessageLoad to accept existing strings array.

2 years agoLocalize finishings/finishings-col, media-source, media-type, output-bin, and
Michael R Sweet [Sun, 14 Apr 2024 14:51:54 +0000 (10:51 -0400)] 
Localize finishings/finishings-col, media-source, media-type, output-bin, and
printer-state-reasons keywords using both the standard CUPS message catalogs and
the printer's own strings files, with a backup of converting keywords like
"one-two-three" to "One Two Three".

Ignore generated cachebench program.

2 years agoFix printer-strings-uri support in _ppdCreateFromIPP.
Michael R Sweet [Fri, 12 Apr 2024 23:26:24 +0000 (19:26 -0400)] 
Fix printer-strings-uri support in _ppdCreateFromIPP.

Add PPD cache benchmarking program.

2 years agoUpdate browsw output.
Michael R Sweet [Wed, 10 Apr 2024 21:31:25 +0000 (17:31 -0400)] 
Update browsw output.

2 years agoAdd 'browse' sub-command to DNS-SD test program.
Michael R Sweet [Wed, 10 Apr 2024 21:26:23 +0000 (17:26 -0400)] 
Add 'browse' sub-command to DNS-SD test program.

2 years agoFix crash when host is NULL.
Michael R Sweet [Wed, 10 Apr 2024 20:26:38 +0000 (16:26 -0400)] 
Fix crash when host is NULL.

2 years agoDon't mark BG thread done until the response is sent.
Michael R Sweet [Wed, 10 Apr 2024 18:09:42 +0000 (14:09 -0400)] 
Don't mark BG thread done until the response is sent.

2 years agoInitial work on loading all desired languages from IPP printer.
Michael R Sweet [Tue, 9 Apr 2024 22:18:32 +0000 (18:18 -0400)] 
Initial work on loading all desired languages from IPP printer.

2 years agoFix warnings.
Michael R Sweet [Tue, 9 Apr 2024 22:18:08 +0000 (18:18 -0400)] 
Fix warnings.

2 years agoFix regression for background queue creation (Issue #934)
Michael R Sweet [Tue, 9 Apr 2024 15:51:47 +0000 (11:51 -0400)] 
Fix regression for background queue creation (Issue #934)

2 years agoFix constant name.
Michael R Sweet [Sat, 6 Apr 2024 14:22:57 +0000 (10:22 -0400)] 
Fix constant name.

2 years agoUse NULL hostname for services on the loopback interface (Issue #902)
Michael R Sweet [Sat, 6 Apr 2024 13:51:14 +0000 (09:51 -0400)] 
Use NULL hostname for services on the loopback interface (Issue #902)

2 years agoUse size_t for buffer size and make sure it is at least 4 bytes long (Issue #921)
Michael R Sweet [Sat, 6 Apr 2024 13:37:09 +0000 (09:37 -0400)] 
Use size_t for buffer size and make sure it is at least 4 bytes long (Issue #921)

2 years agoReport an error if you use lpadmin to set defaults for a temporary queue (Issue ...
Michael R Sweet [Fri, 5 Apr 2024 21:26:19 +0000 (17:26 -0400)] 
Report an error if you use lpadmin to set defaults for a temporary queue (Issue #237)

2 years agoDelete enum attribute if the value is bad.
Michael R Sweet [Fri, 5 Apr 2024 21:03:32 +0000 (17:03 -0400)] 
Delete enum attribute if the value is bad.

2 years agoSupport enum keywords (Issue #734)
Michael R Sweet [Fri, 5 Apr 2024 21:00:45 +0000 (17:00 -0400)] 
Support enum keywords (Issue #734)

2 years agoFix document-unprintable-error support (Issue #391)
Michael R Sweet [Fri, 5 Apr 2024 20:43:38 +0000 (16:43 -0400)] 
Fix document-unprintable-error support (Issue #391)

2 years agoSupport ippeveprinter -f option with -a (Issue #759)
Michael R Sweet [Fri, 5 Apr 2024 20:34:05 +0000 (16:34 -0400)] 
Support ippeveprinter -f option with -a (Issue #759)

2 years agoTweak Docker docos.
Michael R Sweet [Fri, 5 Apr 2024 20:17:10 +0000 (16:17 -0400)] 
Tweak Docker docos.

2 years agoMerge pull request #929 from Rudra-IITM/docker_build
Michael R Sweet [Fri, 5 Apr 2024 20:13:37 +0000 (16:13 -0400)] 
Merge pull request #929 from Rudra-IITM/docker_build

[Add] Dockerfile and Docker Compose for CUPS setup

2 years agoUse cupsCopyString instead of strlcpy.
Michael R Sweet [Fri, 5 Apr 2024 18:13:47 +0000 (14:13 -0400)] 
Use cupsCopyString instead of strlcpy.

2 years agoChangelog.
Michael R Sweet [Fri, 5 Apr 2024 17:26:10 +0000 (13:26 -0400)] 
Changelog.

2 years agoAdd cupsCopyDestInfo2 API (Issue #586)
Michael R Sweet [Fri, 5 Apr 2024 17:25:31 +0000 (13:25 -0400)] 
Add cupsCopyDestInfo2 API (Issue #586)

2 years agoupdate install.md 929/head
Rudra-IITM [Fri, 5 Apr 2024 17:08:01 +0000 (22:38 +0530)] 
update install.md

2 years agoFix cupsCopyDestInfo device connection detection (Issue #586)
Michael R Sweet [Fri, 5 Apr 2024 17:07:56 +0000 (13:07 -0400)] 
Fix cupsCopyDestInfo device connection detection (Issue #586)

2 years agoadd dockerfile and docker-compose file
Rudra-IITM [Fri, 5 Apr 2024 17:00:54 +0000 (22:30 +0530)] 
add dockerfile and docker-compose file

2 years agoAllow PPD choices and PWG keywords to select media (Issue #238)
Michael R Sweet [Fri, 5 Apr 2024 12:46:37 +0000 (08:46 -0400)] 
Allow PPD choices and PWG keywords to select media (Issue #238)

2 years agoUpdate CHANGES.md
Zdenek Dohnal [Fri, 5 Apr 2024 08:44:55 +0000 (10:44 +0200)] 
Update CHANGES.md

2 years agoscheduler: Fix sending response headers to client
zdohnal [Fri, 5 Apr 2024 08:41:00 +0000 (10:41 +0200)] 
scheduler: Fix sending response headers to client

Sometimes headers are not correctly copied into response to the client (some are missing). It happens because sent_header is set prematurely before the actual send happens. The present code in affected cupsdWriteClient() scope looks like code remains from CUPS 1.6.3, where cupsdSendHeader() is called earlier and generates the required headers by itself - the current cupsdSendHeader() sends only the headers which are saved in array fields, so the premature setting of sent_header sometimes causes not having all headers in the response.

With the change, testing via curl gives reliable results all time.

2 years agoUpdate CUPS-Add-Modify-Printer and CUPS-Create-Local-Printer code to delay
Michael R Sweet [Thu, 4 Apr 2024 18:38:34 +0000 (14:38 -0400)] 
Update CUPS-Add-Modify-Printer and CUPS-Create-Local-Printer code to delay
responding until the PPD is successfully generated (Issue #347)

2 years agoscheduler: Fix sending response headers to client 927/head
Zdenek Dohnal [Wed, 3 Apr 2024 08:39:24 +0000 (10:39 +0200)] 
scheduler: Fix sending response headers to client

Sometimes headers are not correctly copied into response to the client
(some are missing). It happens because `sent_header` is set prematurely
before the actual send happens. The present code in affected `cupsdWriteClient`
scope looks like code remains from CUPS 1.6.3.

With the change, testing via curl gives reliable results all time.

2 years agoPut it back - Github is confused.
Michael R Sweet [Wed, 3 Apr 2024 00:31:26 +0000 (20:31 -0400)] 
Put it back - Github is confused.

2 years agoRename CodeQL workflow to satisfy Github.
Michael R Sweet [Wed, 3 Apr 2024 00:21:02 +0000 (20:21 -0400)] 
Rename CodeQL workflow to satisfy Github.

2 years agoFix CodeQL-detected missing NULL check.
Michael R Sweet [Wed, 3 Apr 2024 00:10:29 +0000 (20:10 -0400)] 
Fix CodeQL-detected missing NULL check.

2 years agoUpdate default destination documentation (Issue #819)
Michael R Sweet [Tue, 2 Apr 2024 23:50:26 +0000 (19:50 -0400)] 
Update default destination documentation (Issue #819)

2 years agoMerge pull request #837 from zdohnal/fix-reasons-for-older-jobs
Michael R Sweet [Tue, 2 Apr 2024 22:55:56 +0000 (18:55 -0400)] 
Merge pull request #837 from zdohnal/fix-reasons-for-older-jobs

scheduler: Fix reasons for previously printed jobs

2 years agoFix some build issues (Issue #674)
Michael R Sweet [Tue, 2 Apr 2024 22:48:54 +0000 (18:48 -0400)] 
Fix some build issues (Issue #674)

2 years agoMerge pull request #674 from AtariDreams/ABI
Michael R Sweet [Tue, 2 Apr 2024 22:45:44 +0000 (18:45 -0400)] 
Merge pull request #674 from AtariDreams/ABI

Create shims to pass to array structures as to not pass incompatible function pointers

2 years agoMerge branch 'master' into ABI 674/head
Michael R Sweet [Tue, 2 Apr 2024 22:44:53 +0000 (18:44 -0400)] 
Merge branch 'master' into ABI

2 years agoFix 'deny everyone' example (Issue #844)
Michael R Sweet [Tue, 2 Apr 2024 21:47:49 +0000 (17:47 -0400)] 
Fix 'deny everyone' example (Issue #844)

2 years agoFix httpGets timeout handling (Issue #879)
Michael R Sweet [Tue, 2 Apr 2024 15:19:41 +0000 (11:19 -0400)] 
Fix httpGets timeout handling (Issue #879)

2 years agoDrop 'none' test (Issue #909)
Michael R Sweet [Tue, 2 Apr 2024 14:51:19 +0000 (10:51 -0400)] 
Drop 'none' test (Issue #909)

2 years agocups/request.c: Show filename in message in `cupsDoFileRequest()`
zdohnal [Tue, 2 Apr 2024 13:52:25 +0000 (15:52 +0200)] 
cups/request.c: Show filename in message in `cupsDoFileRequest()`

Show which file we tried to access in the error message, if we have issues accessing it.

Related #904

2 years agoFix the initialization and validation of checkbox and text fields in CGI forms.
Michael R Sweet [Tue, 2 Apr 2024 12:36:06 +0000 (08:36 -0400)] 
Fix the initialization and validation of checkbox and text fields in CGI forms.

2 years agoUpdate CUPS-Create-Local-Printer to preserve the existing printer based on the
Michael R Sweet [Wed, 27 Mar 2024 18:38:46 +0000 (14:38 -0400)] 
Update CUPS-Create-Local-Printer to preserve the existing printer based on the
device URI (Issue #871)

Also keep the temporary printer for up to 5 minutes without activity, and update
the state change time every time CUPS-Create-Local-Printer is called.

2 years agoFix client logging of requests.
Michael R Sweet [Wed, 27 Mar 2024 18:38:28 +0000 (14:38 -0400)] 
Fix client logging of requests.

2 years agoDon't use sanitizer on macOS due to performance issues on Github Actions servers.
Michael R Sweet [Wed, 27 Mar 2024 18:32:00 +0000 (14:32 -0400)] 
Don't use sanitizer on macOS due to performance issues on Github Actions servers.