]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
7 weeks agothe sbuff escape / unescape rules should be const
Alan T. DeKok [Wed, 4 Mar 2026 12:38:33 +0000 (07:38 -0500)] 
the sbuff escape / unescape rules should be const

7 weeks agomove escape sbuff sequences to utility library
Alan T. DeKok [Wed, 4 Mar 2026 12:33:55 +0000 (07:33 -0500)] 
move escape sbuff sequences to utility library

so that others can use them

7 weeks agocheck for initialize failure
Alan T. DeKok [Wed, 4 Mar 2026 12:06:19 +0000 (07:06 -0500)] 
check for initialize failure

7 weeks agotypo
Alan T. DeKok [Wed, 4 Mar 2026 12:02:48 +0000 (07:02 -0500)] 
typo

7 weeks agoquiet static analyzer
Alan T. DeKok [Wed, 4 Mar 2026 12:02:12 +0000 (07:02 -0500)] 
quiet static analyzer

7 weeks agofix: 1. return 01 --> return -1 (it's meant to be an error return val)
Catalina Pineros [Tue, 3 Mar 2026 21:22:18 +0000 (16:22 -0500)] 
fix:    1. return 01 --> return -1 (it's meant to be an error return val)
2. uid_str --> gid_str  (orelse it's checking the same condition twice)
3. uid_str --> gid_str typo (orelse it's running a gid function on a uid_str)
(fix(sem): octal return value, wrong NULL check variable, and wrong gid_t type in header 168)

7 weeks agoformatting bug: changed '%zu' to '%zuk' to stay consisten in error message
Catalina Pineros [Tue, 3 Mar 2026 20:59:31 +0000 (15:59 -0500)] 
formatting bug: changed '%zu' to '%zuk' to stay consisten in error message
(rlm_sql_sqlite: add missing 'k' unit to bootstrap file size error message 411)

7 weeks agoprotocols/der: fix fr_der_flag_has_default_value macro — trailing semicolon and spuri...
Catalina Pineros [Tue, 3 Mar 2026 19:38:07 +0000 (14:38 -0500)] 
protocols/der: fix fr_der_flag_has_default_value macro — trailing semicolon and spurious != NULL comparison

7 weeks agorlm_wimax: fix trailing dash overwriting null terminator in Calling-Station-Id reform...
Catalina Pineros [Tue, 3 Mar 2026 19:37:21 +0000 (14:37 -0500)] 
rlm_wimax: fix trailing dash overwriting null terminator in Calling-Station-Id reformatter

8 weeks agocheck proper return code
Alan T. DeKok [Tue, 3 Mar 2026 22:04:44 +0000 (17:04 -0500)] 
check proper return code

the function returns 0 for "more data", and 1 for "no data",
which is different from the other APIs

8 weeks agocheck for invalid hex digits
Alan T. DeKok [Tue, 3 Mar 2026 22:01:13 +0000 (17:01 -0500)] 
check for invalid hex digits

8 weeks agouse correct IP when prefix=0
Alan T. DeKok [Tue, 3 Mar 2026 21:55:30 +0000 (16:55 -0500)] 
use correct IP when prefix=0

8 weeks agovarious bug fixes in command.c
Alan T. DeKok [Tue, 3 Mar 2026 21:55:20 +0000 (16:55 -0500)] 
various bug fixes in command.c

8 weeks agoremove unused macro
Alan T. DeKok [Tue, 3 Mar 2026 19:51:16 +0000 (14:51 -0500)] 
remove unused macro

8 weeks agoturn off more warning messages
Alan T. DeKok [Tue, 3 Mar 2026 19:51:26 +0000 (14:51 -0500)] 
turn off more warning messages

8 weeks agoignore AI test files
Alan T. DeKok [Tue, 3 Mar 2026 19:41:20 +0000 (14:41 -0500)] 
ignore AI test files

8 weeks agoadd basic tests for calc.c
Alan T. DeKok [Tue, 3 Mar 2026 15:39:21 +0000 (10:39 -0500)] 
add basic tests for calc.c

8 weeks agoremove unused variables
Alan T. DeKok [Tue, 3 Mar 2026 18:13:04 +0000 (13:13 -0500)] 
remove unused variables

8 weeks agonot all packet codes are valid
Alan T. DeKok [Tue, 3 Mar 2026 18:10:52 +0000 (13:10 -0500)] 
not all packet codes are valid

8 weeks agocheck for errors and set flags
Alan T. DeKok [Tue, 3 Mar 2026 18:08:40 +0000 (13:08 -0500)] 
check for errors and set flags

8 weeks agovarious bug fixes in eap-md5
Alan T. DeKok [Tue, 3 Mar 2026 16:27:38 +0000 (11:27 -0500)] 
various bug fixes in eap-md5

we don't use "name".

check password length

add more sanity checks

8 weeks agoctime() can return NULL
Alan T. DeKok [Tue, 3 Mar 2026 15:20:01 +0000 (10:20 -0500)] 
ctime() can return NULL

8 weeks agotweak bounds
Alan T. DeKok [Tue, 3 Mar 2026 15:06:57 +0000 (10:06 -0500)] 
tweak bounds

8 weeks agomore fix typos
Alan T. DeKok [Tue, 3 Mar 2026 14:43:40 +0000 (09:43 -0500)] 
more fix typos

to finish the changes from bcf136dd0

8 weeks agotypo in macro
Alan T. DeKok [Tue, 3 Mar 2026 14:29:04 +0000 (09:29 -0500)] 
typo in macro

8 weeks agouse "goto fail" in more situations
Alan T. DeKok [Tue, 3 Mar 2026 14:27:42 +0000 (09:27 -0500)] 
use "goto fail" in more situations

8 weeks agominor tweaks and updates to the use of AI
Alan T. DeKok [Tue, 3 Mar 2026 13:39:16 +0000 (08:39 -0500)] 
minor tweaks and updates to the use of AI

8 weeks agoAdd client name to error message
Nick Porter [Tue, 3 Mar 2026 17:30:07 +0000 (17:30 +0000)] 
Add client name to error message

8 weeks agoFallback to attribute parsing if cast doesn't work
Nick Porter [Mon, 2 Mar 2026 17:58:31 +0000 (17:58 +0000)] 
Fallback to attribute parsing if cast doesn't work

This allows call_env parsing for types such as uint32 to support

foo = 10

and

foo = attr

with the value being a bare word in both cases.

8 weeks agomanually do dir + filename
Alan T. DeKok [Mon, 2 Mar 2026 21:51:03 +0000 (16:51 -0500)] 
manually do dir + filename

to get rid of all double '/', and to avoid walking over the
input strings repeatedly.

8 weeks agorelax checks in corner conditions
Alan T. DeKok [Mon, 2 Mar 2026 21:49:58 +0000 (16:49 -0500)] 
relax checks in corner conditions

8 weeks agoassert that the entry is in the heap
Alan T. DeKok [Mon, 2 Mar 2026 19:50:26 +0000 (14:50 -0500)] 
assert that the entry is in the heap

8 weeks agofree group on error
Alan T. DeKok [Mon, 2 Mar 2026 19:48:20 +0000 (14:48 -0500)] 
free group on error

8 weeks agoshut up analyzer
Alan T. DeKok [Mon, 2 Mar 2026 16:24:00 +0000 (11:24 -0500)] 
shut up analyzer

8 weeks agowhen shutdown fails, enter failed state, not closed state
Alan T. DeKok [Mon, 2 Mar 2026 16:15:11 +0000 (11:15 -0500)] 
when shutdown fails, enter failed state, not closed state

8 weeks agovarious bug fixes in limit.c
Alan T. DeKok [Mon, 2 Mar 2026 16:14:57 +0000 (11:14 -0500)] 
various bug fixes in limit.c

8 weeks agovarious bug fixes in hash.c
Alan T. DeKok [Mon, 2 Mar 2026 16:04:32 +0000 (11:04 -0500)] 
various bug fixes in hash.c

8 weeks agoadd locks when accessing entry
Alan T. DeKok [Mon, 2 Mar 2026 12:32:44 +0000 (07:32 -0500)] 
add locks when accessing entry

8 weeks agofix typo
Alan T. DeKok [Mon, 2 Mar 2026 12:29:27 +0000 (07:29 -0500)] 
fix typo

8 weeks agofix name comparison callbacks to use correct values
Alan T. DeKok [Sun, 1 Mar 2026 21:17:55 +0000 (16:17 -0500)] 
fix name comparison callbacks to use correct values

8 weeks agoreturn on failure
Alan T. DeKok [Sun, 1 Mar 2026 21:16:11 +0000 (16:16 -0500)] 
return on failure

8 weeks agocheck before memcpy
Alan T. DeKok [Sun, 1 Mar 2026 21:15:46 +0000 (16:15 -0500)] 
check before memcpy

8 weeks agouse digest_find_vp() for qop, too
Alan T. DeKok [Sun, 1 Mar 2026 21:13:51 +0000 (16:13 -0500)] 
use digest_find_vp() for qop, too

even though it's hex

8 weeks agopoint to correct attribute
Alan T. DeKok [Sun, 1 Mar 2026 21:11:18 +0000 (16:11 -0500)] 
point to correct attribute

8 weeks agotypos in lengths
Alan T. DeKok [Sun, 1 Mar 2026 21:11:08 +0000 (16:11 -0500)] 
typos in lengths

8 weeks agoclean up cs on error
Alan T. DeKok [Sun, 1 Mar 2026 21:09:25 +0000 (16:09 -0500)] 
clean up cs on error

8 weeks agoAdd test of redis_ippool with requested address
Nick Porter [Mon, 2 Mar 2026 14:51:34 +0000 (14:51 +0000)] 
Add test of redis_ippool with requested address

8 weeks agoRenumber lua script lines
Nick Porter [Mon, 2 Mar 2026 14:49:36 +0000 (14:49 +0000)] 
Renumber lua script lines

8 weeks agoHonour requested address in rlm_redis_ippool
Nick Porter [Mon, 2 Mar 2026 11:42:23 +0000 (11:42 +0000)] 
Honour requested address in rlm_redis_ippool

8 weeks agoCompare numbers rather than strings
Nick Porter [Mon, 2 Mar 2026 14:26:59 +0000 (14:26 +0000)] 
Compare numbers rather than strings

Since 10 > 2 but "10" < "2"

8 weeks agoMutex is protecting dlist maniplation, not entry->expires (CID #1682066)
Nick Porter [Mon, 2 Mar 2026 08:21:38 +0000 (08:21 +0000)] 
Mutex is protecting dlist maniplation, not entry->expires (CID #1682066)

8 weeks agovarious bug fixes in pool.c
Alan T. DeKok [Sun, 1 Mar 2026 20:04:52 +0000 (15:04 -0500)] 
various bug fixes in pool.c

8 weeks agofix pipe bio to use normal read/write blocked/resume callbacks
Alan T. DeKok [Sun, 1 Mar 2026 19:57:27 +0000 (14:57 -0500)] 
fix pipe bio to use normal read/write blocked/resume callbacks

8 weeks agojust use our own buffer for the pipes
Alan T. DeKok [Sun, 1 Mar 2026 19:31:52 +0000 (14:31 -0500)] 
just use our own buffer for the pipes

and tweak read/write logic to be better.

8 weeks agoremove duplicate print
Alan T. DeKok [Sun, 1 Mar 2026 18:55:00 +0000 (13:55 -0500)] 
remove duplicate print

8 weeks agomore tests for the edit code
Alan T. DeKok [Sun, 1 Mar 2026 16:45:03 +0000 (11:45 -0500)] 
more tests for the edit code

8 weeks agoFR_EDIT_CHILD doesn't have a vp
Alan T. DeKok [Sun, 1 Mar 2026 16:40:22 +0000 (11:40 -0500)] 
FR_EDIT_CHILD doesn't have a vp

move the check for it to before the assertions that VP is sane

8 weeks agocomment out talloc_get_type_abort_const() until we fix all callers
Alan T. DeKok [Sun, 1 Mar 2026 16:10:05 +0000 (11:10 -0500)] 
comment out talloc_get_type_abort_const() until we fix all callers

8 weeks agotypos in calc.c
Alan T. DeKok [Sun, 1 Mar 2026 16:00:20 +0000 (11:00 -0500)] 
typos in calc.c

8 weeks agodup the correct FD
Alan T. DeKok [Sun, 1 Mar 2026 15:58:47 +0000 (10:58 -0500)] 
dup the correct FD

8 weeks agotypo in cbor
Alan T. DeKok [Sun, 1 Mar 2026 15:57:23 +0000 (10:57 -0500)] 
typo in cbor

8 weeks agofix typos in time code
Alan T. DeKok [Sun, 1 Mar 2026 15:56:23 +0000 (10:56 -0500)] 
fix typos in time code

8 weeks agobetter checks for corner cases when parsing fractional seconds
Alan T. DeKok [Sun, 1 Mar 2026 15:55:02 +0000 (10:55 -0500)] 
better checks for corner cases when parsing fractional seconds

8 weeks agovarious bug fixes in timer.c
Alan T. DeKok [Sun, 1 Mar 2026 15:52:25 +0000 (10:52 -0500)] 
various bug fixes in timer.c

8 weeks agoremove duplicate code
Alan T. DeKok [Sun, 1 Mar 2026 15:50:06 +0000 (10:50 -0500)] 
remove duplicate code

8 weeks agoadd MEM()
Alan T. DeKok [Sun, 1 Mar 2026 15:47:45 +0000 (10:47 -0500)] 
add MEM()

8 weeks agouse vp->da instead of da
Alan T. DeKok [Sun, 1 Mar 2026 15:47:33 +0000 (10:47 -0500)] 
use vp->da instead of da

8 weeks agoclean up for alignment, overflow checks, etc.
Alan T. DeKok [Sun, 1 Mar 2026 15:09:37 +0000 (10:09 -0500)] 
clean up for alignment, overflow checks, etc.

arguably this code should just be removed, as pretty much every
modern OS doesn't need these wrappers

8 weeks agouse value-box API rather than hand-rolled code
Alan T. DeKok [Sun, 1 Mar 2026 14:42:26 +0000 (09:42 -0500)] 
use value-box API rather than hand-rolled code

8 weeks agouse talloc_strlen() instead of talloc_array_length() - 1
Alan T. DeKok [Sat, 28 Feb 2026 14:43:43 +0000 (09:43 -0500)] 
use talloc_strlen() instead of talloc_array_length() - 1

8 weeks agouse talloc_strdup() now that it's a define for talloc_typed_strdup()
Alan T. DeKok [Sat, 28 Feb 2026 14:44:05 +0000 (09:44 -0500)] 
use talloc_strdup() now that it's a define for talloc_typed_strdup()

8 weeks agooutputs depend on the libraries that we're using
Alan T. DeKok [Sat, 28 Feb 2026 16:30:51 +0000 (11:30 -0500)] 
outputs depend on the libraries that we're using

8 weeks agouse correct callback for copy, instead of recursing
Alan T. DeKok [Sat, 28 Feb 2026 15:37:57 +0000 (10:37 -0500)] 
use correct callback for copy, instead of recursing

8 weeks agotypos in pair_tokenize.c
Alan T. DeKok [Sat, 28 Feb 2026 15:36:21 +0000 (10:36 -0500)] 
typos in pair_tokenize.c

8 weeks agoset type for talloc_strdup() and friends
Alan T. DeKok [Sat, 28 Feb 2026 14:31:23 +0000 (09:31 -0500)] 
set type for talloc_strdup() and friends

The talloc string functions set the type of the string to the
string contents.  Which makes it very difficult to do type checking
on them.  As such, we wrap the various functions in ones which set
the name to something reasonable.

8 weeks agodon't pass "const" to talloc functions
Alan T. DeKok [Sat, 28 Feb 2026 14:25:40 +0000 (09:25 -0500)] 
don't pass "const" to talloc functions

8 weeks agosecret may be NULL, and make code more consistent
Alan T. DeKok [Sat, 28 Feb 2026 14:24:49 +0000 (09:24 -0500)] 
secret may be NULL, and make code more consistent

8 weeks agoparent filename off of thread, not inst
Alan T. DeKok [Sat, 28 Feb 2026 14:18:02 +0000 (09:18 -0500)] 
parent filename off of thread, not inst

8 weeks agouse correct attribute for duplicate checks
Alan T. DeKok [Sat, 28 Feb 2026 13:48:21 +0000 (08:48 -0500)] 
use correct attribute for duplicate checks

8 weeks agowarn if they're using a secret other than 'radsec' for TLS.
Alan T. DeKok [Sat, 28 Feb 2026 13:45:59 +0000 (08:45 -0500)] 
warn if they're using a secret other than 'radsec' for TLS.

@todo - also when we do DTLS, the secret should be different.
And when ALPN is used, we don't have a secret

8 weeks agoclean up on failure.
Alan T. DeKok [Sat, 28 Feb 2026 13:42:13 +0000 (08:42 -0500)] 
clean up on failure.

which doesn't matter in practice, as we don't dynamically read
users files.  But it's good practice

8 weeks agoclean up on corner case of failure
Alan T. DeKok [Sat, 28 Feb 2026 13:41:46 +0000 (08:41 -0500)] 
clean up on corner case of failure

and use "goto fail" in more places, to ensure a common cleanup
path

8 weeks agotypo in name match
Alan T. DeKok [Sat, 28 Feb 2026 13:37:35 +0000 (08:37 -0500)] 
typo in name match

8 weeks agoincrement count as per docs
Alan T. DeKok [Sat, 28 Feb 2026 13:36:58 +0000 (08:36 -0500)] 
increment count as per docs

8 weeks agodon't leak FDs on corner cases
Alan T. DeKok [Sat, 28 Feb 2026 13:35:40 +0000 (08:35 -0500)] 
don't leak FDs on corner cases

8 weeks agotypos
Alan T. DeKok [Sat, 28 Feb 2026 13:30:05 +0000 (08:30 -0500)] 
typos

8 weeks agomulti-thread fail is different from single-thread fail
Alan T. DeKok [Sat, 28 Feb 2026 13:28:19 +0000 (08:28 -0500)] 
multi-thread fail is different from single-thread fail

8 weeks agoclean up on error, and insert into list only on success
Alan T. DeKok [Sat, 28 Feb 2026 13:26:42 +0000 (08:26 -0500)] 
clean up on error, and insert into list only on success

8 weeks agoremove duplicate code, and tweak order of existing code to match
Alan T. DeKok [Sat, 28 Feb 2026 13:22:50 +0000 (08:22 -0500)] 
remove duplicate code, and tweak order of existing code to match

8 weeks agofix various bugs in unit_test_map
Alan T. DeKok [Sat, 28 Feb 2026 13:18:30 +0000 (08:18 -0500)] 
fix various bugs in unit_test_map

8 weeks agodon't re-alloc memory, and always close fp on exit
Alan T. DeKok [Sat, 28 Feb 2026 13:14:25 +0000 (08:14 -0500)] 
don't re-alloc memory, and always close fp on exit

8 weeks agofix typo - don't call init twice
Alan T. DeKok [Sat, 28 Feb 2026 13:12:32 +0000 (08:12 -0500)] 
fix typo - don't call init twice

8 weeks agoadd tests for corner cases of keywords
Alan T. DeKok [Fri, 27 Feb 2026 23:40:13 +0000 (18:40 -0500)] 
add tests for corner cases of keywords

8 weeks agocheck extensions, too
Alan T. DeKok [Fri, 27 Feb 2026 22:39:48 +0000 (17:39 -0500)] 
check extensions, too

8 weeks agotypo - use & instead of modulo
Alan T. DeKok [Fri, 27 Feb 2026 22:36:29 +0000 (17:36 -0500)] 
typo - use & instead of modulo

8 weeks agotypo in error messages
Alan T. DeKok [Fri, 27 Feb 2026 22:33:31 +0000 (17:33 -0500)] 
typo in error messages

8 weeks agotrack memory with talloc
Alan T. DeKok [Fri, 27 Feb 2026 22:30:11 +0000 (17:30 -0500)] 
track memory with talloc

TBH, this module should either be discarded, or re-written from
scratch.  It's pretty terrible

8 weeks agoadd tests for cf_util, etc.
Alan T. DeKok [Fri, 27 Feb 2026 22:20:10 +0000 (17:20 -0500)] 
add tests for cf_util, etc.

8 weeks agovarious bug fixes for tmpl_dcursor.c
Alan T. DeKok [Fri, 27 Feb 2026 22:19:39 +0000 (17:19 -0500)] 
various bug fixes for tmpl_dcursor.c

don't return freed pointer

8 weeks agominor fixes to rlm_eap
Alan T. DeKok [Fri, 27 Feb 2026 22:03:35 +0000 (17:03 -0500)] 
minor fixes to rlm_eap