]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
8 weeks agofix various bugs in unit_test_map
Alan T. DeKok [Sat, 28 Feb 2026 13:18:30 +0000 (08:18 -0500)] 
fix various bugs in unit_test_map

8 weeks agodon't re-alloc memory, and always close fp on exit
Alan T. DeKok [Sat, 28 Feb 2026 13:14:25 +0000 (08:14 -0500)] 
don't re-alloc memory, and always close fp on exit

8 weeks agofix typo - don't call init twice
Alan T. DeKok [Sat, 28 Feb 2026 13:12:32 +0000 (08:12 -0500)] 
fix typo - don't call init twice

8 weeks agoadd tests for corner cases of keywords
Alan T. DeKok [Fri, 27 Feb 2026 23:40:13 +0000 (18:40 -0500)] 
add tests for corner cases of keywords

8 weeks agocheck extensions, too
Alan T. DeKok [Fri, 27 Feb 2026 22:39:48 +0000 (17:39 -0500)] 
check extensions, too

8 weeks agotypo - use & instead of modulo
Alan T. DeKok [Fri, 27 Feb 2026 22:36:29 +0000 (17:36 -0500)] 
typo - use & instead of modulo

8 weeks agotypo in error messages
Alan T. DeKok [Fri, 27 Feb 2026 22:33:31 +0000 (17:33 -0500)] 
typo in error messages

8 weeks agotrack memory with talloc
Alan T. DeKok [Fri, 27 Feb 2026 22:30:11 +0000 (17:30 -0500)] 
track memory with talloc

TBH, this module should either be discarded, or re-written from
scratch.  It's pretty terrible

8 weeks agoadd tests for cf_util, etc.
Alan T. DeKok [Fri, 27 Feb 2026 22:20:10 +0000 (17:20 -0500)] 
add tests for cf_util, etc.

8 weeks agovarious bug fixes for tmpl_dcursor.c
Alan T. DeKok [Fri, 27 Feb 2026 22:19:39 +0000 (17:19 -0500)] 
various bug fixes for tmpl_dcursor.c

don't return freed pointer

8 weeks agominor fixes to rlm_eap
Alan T. DeKok [Fri, 27 Feb 2026 22:03:35 +0000 (17:03 -0500)] 
minor fixes to rlm_eap

8 weeks agouse SBUFF_CHAR_CLASS instead of UINT8_MAX + 1
Alan T. DeKok [Fri, 27 Feb 2026 21:56:09 +0000 (16:56 -0500)] 
use SBUFF_CHAR_CLASS instead of UINT8_MAX + 1

and fix a few issues where it wasn't using the "+ 1"

8 weeks agoadd tmpl tests
Alan T. DeKok [Fri, 27 Feb 2026 16:35:41 +0000 (11:35 -0500)] 
add tmpl tests

to avoid regressions, and sanity check the code.

8 weeks agocomplain on invalid input
Alan T. DeKok [Fri, 27 Feb 2026 20:24:14 +0000 (15:24 -0500)] 
complain on invalid input

8 weeks agoreturn on failure
Alan T. DeKok [Fri, 27 Feb 2026 20:20:38 +0000 (15:20 -0500)] 
return on failure

8 weeks agouse correct variable
Alan T. DeKok [Fri, 27 Feb 2026 20:18:17 +0000 (15:18 -0500)] 
use correct variable

8 weeks agovarious bug fixes in password.c
Alan T. DeKok [Fri, 27 Feb 2026 20:15:34 +0000 (15:15 -0500)] 
various bug fixes in password.c

8 weeks agomore error checks for OOM, etc.
Alan T. DeKok [Fri, 27 Feb 2026 20:07:34 +0000 (15:07 -0500)] 
more error checks for OOM, etc.

8 weeks agovarious bug fixes in connection.c
Alan T. DeKok [Fri, 27 Feb 2026 19:59:35 +0000 (14:59 -0500)] 
various bug fixes in connection.c

reset processing_signals on freed, instead of returning.
otherwise it's locked forever.

leave one-shot watchers enabled until they're finished, otherwise
connection_deferred_signal_process() will access a freed watcher

allow more states in the handlers, as they're all valid.

8 weeks agoreturn error on OOM
Alan T. DeKok [Fri, 27 Feb 2026 16:33:47 +0000 (11:33 -0500)] 
return error on OOM

8 weeks agoFree connected dynamic client parents when their idle time expires
Nick Porter [Fri, 27 Feb 2026 15:02:16 +0000 (15:02 +0000)] 
Free connected dynamic client parents when their idle time expires

Without this, the "parent" client which is built when a connected
dynamic client is first created never expires, so the client is never
reloaded.

8 weeks agoadd missing enum.
Alan T. DeKok [Fri, 27 Feb 2026 13:36:08 +0000 (08:36 -0500)] 
add missing enum.

Why not just set TRUNK_CONN_ALL = ~0?

8 weeks agotypos and use dlist API properly
Alan T. DeKok [Fri, 27 Feb 2026 13:31:53 +0000 (08:31 -0500)] 
typos and use dlist API properly

8 weeks agofix typos
Alan T. DeKok [Fri, 27 Feb 2026 13:11:04 +0000 (08:11 -0500)] 
fix typos

8 weeks agoquiet static analysis
Alan T. DeKok [Fri, 27 Feb 2026 13:09:09 +0000 (08:09 -0500)] 
quiet static analysis

2 months agoNeed inline for always_inline to work
Nick Porter [Fri, 27 Feb 2026 10:52:56 +0000 (10:52 +0000)] 
Need inline for always_inline to work

2 months agovarious tweaks to tmpl_tokenize.c
Alan T. DeKok [Fri, 27 Feb 2026 00:59:52 +0000 (19:59 -0500)] 
various tweaks to tmpl_tokenize.c

2 months agocheck for !fips here, too
Alan T. DeKok [Fri, 27 Feb 2026 00:43:54 +0000 (19:43 -0500)] 
check for !fips here, too

2 months agotypo
Alan T. DeKok [Fri, 27 Feb 2026 00:36:33 +0000 (19:36 -0500)] 
typo

2 months agodocs-v4: moved network security best practices page to `Introduction >> Best Practices`.
nolade [Thu, 26 Feb 2026 21:49:52 +0000 (16:49 -0500)] 
docs-v4: moved network security best practices page to `Introduction >> Best Practices`.

2 months agodocs-v4: Added more details to Developer >> Contributing section including git comman...
nolade [Thu, 26 Feb 2026 21:25:26 +0000 (16:25 -0500)] 
docs-v4: Added more details to Developer >> Contributing section including git commands, PR submisssions. Rearranged hierarchy, added subsections, and formatted accordingly to style guide.

2 months agodocs-v4: Correct nav link for `unlang >> List of Data Types`
nolade [Thu, 26 Feb 2026 22:24:20 +0000 (17:24 -0500)] 
docs-v4: Correct nav link for `unlang >> List of Data Types`

2 months agocorrect check for FIPS mode, and re-init free list
Alan T. DeKok [Thu, 26 Feb 2026 15:05:59 +0000 (10:05 -0500)] 
correct check for FIPS mode, and re-init free list

when changing digest functions, we have to clear and re-initialize
the free list, otherwise the contexts are associated with the
wrong ctx_free() function.

2 months agobetter error messages
Alan T. DeKok [Thu, 26 Feb 2026 20:58:04 +0000 (15:58 -0500)] 
better error messages

when local variables are defined in the wrong place

2 months agovarious bug fixes in map.c
Alan T. DeKok [Thu, 26 Feb 2026 20:43:32 +0000 (15:43 -0500)] 
various bug fixes in map.c

don't leak, and make "-=" work a bit better

2 months agovarious bug fixes in rlm_mschap
Alan T. DeKok [Thu, 26 Feb 2026 19:31:37 +0000 (14:31 -0500)] 
various bug fixes in rlm_mschap

2 months agoset result, too
Alan T. DeKok [Thu, 26 Feb 2026 18:48:55 +0000 (13:48 -0500)] 
set result, too

2 months agomore checks for corner cases and invalid data
Alan T. DeKok [Thu, 26 Feb 2026 18:46:33 +0000 (13:46 -0500)] 
more checks for corner cases and invalid data

2 months agotypo
Alan T. DeKok [Thu, 26 Feb 2026 18:34:05 +0000 (13:34 -0500)] 
typo

2 months agoremove PID file on error, too
Alan T. DeKok [Thu, 26 Feb 2026 18:29:43 +0000 (13:29 -0500)] 
remove PID file on error, too

2 months agostatus checks can expire, too
Alan T. DeKok [Thu, 26 Feb 2026 15:51:45 +0000 (10:51 -0500)] 
status checks can expire, too

2 months agoadd more checks and complaints
Alan T. DeKok [Thu, 26 Feb 2026 15:49:11 +0000 (10:49 -0500)] 
add more checks and complaints

2 months agoremove old from htrie, too
Alan T. DeKok [Thu, 26 Feb 2026 15:39:41 +0000 (10:39 -0500)] 
remove old from htrie, too

2 months agovarious bug fixes to pair functions
Alan T. DeKok [Thu, 26 Feb 2026 15:09:54 +0000 (10:09 -0500)] 
various bug fixes to pair functions

check for memory allocation failure, tweak macros, etc.

2 months agouse hyphens
Alan T. DeKok [Thu, 26 Feb 2026 13:45:02 +0000 (08:45 -0500)] 
use hyphens

2 months agouse consistent formatting for copyright notices
Alan T. DeKok [Thu, 26 Feb 2026 13:42:24 +0000 (08:42 -0500)] 
use consistent formatting for copyright notices

2 months agoadd slab tests for commit 331aa05
Alan T. DeKok [Thu, 26 Feb 2026 13:41:01 +0000 (08:41 -0500)] 
add slab tests for commit 331aa05

and use TEST_ASSERT instead of TEST_CHECK + if (!foo) return

2 months agoloop only while we have 4 bytes in the buffer
Alan T. DeKok [Thu, 26 Feb 2026 13:23:36 +0000 (08:23 -0500)] 
loop only while we have 4 bytes in the buffer

2 months agofix order of %ull vs %ul
Alan T. DeKok [Thu, 26 Feb 2026 13:21:45 +0000 (08:21 -0500)] 
fix order of %ull vs %ul

2 months agofix typo
Alan T. DeKok [Thu, 26 Feb 2026 13:18:59 +0000 (08:18 -0500)] 
fix typo

2 months agoremove test content
Alan T. DeKok [Thu, 26 Feb 2026 13:18:43 +0000 (08:18 -0500)] 
remove test content

2 months agovarious bug fixes in EAP
Alan T. DeKok [Thu, 26 Feb 2026 13:05:16 +0000 (08:05 -0500)] 
various bug fixes in EAP

2 months agoeck for rare failure on init
Alan T. DeKok [Thu, 26 Feb 2026 13:09:49 +0000 (08:09 -0500)] 
eck for rare failure on init

2 months agohoist failure check before setting destructor
Alan T. DeKok [Thu, 26 Feb 2026 13:07:31 +0000 (08:07 -0500)] 
hoist failure check before setting destructor

2 months agoalways save a copy of u->packet
Alan T. DeKok [Wed, 25 Feb 2026 22:13:03 +0000 (17:13 -0500)] 
always save a copy of u->packet

2 months agoavoid strlcpy(), and use memcpy() instead
Alan T. DeKok [Wed, 25 Feb 2026 21:33:58 +0000 (16:33 -0500)] 
avoid strlcpy(), and use memcpy() instead

2 months agocheck return code of function
Alan T. DeKok [Wed, 25 Feb 2026 21:28:43 +0000 (16:28 -0500)] 
check return code of function

2 months agocheck for IP in pcap receive path
Alan T. DeKok [Wed, 25 Feb 2026 21:23:22 +0000 (16:23 -0500)] 
check for IP in pcap receive path

2 months agoproduce correct error message, using the configured length
Alan T. DeKok [Wed, 25 Feb 2026 21:20:27 +0000 (16:20 -0500)] 
produce correct error message, using the configured length

2 months agovarious bug fixes in rlm_unix
Alan T. DeKok [Wed, 25 Feb 2026 21:19:08 +0000 (16:19 -0500)] 
various bug fixes in rlm_unix

2 months agopass remaining data, to avoid repeated strlen()
Alan T. DeKok [Wed, 25 Feb 2026 21:16:00 +0000 (16:16 -0500)] 
pass remaining data, to avoid repeated strlen()

2 months agotweaks to comments and assertions
Alan T. DeKok [Wed, 25 Feb 2026 21:14:42 +0000 (16:14 -0500)] 
tweaks to comments and assertions

2 months agovarious bug fixes in winbind
Alan T. DeKok [Wed, 25 Feb 2026 21:12:54 +0000 (16:12 -0500)] 
various bug fixes in winbind

2 months agomore checks for malformed vendor options
Alan T. DeKok [Wed, 25 Feb 2026 21:09:31 +0000 (16:09 -0500)] 
more checks for malformed vendor options

2 months agofree buffer on all error paths
Alan T. DeKok [Wed, 25 Feb 2026 21:08:13 +0000 (16:08 -0500)] 
free buffer on all error paths

2 months agoalways unlock. Fixes CID #1681712
Alan T. DeKok [Wed, 25 Feb 2026 20:48:43 +0000 (15:48 -0500)] 
always unlock.  Fixes CID #1681712

2 months agoAssert if slab elements are not released correctly
Arran Cudbard-Bell [Thu, 26 Feb 2026 00:51:36 +0000 (17:51 -0700)] 
Assert if slab elements are not released correctly

2 months agoattr.by_num is redundant and can be removed
Arran Cudbard-Bell [Wed, 25 Feb 2026 22:30:10 +0000 (15:30 -0700)] 
attr.by_num is redundant and can be removed

2 months agoallow dict.attr.by_oid to operate with foreign protocols
Arran Cudbard-Bell [Wed, 25 Feb 2026 22:00:32 +0000 (15:00 -0700)] 
allow dict.attr.by_oid to operate with foreign protocols

2 months agoRemove unused argument in dict function
Arran Cudbard-Bell [Wed, 25 Feb 2026 22:00:12 +0000 (15:00 -0700)] 
Remove unused argument in dict function

2 months agoonly remove it if it's in the dedup tree
Alan T. DeKok [Wed, 25 Feb 2026 19:18:40 +0000 (14:18 -0500)] 
only remove it if it's in the dedup tree

2 months agoadd assertion to quiet static analyser
Alan T. DeKok [Wed, 25 Feb 2026 18:35:41 +0000 (13:35 -0500)] 
add assertion to quiet static analyser

2 months agoremove old entry from dedup tree
Alan T. DeKok [Wed, 25 Feb 2026 18:31:58 +0000 (13:31 -0500)] 
remove old entry from dedup tree

2 months agoparse *= and /=. Update tests to match
Alan T. DeKok [Wed, 25 Feb 2026 18:18:11 +0000 (13:18 -0500)] 
parse *= and /=.  Update tests to match

2 months agotweak error messages to produce actual error string
Alan T. DeKok [Wed, 25 Feb 2026 18:03:22 +0000 (13:03 -0500)] 
tweak error messages to produce actual error string

2 months agovarious typos in tacacs
Alan T. DeKok [Wed, 25 Feb 2026 15:50:24 +0000 (10:50 -0500)] 
various typos in tacacs

2 months agomake tcp respect max_attributes and require_ma
Alan T. DeKok [Wed, 25 Feb 2026 15:47:16 +0000 (10:47 -0500)] 
make tcp respect max_attributes and require_ma

and also make it handle partial reads

2 months agoallow packet_list_recv() to return error
Alan T. DeKok [Wed, 25 Feb 2026 15:15:31 +0000 (10:15 -0500)] 
allow packet_list_recv() to return error

so that we can close TCP sockets

2 months agovarious bug fixes in the RADIUS protocol handler
Alan T. DeKok [Wed, 25 Feb 2026 15:11:04 +0000 (10:11 -0500)] 
various bug fixes in the RADIUS protocol handler

largely in things for radclient, or proposed code that isn't
used.

2 months agoreset flag on free all
Alan T. DeKok [Wed, 25 Feb 2026 14:05:44 +0000 (09:05 -0500)] 
reset flag on free all

2 months agofix typos
Alan T. DeKok [Wed, 25 Feb 2026 12:29:13 +0000 (07:29 -0500)] 
fix typos

2 months agocheck correct field
Alan T. DeKok [Wed, 25 Feb 2026 02:07:57 +0000 (21:07 -0500)] 
check correct field

2 months agofix typo in comparison
Alan T. DeKok [Wed, 25 Feb 2026 02:01:42 +0000 (21:01 -0500)] 
fix typo in comparison

2 months agoclose FPs on errors
Alan T. DeKok [Wed, 25 Feb 2026 01:54:19 +0000 (20:54 -0500)] 
close FPs on errors

2 months agoreturn IO error on EINTR if we run out of retries
Alan T. DeKok [Wed, 25 Feb 2026 01:49:24 +0000 (20:49 -0500)] 
return IO error on EINTR if we run out of retries

very much an extreme corner case, but sure.

2 months agoadd O_WRONLY parsing
Alan T. DeKok [Wed, 25 Feb 2026 01:44:47 +0000 (20:44 -0500)] 
add O_WRONLY parsing

2 months agoSO_TIMESTAMP needs SOL_SOCKET, not SOL_IP
Alan T. DeKok [Wed, 25 Feb 2026 01:43:11 +0000 (20:43 -0500)] 
SO_TIMESTAMP needs SOL_SOCKET, not SOL_IP

2 months agoset AF for sockaddr_in
Alan T. DeKok [Wed, 25 Feb 2026 01:32:26 +0000 (20:32 -0500)] 
set AF for sockaddr_in

2 months agovarious fixes in fd_open.c
Alan T. DeKok [Wed, 25 Feb 2026 01:30:39 +0000 (20:30 -0500)] 
various fixes in fd_open.c

2 months agoupdate pointer on discard
Alan T. DeKok [Wed, 25 Feb 2026 00:51:18 +0000 (19:51 -0500)] 
update pointer on discard

2 months agoremove double free on error
Alan T. DeKok [Wed, 25 Feb 2026 00:49:50 +0000 (19:49 -0500)] 
remove double free on error

2 months agoremove commented-out code and update message
Alan T. DeKok [Wed, 25 Feb 2026 00:48:10 +0000 (19:48 -0500)] 
remove commented-out code and update message

2 months agorwquire that packet_ctx is not NULL for filtering to work
Alan T. DeKok [Wed, 25 Feb 2026 00:42:01 +0000 (19:42 -0500)] 
rwquire that packet_ctx is not NULL for filtering to work

2 months agoupdate docs
Alan T. DeKok [Wed, 25 Feb 2026 00:36:09 +0000 (19:36 -0500)] 
update docs

2 months agovarious fixes in pipe.c
Alan T. DeKok [Wed, 25 Feb 2026 00:35:28 +0000 (19:35 -0500)] 
various fixes in pipe.c

2 months agoadd tests for ring_buffer_start()
Alan T. DeKok [Wed, 25 Feb 2026 00:28:14 +0000 (19:28 -0500)] 
add tests for ring_buffer_start()

2 months agotypo
Alan T. DeKok [Wed, 25 Feb 2026 00:24:37 +0000 (19:24 -0500)] 
typo

2 months agoAdd map of dn -> attribute to LDAP module test
Nick Porter [Wed, 25 Feb 2026 09:28:45 +0000 (09:28 +0000)] 
Add map of dn -> attribute to LDAP module test

2 months agoAdd handling of "dn" to fr_ldap_map_do
Nick Porter [Tue, 24 Feb 2026 18:11:41 +0000 (18:11 +0000)] 
Add handling of "dn" to fr_ldap_map_do

So "dn" can be used as a RHS in an LDAP update map.

2 months agoRemove invalid comment
Nick Porter [Tue, 24 Feb 2026 18:10:43 +0000 (18:10 +0000)] 
Remove invalid comment