]> git.ipfire.org Git - thirdparty/util-linux.git/log
thirdparty/util-linux.git
2 months agodmesg: Check if file is too large
Tobias Stoeckmann [Mon, 2 Feb 2026 18:47:01 +0000 (19:47 +0100)] 
dmesg: Check if file is too large

32 bit systems might encounter a file which is larger than 2 GB. The
current code would silently truncate the input.

Exit with a proper error message instead.

Add the equal check to silence compiler warnings on 64 bit systems.

Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
2 months agodmesg: Only check for newline if input exists
Tobias Stoeckmann [Mon, 2 Feb 2026 18:28:32 +0000 (19:28 +0100)] 
dmesg: Only check for newline if input exists

If a memory mapped file does not end with a newline, do not check for
its existence. Accessing *end would lead to an out of boundary read.

Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
2 months agodmesg: Check input length before calling strtol
Tobias Stoeckmann [Mon, 2 Feb 2026 18:25:56 +0000 (19:25 +0100)] 
dmesg: Check input length before calling strtol

The dmesg input can be a memory mapped file, yet strtol is used to
parse numbers (facility, level, and syslog timestamp).

Make sure that a terminating character exists to stop strtol before
reaching end.

While at it, actually check if terminating character is the one we
were looking for.

Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
2 months agolsfd: (refactor) make call_with_foreign_fd reusable
Masatake YAMATO [Sat, 29 Nov 2025 19:53:24 +0000 (04:53 +0900)] 
lsfd: (refactor) make call_with_foreign_fd reusable

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
2 months agolsfd: make pidfd for the target process available while collecting fds
Masatake YAMATO [Sun, 1 Feb 2026 16:28:17 +0000 (01:28 +0900)] 
lsfd: make pidfd for the target process available while collecting fds

This is a preparation change for adding inspect_target_fd method to
file_class.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
2 months agolsfd: (comment) update the description of sock_xinfo::netns_inode
Masatake YAMATO [Mon, 2 Feb 2026 17:13:47 +0000 (02:13 +0900)] 
lsfd: (comment) update the description of sock_xinfo::netns_inode

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
2 months agolibblkid: zfs: fix unaligned memory access on SPARC
Ameer Hamza [Mon, 2 Feb 2026 16:16:50 +0000 (21:16 +0500)] 
libblkid: zfs: fix unaligned memory access on SPARC

SPARC requires aligned memory access for uint32_t values. The ZFS code
was directly dereferencing uint32_t pointers that could be unaligned due
to XDR encoding, causing SIGBUS crashes. Introduce copy_be32_to_cpu()
helper using memcpy to safely read from potentially unaligned memory.

Addresses: https://github.com/util-linux/util-linux/issues/4010

Signed-off-by: Ameer Hamza <ahamza@ixsystems.com>
2 months agolsfd: (cosmetic) delete an empty line
Masatake YAMATO [Sun, 25 Jan 2026 23:00:27 +0000 (08:00 +0900)] 
lsfd: (cosmetic) delete an empty line

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
2 months agotools: (get-options.sh) ensure functionality for out-of-tree builds
Christian Goeschel Ndjomouo [Thu, 29 Jan 2026 02:19:33 +0000 (21:19 -0500)] 
tools: (get-options.sh) ensure functionality for out-of-tree builds

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agoMerge PR #3953: waitpid pidfd inode format support
Karel Zak [Mon, 2 Feb 2026 12:54:05 +0000 (13:54 +0100)] 
Merge PR #3953: waitpid pidfd inode format support

Resolved conflicts due to test directory reorganization.
The waitpid test files were already moved to tests/expected/waitpid/
in a previous commit.

Signed-off-by: Karel Zak <kzak@redhat.com>
2 months agoMerge branch 'PR/chfn-version-help' of https://github.com/karelzak/util-linux-work
Karel Zak [Mon, 2 Feb 2026 12:48:41 +0000 (13:48 +0100)] 
Merge branch 'PR/chfn-version-help' of https://github.com/karelzak/util-linux-work

* 'PR/chfn-version-help' of https://github.com/karelzak/util-linux-work:
  chfn: allow --help and --version without login.defs restrictions

2 months agoMerge branch 'tests_convert_to_long_opts' of https://github.com/cgoesche/util-linux...
Karel Zak [Mon, 2 Feb 2026 12:46:44 +0000 (13:46 +0100)] 
Merge branch 'tests_convert_to_long_opts' of https://github.com/cgoesche/util-linux-fork

* 'tests_convert_to_long_opts' of https://github.com/cgoesche/util-linux-fork: (26 commits)
  tests: (waitpid) use long options to improve test coverage report
  tests: use long options globally in test scripts
  tests: (setarch) use long options to improve test coverage report
  tests: (script) use long options to improve test coverage report
  tests: (rev) use long options to improve test coverage report
  tests: (rename) use long options to improve test coverage report
  tests: (mount) use long options to improve test coverage report
  tests: (more) use long options to improve test coverage report
  tests: (lsns) use long options to improve test coverage report
  tests: (lsmem) use long options to improve test coverage report
  tests: (lscpu) use long options to improve test coverage report
  tests: (lsclocks) use long options to improve test coverage report
  tests: (losetup) use long options to improve test coverage report
  tests: (logger) use long options to improve test coverage report
  tests: (ipcs) use long options to improve test coverage report
  tests: (ionice) use long options to improve test coverage report
  tests: (hexdump) use long options to improve test coverage report
  tests: (getopt) use long options to improve test coverage report
  tests: (findmnt) use long options to improve test coverage report
  tests: (fdisk) use long options to improve test coverage report
  ...

2 months agoMerge branch 'issue/3980/hexdump' of https://github.com/echoechoin/util-linux
Karel Zak [Mon, 2 Feb 2026 12:38:18 +0000 (13:38 +0100)] 
Merge branch 'issue/3980/hexdump' of https://github.com/echoechoin/util-linux

* 'issue/3980/hexdump' of https://github.com/echoechoin/util-linux:
  hexdump: fixes Heap-buffer-overflow in rewrite_rules

2 months agoMerge branch 'lib_strutils_incomplete_null_term_check' of https://github.com/cgoesche...
Karel Zak [Mon, 2 Feb 2026 12:33:51 +0000 (13:33 +0100)] 
Merge branch 'lib_strutils_incomplete_null_term_check' of https://github.com/cgoesche/util-linux-fork

* 'lib_strutils_incomplete_null_term_check' of https://github.com/cgoesche/util-linux-fork:
  lib: (strutils.c) fix unchecked lookahead in ul_parse_size()

2 months agoMerge branch 'lsfd--ASSOC-pidfs' of https://github.com/masatake/util-linux
Karel Zak [Mon, 2 Feb 2026 12:28:12 +0000 (13:28 +0100)] 
Merge branch 'lsfd--ASSOC-pidfs' of https://github.com/masatake/util-linux

* 'lsfd--ASSOC-pidfs' of https://github.com/masatake/util-linux:
  lsfd: add new association "pidfs"

2 months agoMerge branch 'mount_manpage_grammar_mistake' of https://github.com/cgoesche/util...
Karel Zak [Mon, 2 Feb 2026 12:22:25 +0000 (13:22 +0100)] 
Merge branch 'mount_manpage_grammar_mistake' of https://github.com/cgoesche/util-linux-fork

* 'mount_manpage_grammar_mistake' of https://github.com/cgoesche/util-linux-fork:
  mount: (manpage) fix minor grammar mistakes

2 months agoMerge branch 'nsenter_manpage_improve' of https://github.com/cgoesche/util-linux...
Karel Zak [Mon, 2 Feb 2026 12:21:46 +0000 (13:21 +0100)] 
Merge branch 'nsenter_manpage_improve' of https://github.com/cgoesche/util-linux-fork

* 'nsenter_manpage_improve' of https://github.com/cgoesche/util-linux-fork:
  nsenter: (manpage) fix minor grammar mistake

2 months agoMerge branch 'column_man_page' of https://github.com/echoechoin/util-linux
Karel Zak [Mon, 2 Feb 2026 12:20:52 +0000 (13:20 +0100)] 
Merge branch 'column_man_page' of https://github.com/echoechoin/util-linux

* 'column_man_page' of https://github.com/echoechoin/util-linux:
  column doc: add missing attrubutes
  column doc: fix incorrect attribute: hidden

2 months agoMerge branch 'getino_man_page_improvements' of https://github.com/cgoesche/util-linux...
Karel Zak [Mon, 2 Feb 2026 12:18:33 +0000 (13:18 +0100)] 
Merge branch 'getino_man_page_improvements' of https://github.com/cgoesche/util-linux-fork

* 'getino_man_page_improvements' of https://github.com/cgoesche/util-linux-fork:
  getino: (manpage) improve grammar and wording

2 months agoMerge branch 'more_column_tests' of https://github.com/cgoesche/util-linux-fork
Karel Zak [Mon, 2 Feb 2026 12:11:11 +0000 (13:11 +0100)] 
Merge branch 'more_column_tests' of https://github.com/cgoesche/util-linux-fork

* 'more_column_tests' of https://github.com/cgoesche/util-linux-fork:
  tests: (column) add more tests

2 months agohexdump: fixes Heap-buffer-overflow in rewrite_rules
WanBingjiang [Mon, 2 Feb 2026 06:55:11 +0000 (14:55 +0800)] 
hexdump: fixes Heap-buffer-overflow in rewrite_rules

2 months agolib: (strutils.c) fix unchecked lookahead in ul_parse_size()
Christian Goeschel Ndjomouo [Mon, 2 Feb 2026 00:15:41 +0000 (19:15 -0500)] 
lib: (strutils.c) fix unchecked lookahead in ul_parse_size()

If the numeric value provided to ul_parse_size() via @str
is a decimal with fractions only containing zeros, the logic
fails to identify the end of the string and goes to the label
'check_suffix' and will do an unchecked lookahead (*p + 1)
that will result in an out-of-bounds read.

This is because the logic only checks for null-termination
when a fraction has been parsed, i.e. a fraction not only
containing zeros.

To fix the issue, we implicitly check for null-termination
when we have finished parsing the fraction.

Reported-by: Yashashree Gund <yash_gund@live.com>
Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (waitpid) add tests for the pidfd inode format support
Christian Goeschel Ndjomouo [Tue, 27 Jan 2026 00:33:00 +0000 (19:33 -0500)] 
tests: (waitpid) add tests for the pidfd inode format support

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (waitpid) move waitpid tests to a dedicated subdir
Christian Goeschel Ndjomouo [Tue, 27 Jan 2026 00:28:41 +0000 (19:28 -0500)] 
tests: (waitpid) move waitpid tests to a dedicated subdir

Moving tests for waitpid(1) in tests/ts/misc to its own
subdirectory, namely tests/ts/waitpid, makes it possible
to add more extensive tests without cluttering tests/ts/misc
and makes the directory structure more coherent.

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agowaitpid: (manpage) document the support for the "PID:inode" addressing format
Christian Goeschel Ndjomouo [Wed, 14 Jan 2026 01:37:26 +0000 (20:37 -0500)] 
waitpid: (manpage) document the support for the "PID:inode" addressing format

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agowaitpid: close fd after removal from epoll interest list
Christian Goeschel Ndjomouo [Mon, 12 Jan 2026 18:53:36 +0000 (13:53 -0500)] 
waitpid: close fd after removal from epoll interest list

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agowaitpid: support 'PID:inode' process addressing format
Christian Goeschel Ndjomouo [Wed, 14 Jan 2026 00:42:09 +0000 (19:42 -0500)] 
waitpid: support 'PID:inode' process addressing format

Adding support for the 'PID:inode' format to address a
process ensures that waitpid(1) safely polls the status
of the expected process in a race-free manner. Worthy of
note is that with the addition of the getino(1) command
the aforementioned task becomes trivially simple.

Example:
        waitpid $(getino -p 123456)

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agowaitpid: refactor to improve maintainability
Christian Goeschel Ndjomouo [Wed, 14 Jan 2026 00:02:47 +0000 (19:02 -0500)] 
waitpid: refactor to improve maintainability

This refactor introduces 'struct waitpid_control' which is
used to control the program state, e.g. option flags, to
create context for internal routines that can adapt their
execution flow accordingly. It has as goal to make the code
easier to understand and reduces the scope of variables.

It also adds 'struct process_info' which stores information
on a process, specified by the PID passed on the command line,
such as the PID, process file descriptor and pidfd inode number.

An array of process_info is used to store information on all
specified PIDs on the command line and is used to create the
event poll list that is integral to the waitpid(1) logic.

This refactor lays the ground work to introduce support for
the 'PID:inode' process addressing format.

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agolib: (pidfd-utils) provide a more liberal variant of ul_get_valid_pidfd_or_err()
Christian Goeschel Ndjomouo [Sat, 10 Jan 2026 01:53:00 +0000 (20:53 -0500)] 
lib: (pidfd-utils) provide a more liberal variant of ul_get_valid_pidfd_or_err()

The new function ul_get_valid_pidfd() behaves less opinionated
in an error case and instead of terminating the calling process
it returns an error.

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agolsfd: add new association "pidfs"
Masatake YAMATO [Fri, 30 Jan 2026 20:27:02 +0000 (05:27 +0900)] 
lsfd: add new association "pidfs"

This new association is inspired by the getino command.

Output example:

  $ ./lsfd --pid=1 -Q '(ASSOC == "pidfs")'
  COMMAND PID USER ASSOC  XMODE  TYPE       SOURCE MNTID INODE NAME
  systemd   1 root pidfs ------ pidfd anon_inodefs     5     2 pid=1 comm=systemd nspid=1

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
2 months agonsenter: (manpage) fix minor grammar mistake
Christian Goeschel Ndjomouo [Fri, 30 Jan 2026 18:28:02 +0000 (13:28 -0500)] 
nsenter: (manpage) fix minor grammar mistake

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agomount: (manpage) fix minor grammar mistakes
Christian Goeschel Ndjomouo [Fri, 30 Jan 2026 18:34:17 +0000 (13:34 -0500)] 
mount: (manpage) fix minor grammar mistakes

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agocolumn doc: add missing attrubutes
WanBingjiang [Fri, 30 Jan 2026 13:32:06 +0000 (21:32 +0800)] 
column doc: add missing attrubutes

2 months agocolumn doc: fix incorrect attribute: hidden
WanBingjiang [Fri, 30 Jan 2026 13:22:28 +0000 (21:22 +0800)] 
column doc: fix incorrect attribute: hidden

2 months agohexdump: add FIEMAP-based sparse file optimization
WanBingjiang [Fri, 30 Jan 2026 05:48:24 +0000 (13:48 +0800)] 
hexdump: add FIEMAP-based sparse file optimization

Use Linux FIEMAP ioctl to detect sparse file holes and skip reading
them. This significantly improves performance when dumping large
sparse files by avoiding unnecessary disk I/O for hole regions.

Key changes:
- Add fiemap, in_sparse_hole, and region_end fields to struct hexdump
- Use check_hole() with cached region boundaries to minimize syscalls
- Only skip holes when vflag==DUP to preserve correct "*" output
- Distinguish real sparse holes from duplicate data in regular files

2 months agogetino: (manpage) improve grammar and wording
Christian Goeschel Ndjomouo [Fri, 30 Jan 2026 02:45:10 +0000 (21:45 -0500)] 
getino: (manpage) improve grammar and wording

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (waitpid) use long options to improve test coverage report
Christian Goeschel Ndjomouo [Thu, 29 Jan 2026 05:58:16 +0000 (00:58 -0500)] 
tests: (waitpid) use long options to improve test coverage report

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: use long options globally in test scripts
Christian Goeschel Ndjomouo [Thu, 29 Jan 2026 05:03:29 +0000 (00:03 -0500)] 
tests: use long options globally in test scripts

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (setarch) use long options to improve test coverage report
Christian Goeschel Ndjomouo [Fri, 23 Jan 2026 20:36:35 +0000 (15:36 -0500)] 
tests: (setarch) use long options to improve test coverage report

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (script) use long options to improve test coverage report
Christian Goeschel Ndjomouo [Fri, 23 Jan 2026 20:31:41 +0000 (15:31 -0500)] 
tests: (script) use long options to improve test coverage report

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (rev) use long options to improve test coverage report
Christian Goeschel Ndjomouo [Fri, 23 Jan 2026 20:27:25 +0000 (15:27 -0500)] 
tests: (rev) use long options to improve test coverage report

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (rename) use long options to improve test coverage report
Christian Goeschel Ndjomouo [Fri, 23 Jan 2026 20:26:40 +0000 (15:26 -0500)] 
tests: (rename) use long options to improve test coverage report

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (mount) use long options to improve test coverage report
Christian Goeschel Ndjomouo [Fri, 23 Jan 2026 20:02:41 +0000 (15:02 -0500)] 
tests: (mount) use long options to improve test coverage report

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (more) use long options to improve test coverage report
Christian Goeschel Ndjomouo [Fri, 23 Jan 2026 19:43:16 +0000 (14:43 -0500)] 
tests: (more) use long options to improve test coverage report

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (lsns) use long options to improve test coverage report
Christian Goeschel Ndjomouo [Fri, 23 Jan 2026 19:12:33 +0000 (14:12 -0500)] 
tests: (lsns) use long options to improve test coverage report

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (lsmem) use long options to improve test coverage report
Christian Goeschel Ndjomouo [Thu, 22 Jan 2026 03:36:51 +0000 (22:36 -0500)] 
tests: (lsmem) use long options to improve test coverage report

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (lscpu) use long options to improve test coverage report
Christian Goeschel Ndjomouo [Thu, 22 Jan 2026 03:25:53 +0000 (22:25 -0500)] 
tests: (lscpu) use long options to improve test coverage report

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (lsclocks) use long options to improve test coverage report
Christian Goeschel Ndjomouo [Thu, 22 Jan 2026 03:24:29 +0000 (22:24 -0500)] 
tests: (lsclocks) use long options to improve test coverage report

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (losetup) use long options to improve test coverage report
Christian Goeschel Ndjomouo [Thu, 22 Jan 2026 03:22:36 +0000 (22:22 -0500)] 
tests: (losetup) use long options to improve test coverage report

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (logger) use long options to improve test coverage report
Christian Goeschel Ndjomouo [Thu, 22 Jan 2026 03:17:18 +0000 (22:17 -0500)] 
tests: (logger) use long options to improve test coverage report

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (ipcs) use long options to improve test coverage report
Christian Goeschel Ndjomouo [Thu, 22 Jan 2026 03:11:42 +0000 (22:11 -0500)] 
tests: (ipcs) use long options to improve test coverage report

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (ionice) use long options to improve test coverage report
Christian Goeschel Ndjomouo [Thu, 22 Jan 2026 03:02:30 +0000 (22:02 -0500)] 
tests: (ionice) use long options to improve test coverage report

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (hexdump) use long options to improve test coverage report
Christian Goeschel Ndjomouo [Thu, 22 Jan 2026 02:55:29 +0000 (21:55 -0500)] 
tests: (hexdump) use long options to improve test coverage report

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (getopt) use long options to improve test coverage report
Christian Goeschel Ndjomouo [Thu, 22 Jan 2026 02:51:22 +0000 (21:51 -0500)] 
tests: (getopt) use long options to improve test coverage report

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (findmnt) use long options to improve test coverage report
Christian Goeschel Ndjomouo [Thu, 22 Jan 2026 02:46:24 +0000 (21:46 -0500)] 
tests: (findmnt) use long options to improve test coverage report

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (fdisk) use long options to improve test coverage report
Christian Goeschel Ndjomouo [Thu, 22 Jan 2026 02:41:17 +0000 (21:41 -0500)] 
tests: (fdisk) use long options to improve test coverage report

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (fallocate) use long options to improve test coverage report
Christian Goeschel Ndjomouo [Thu, 22 Jan 2026 02:34:37 +0000 (21:34 -0500)] 
tests: (fallocate) use long options to improve test coverage report

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (enosys) use long options instead, to improve test coverage report
Christian Goeschel Ndjomouo [Thu, 22 Jan 2026 02:23:41 +0000 (21:23 -0500)] 
tests: (enosys) use long options instead, to improve test coverage report

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (chfn) test all long options
Christian Goeschel Ndjomouo [Thu, 22 Jan 2026 01:08:57 +0000 (20:08 -0500)] 
tests: (chfn) test all long options

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (cal) use more long options to improve test coverage accuracy
Christian Goeschel Ndjomouo [Thu, 22 Jan 2026 00:48:12 +0000 (19:48 -0500)] 
tests: (cal) use more long options to improve test coverage accuracy

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (blkid) use more long options to improve test coverage accuracy
Christian Goeschel Ndjomouo [Thu, 22 Jan 2026 00:36:23 +0000 (19:36 -0500)] 
tests: (blkid) use more long options to improve test coverage accuracy

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (blkdiscard) use long options to improve test coverage accuracy
Christian Goeschel Ndjomouo [Thu, 22 Jan 2026 00:23:06 +0000 (19:23 -0500)] 
tests: (blkdiscard) use long options to improve test coverage accuracy

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (column) add more tests
Christian Goeschel Ndjomouo [Thu, 22 Jan 2026 01:52:29 +0000 (20:52 -0500)] 
tests: (column) add more tests

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (chrt) fix various shellcheck warnings
Christian Goeschel Ndjomouo [Thu, 29 Jan 2026 13:00:29 +0000 (08:00 -0500)] 
tests: (chrt) fix various shellcheck warnings

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (flock) fix shellcheck warning
Christian Goeschel Ndjomouo [Thu, 29 Jan 2026 12:57:52 +0000 (07:57 -0500)] 
tests: (flock) fix shellcheck warning

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: (uuidd) fix various shellcheck warnings
Christian Goeschel Ndjomouo [Thu, 29 Jan 2026 12:55:48 +0000 (07:55 -0500)] 
tests: (uuidd) fix various shellcheck warnings

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: move schedutils tool test scripts to dedicated subdirs
Christian Goeschel Ndjomouo [Thu, 29 Jan 2026 06:16:26 +0000 (01:16 -0500)] 
tests: move schedutils tool test scripts to dedicated subdirs

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: move uuid* tool test scripts to dedicated subdirectories
Christian Goeschel Ndjomouo [Thu, 29 Jan 2026 05:53:02 +0000 (00:53 -0500)] 
tests: move uuid* tool test scripts to dedicated subdirectories

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agotests: move test scripts from tests/ts/misc to dedicated subdir
Christian Goeschel Ndjomouo [Sun, 18 Jan 2026 17:22:36 +0000 (12:22 -0500)] 
tests: move test scripts from tests/ts/misc to dedicated subdir

This patch moves the test scripts in tests/ts/misc to subdirs
in tests/ts for each util-linux tool. It keeps the directory
structure consistent and allows to extend testing for each tool
individually. It also lays the groundwork for the test coverage
report helper script tools/testcoverage.sh.

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agochfn: allow --help and --version without login.defs restrictions
Karel Zak [Thu, 29 Jan 2026 11:50:16 +0000 (12:50 +0100)] 
chfn: allow --help and --version without login.defs restrictions

Parse command line arguments twice: first pass handles --help and
--version before restrictions are applied, second pass enforces
login.defs CHFN_RESTRICT settings for field options.

Signed-off-by: Karel Zak <kzak@redhat.com>
2 months agotests: (chfn) ensure that invalid input is detected correctly
Christian Goeschel Ndjomouo [Thu, 15 Jan 2026 05:06:41 +0000 (00:06 -0500)] 
tests: (chfn) ensure that invalid input is detected correctly

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agochfn: improve man page
Christian Goeschel Ndjomouo [Fri, 16 Jan 2026 03:20:27 +0000 (22:20 -0500)] 
chfn: improve man page

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agochfn: make comment more accurate
Christian Goeschel Ndjomouo [Thu, 15 Jan 2026 23:32:50 +0000 (18:32 -0500)] 
chfn: make comment more accurate

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agochfn: fix minor grammar mistakes in comments
Christian Goeschel Ndjomouo [Thu, 15 Jan 2026 22:10:05 +0000 (17:10 -0500)] 
chfn: fix minor grammar mistakes in comments

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agochfn: use true/false bool values for semantic clarity
Christian Goeschel Ndjomouo [Thu, 15 Jan 2026 04:14:21 +0000 (23:14 -0500)] 
chfn: use true/false bool values for semantic clarity

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agochfn: use direct equality check for semantic clarity and readability
Christian Goeschel Ndjomouo [Wed, 14 Jan 2026 05:41:14 +0000 (00:41 -0500)] 
chfn: use direct equality check for semantic clarity and readability

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agochfn: free memory before return from save_new_data()
Christian Goeschel Ndjomouo [Wed, 14 Jan 2026 04:55:30 +0000 (23:55 -0500)] 
chfn: free memory before return from save_new_data()

[kzak@redhat.com: - remove error message modification]

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
Signed-off-by: Karel Zak <kzak@redhat.com>
2 months agochfn: use null character (0) for better readability
Christian Goeschel Ndjomouo [Wed, 14 Jan 2026 04:45:03 +0000 (23:45 -0500)] 
chfn: use null character (0) for better readability

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agochfn: fix typos, wording, and punctuation inconsistencies
Christian Goeschel Ndjomouo [Wed, 14 Jan 2026 04:21:33 +0000 (23:21 -0500)] 
chfn: fix typos, wording, and punctuation inconsistencies

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
2 months agoMerge branch 'lsfd--dont-reuse-stat-buffer' of https://github.com/masatake/util-linux
Karel Zak [Thu, 29 Jan 2026 09:33:09 +0000 (10:33 +0100)] 
Merge branch 'lsfd--dont-reuse-stat-buffer' of https://github.com/masatake/util-linux

* 'lsfd--dont-reuse-stat-buffer' of https://github.com/masatake/util-linux:
  lsfd: (bugfix) do not reuse stat(2) buffer for files with identical names
  tests: add a helper command, test_open_twice

2 months agolsfd: (bugfix) do not reuse stat(2) buffer for files with identical names
Masatake YAMATO [Thu, 22 Jan 2026 16:19:09 +0000 (01:19 +0900)] 
lsfd: (bugfix) do not reuse stat(2) buffer for files with identical names

To reduce the number of stat(2) calls, lsfd reused the buffer returned
from stat(2) when file descriptors opened files with the same name.

If file descriptors open different files that happen to have the same
name, lsfd may report incorrect results. In such cases, the stat(2)
buffer must not be reused.

The program a.out is run with a file name "D/a".  It opens the file
twice during its execution with an interval.  Between the two open()
calls, a different filesystem is mounted on "D".

<the source code of ./a.out>

  #include <fcntl.h>
  #include <err.h>
  #include <string.h>
  #include <stdio.h>
  #include <stdlib.h>
  #include <unistd.h>

  static void usage(const char *prog, int eval, FILE *fp)
  {
    fputs("Usage :\n", fp);
    fprintf(fp, " %s FILE\n", prog);
    exit(eval);
  }

  int main(int argc, char **argv)
  {
    const char *fname;
    int fd0, fd1;

    if (argc < 2)
      errx(2, "too few arguements");
    if (strcmp(argv[1], "-h") == 0 ||
strcmp(argv[1], "--h") == 0)
      usage(argv[0], 0, stdout);
    if (argc > 2)
      errx(2, "too many arguements");

    fname = argv[1];

    printf("pid: %d\n", getpid());
    fd0 = open(fname, O_RDONLY);
    if (fd0 < 0)
      err(1, "error in open \"%s\" in the first time", fname);

    fputs("[press RETURN to go to the next step] ", stderr);
    getchar();

    fd1 = open(fname, O_RDONLY);
    if (fd1 < 0)
      err(1, "error in open \"%s\" in the second time", fname);

    fputs("[press RETURN to exit] ", stderr);
    getchar();

    return 0;
  }

<PREPARATION>
  $ mkdir D
  $ touch D/a
  $ dd if=/dev/zero of=img.xfs count=1 bs=400MB
  1+0 records in
  1+0 records out
  400000000 bytes (400 MB, 381 MiB) copied, 0.427125 s, 936 MB/s
  $ mkfs.xfs img.xfs
  meta-data=img.xfs                isize=512    agcount=4, agsize=24414 blks
   =                       sectsz=512   attr=2, projid32bit=1
   =                       crc=1        finobt=1, sparse=1, rmapbt=1
   =                       reflink=1    bigtime=1 inobtcount=1 nrext64=1
   =                       exchange=0   metadir=0
  data     =                       bsize=4096   blocks=97656, imaxpct=25
   =                       sunit=0      swidth=0 blks
  naming   =version 2              bsize=4096   ascii-ci=0, ftype=1, parent=0
  log      =internal log           bsize=4096   blocks=16384, version=2
   =                       sectsz=512   sunit=0 blks, lazy-count=1
  realtime =none                   extsz=4096   blocks=0, rtextents=0
   =                       rgcount=0    rgsize=0 extents
   =                       zoned=0      start=0 reserved=0
  $ sudo mount img.xfs D
  $ sudo touch D/a
  $ sudo umount D

Let's see the bug.

<TERMNAL-1>
  $ ./a.out D/a
  pid: 770257
  [press RETURN to go to the next step]

<TERMNAL-2>
  $ sudo mount img.xfs D

<TERMNAL-1>
  (press RETURN)
  [press RETURN to exit]

<TERMNAL-2>
  $ ./lsfd-orignal -p 770257 -Q 'FD > 2'
  COMMAND    PID   USER ASSOC  XMODE TYPE SOURCE MNTID    INODE NAME
  a.out   770257 yamato     3 r-----  REG   dm-3    95 30947324 /home/yamato/D/a
  a.out   770257 yamato     4 r-----  REG   dm-3  1631 30947324 /home/yamato/D/a

  $ stat D/a
    File: D/a
    Size: 0               Blocks: 0          IO Block: 4096   regular empty file
  Device: 7,10    Inode: 131         Links: 1
  ...

Although D/a has inode number 131, lsfd-original reports 30947324.
After removing the code that reuses the stat(2) buffer, lsfd-new reports:

<TERMNAL-2>
  $ ./lsfd-new -p 770257 -Q 'FD > 2'
  COMMAND    PID   USER ASSOC  XMODE TYPE SOURCE MNTID    INODE NAME
  a.out   770257 yamato     3 r-----  REG   dm-3    95 30947324 /home/yamato/D/a
  a.out   770257 yamato     4 r-----  REG loop10  1631      131 /home/yamato/D/a

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
2 months agoAUTHORS: add copyfilerange
Karel Zak [Wed, 28 Jan 2026 12:14:10 +0000 (13:14 +0100)] 
AUTHORS: add copyfilerange

Signed-off-by: Karel Zak <kzak@redhat.com>
2 months agoMerge branch 'copyfilerange' of https://github.com/meeuw/util-linux
Karel Zak [Wed, 28 Jan 2026 12:12:28 +0000 (13:12 +0100)] 
Merge branch 'copyfilerange' of https://github.com/meeuw/util-linux

* 'copyfilerange' of https://github.com/meeuw/util-linux:
  copyfilerange: new command to call copy-file-range

2 months agoMerge branch 'maybe' of https://github.com/stoeckmann/util-linux
Karel Zak [Wed, 28 Jan 2026 12:03:59 +0000 (13:03 +0100)] 
Merge branch 'maybe' of https://github.com/stoeckmann/util-linux

* 'maybe' of https://github.com/stoeckmann/util-linux:
  Fix typos
  setpriv: (man) Fix grammar
  Documentation: Fix "maybe be" typo

2 months agoMerge branch 'nsenter_pidfd_inode' of https://github.com/cgoesche/util-linux-fork
Karel Zak [Wed, 28 Jan 2026 12:01:09 +0000 (13:01 +0100)] 
Merge branch 'nsenter_pidfd_inode' of https://github.com/cgoesche/util-linux-fork

* 'nsenter_pidfd_inode' of https://github.com/cgoesche/util-linux-fork:
  nsenter: support 'PID:inode' process address format

2 months agoblkdev: Correct zone report size calculation
Leefancy [Wed, 28 Jan 2026 09:02:35 +0000 (17:02 +0800)] 
blkdev: Correct zone report size calculation

Signed-off-by: Leefancy <lijian01@kylinos.cn>
3 months agocopyfilerange: new command to call copy-file-range
Dick Marinus [Tue, 2 Dec 2025 19:51:35 +0000 (20:51 +0100)] 
copyfilerange: new command to call copy-file-range

This command allows you to call the copy-file range system call which
performs an in-kernel copy between two files without the additional cost
of transferring data from the kernel to user space and then back into
the kernel.

It gives filesystems an opportunity to implement "copy acceleration"
techniques, such as the use of reflinks (i.e., two or more inodes that
share  pointers to the same copy-on-write disk blocks) or
server-side-copy (in the case of NFS).

A purpose of this command is to in-place deduplicate equal file blocks
in two different files.

When calling this command the source and destination file are required
and ranges must be supplied using command line arguments or from a
ranges file.

A file range contains the offset in the source and destination file and
the length of the range in bytes. The offsets can be omitted so that the
current file pointer is used. When the size is omitted or set to zero
the remainder of the file is copied.

If the file range is too long to fit in SIZE_MAX subsequential calls to
copy_file_range will be performed to copy the whole range.

The following command will copy/reflink a file:

$ copyfilerange file1 file2 0::

The following command will copy the second block from file1 into file2:

        $ copyfilerange file1 file2 4096:4096:4096

Signed-off-by: Dick Marinus <dick@mrns.nl>
3 months agoFix typos
Tobias Stoeckmann [Tue, 27 Jan 2026 17:19:46 +0000 (18:19 +0100)] 
Fix typos

Typos found with codespell.

Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
3 months agosetpriv: (man) Fix grammar
Tobias Stoeckmann [Tue, 27 Jan 2026 17:03:01 +0000 (18:03 +0100)] 
setpriv: (man) Fix grammar

Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
3 months agoDocumentation: Fix "maybe be" typo
Tobias Stoeckmann [Tue, 27 Jan 2026 17:01:56 +0000 (18:01 +0100)] 
Documentation: Fix "maybe be" typo

No functional change.

Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
3 months agoMerge branch 'arm-ids' of https://github.com/mstorsjo/util-linux
Karel Zak [Tue, 27 Jan 2026 12:10:43 +0000 (13:10 +0100)] 
Merge branch 'arm-ids' of https://github.com/mstorsjo/util-linux

* 'arm-ids' of https://github.com/mstorsjo/util-linux:
  lscpu: Implement options for dumping ARM implementer/model name tables

3 months agonsenter: support 'PID:inode' process address format
Christian Goeschel Ndjomouo [Mon, 12 Jan 2026 04:14:18 +0000 (23:14 -0500)] 
nsenter: support 'PID:inode' process address format

The 'PID:inode' can be used for the --target option
to uniquely identify a process in a race-free manner.

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
3 months agoMerge branch 'pidutils_improve' of https://github.com/cgoesche/util-linux-fork
Karel Zak [Tue, 27 Jan 2026 10:37:28 +0000 (11:37 +0100)] 
Merge branch 'pidutils_improve' of https://github.com/cgoesche/util-linux-fork

* 'pidutils_improve' of https://github.com/cgoesche/util-linux-fork:
  lib: (pidutils) improve the return protocol
  lib: (pidutils) add a routine to parse pids and err() on failure
  lib: (pidutils) improve 'PID:inode' parsing logic

3 months agoMerge branch 'pager_removals' of https://github.com/stoeckmann/util-linux
Karel Zak [Tue, 27 Jan 2026 10:35:51 +0000 (11:35 +0100)] 
Merge branch 'pager_removals' of https://github.com/stoeckmann/util-linux

* 'pager_removals' of https://github.com/stoeckmann/util-linux:
  lib/pager: Fix typos
  lib/pager: Simplify wait_for_pager
  lib/pager: Merge wait_or_whine into wait_for_pager
  lib/pager: The variable need_in is always 1
  lib/pager: Remove struct field `no_stdin`
  lib/pager: Remove struct field preexec_cb
  lib/pager: Remove unused define
  lib/pager: Remove unused struct entry `err`
  lib/pager: Remove unused struct field "out"

3 months agoMerge branch 'PR/libpath-nonnull-check' of https://github.com/karelzak/util-linux...
Karel Zak [Tue, 27 Jan 2026 10:35:07 +0000 (11:35 +0100)] 
Merge branch 'PR/libpath-nonnull-check' of https://github.com/karelzak/util-linux-work

* 'PR/libpath-nonnull-check' of https://github.com/karelzak/util-linux-work:
  lib/path: add NULL checks for path in statx and access

3 months agolscpu: Implement options for dumping ARM implementer/model name tables
Martin Storsjö [Thu, 22 Jan 2026 22:56:56 +0000 (00:56 +0200)] 
lscpu: Implement options for dumping ARM implementer/model name tables

This allows extracting the contents of the tables, which itself
is uncopyrightable, for use in other projects with different
code licenses.

3 months agolsns: make the synopsis more coherent
Christian Goeschel Ndjomouo [Tue, 27 Jan 2026 01:14:02 +0000 (20:14 -0500)] 
lsns: make the synopsis more coherent

Using _namespace ID_ in the synopsis as argument definition
is more coherent as it lets a user easily infer that a
numeric value is required to identify a namespace.

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
3 months agolib: (pidutils) improve the return protocol
Christian Goeschel Ndjomouo [Mon, 26 Jan 2026 14:29:33 +0000 (09:29 -0500)] 
lib: (pidutils) improve the return protocol

Instead of using generic return codes, lets
be more precise and return negative errno
numbers and set errno accordingly, so that
higher level callers can report errors more
accurately.

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
3 months agotests: add a helper command, test_open_twice
Masatake YAMATO [Thu, 22 Jan 2026 17:56:46 +0000 (02:56 +0900)] 
tests: add a helper command, test_open_twice

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
3 months agoMerge branch 'spelling' of https://github.com/jwilk-forks/util-linux
Karel Zak [Mon, 26 Jan 2026 10:13:31 +0000 (11:13 +0100)] 
Merge branch 'spelling' of https://github.com/jwilk-forks/util-linux

* 'spelling' of https://github.com/jwilk-forks/util-linux:
  setpriv: (man) fix typo