From f5e5ad0125226c73755df783ab719cc16a3036e4 Mon Sep 17 00:00:00 2001
From: Andreas Schneider <asn@samba.org>
Date: Tue, 12 Nov 2024 08:53:50 +0100
Subject: [PATCH] s3:tests: Fix argument checks in test shell scripts

Fix the argument count check to match the number of required
positional parameters.

Sample failure:
[595(5736)/3145 at 15m52s, 1 errors] samba3.blackbox.update_keytab(ad_member_idmap_nss:local)
source3/script/tests/test_update_keytab.sh: line 16: shift: 2: shift count out of range

Pair-Programmed-With: Anoop C S <anoopcs@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Anoop C S <anoopcs@samba.org>

Autobuild-User(master): Anoop C S <anoopcs@samba.org>
Autobuild-Date(master): Sat Jun 13 10:30:59 UTC 2026 on atb-devel-224
---
 source3/script/tests/test_bug15435_widelink_dfs.sh   | 2 +-
 source3/script/tests/test_dfree_command.sh           | 2 +-
 source3/script/tests/test_dfree_quota.sh             | 2 +-
 source3/script/tests/test_net_tdb.sh                 | 2 +-
 source3/script/tests/test_printing_var_exp.sh        | 2 +-
 source3/script/tests/test_smb1_lanman_plaintext.sh   | 2 +-
 source3/script/tests/test_smbclient_basic.sh         | 2 +-
 source3/script/tests/test_smbclient_krb5.sh          | 2 +-
 source3/script/tests/test_smbclient_large_file.sh    | 2 +-
 source3/script/tests/test_smbclient_log_basename.sh  | 2 +-
 source3/script/tests/test_smbclient_machine_auth.sh  | 2 +-
 source3/script/tests/test_smbclient_ntlm.sh          | 2 +-
 source3/script/tests/test_smbd_no_krb5.sh            | 2 +-
 source3/script/tests/test_smbget.sh                  | 2 +-
 source3/script/tests/test_smbspool.sh                | 2 +-
 source3/script/tests/test_update_keytab.sh           | 2 +-
 source3/script/tests/test_update_keytab_clustered.sh | 4 ++--
 17 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/source3/script/tests/test_bug15435_widelink_dfs.sh b/source3/script/tests/test_bug15435_widelink_dfs.sh
index f0705ca7c5c..42bf2357bf1 100755
--- a/source3/script/tests/test_bug15435_widelink_dfs.sh
+++ b/source3/script/tests/test_bug15435_widelink_dfs.sh
@@ -2,7 +2,7 @@
 
 # regression test for dfs access with wide links enabled on dfs share
 
-if [ $# -lt 5 ]; then
+if [ $# -lt 6 ]; then
 	cat <<EOF
 Usage: test_bug15435_widelink_dfs.sh SERVER SERVER_IP USERNAME PASSWORD SMBCLIENT CONFIGURATION <smbclient arguments>
 EOF
diff --git a/source3/script/tests/test_dfree_command.sh b/source3/script/tests/test_dfree_command.sh
index 3ebb50c1ba1..1234aa9ca65 100755
--- a/source3/script/tests/test_dfree_command.sh
+++ b/source3/script/tests/test_dfree_command.sh
@@ -4,7 +4,7 @@
 # command disk free printout.
 #
 
-if [ $# -lt 6 ]; then
+if [ $# -lt 7 ]; then
 	cat <<EOF
 Usage: test_dfree_command.sh SERVER DOMAIN USERNAME PASSWORD PREFIX SMBCLIENT
 EOF
diff --git a/source3/script/tests/test_dfree_quota.sh b/source3/script/tests/test_dfree_quota.sh
index e9bb987e1bb..8fbf36eaacc 100755
--- a/source3/script/tests/test_dfree_quota.sh
+++ b/source3/script/tests/test_dfree_quota.sh
@@ -3,7 +3,7 @@
 # Blackbox test for disk-free, quota, and their interaction
 #
 
-if [ $# -lt 6 ]; then
+if [ $# -lt 9 ]; then
 	cat <<EOF
 Usage: test_dfree_quota.sh SERVER DOMAIN USERNAME PASSWORD LOCAL_PATH SMBCLIENT SMBCQUOTAS SMBCACLS
 EOF
diff --git a/source3/script/tests/test_net_tdb.sh b/source3/script/tests/test_net_tdb.sh
index 46fc4a6943a..7dee451d19d 100755
--- a/source3/script/tests/test_net_tdb.sh
+++ b/source3/script/tests/test_net_tdb.sh
@@ -9,7 +9,7 @@
 #
 # Copyright (C) 2017 Christof Schmitt
 
-if [ $# -lt 7 ]; then
+if [ $# -lt 8 ]; then
 	cat <<EOF
 Usage: $0 SMBCLIENT SERVER SHARE USER PASS CONFIGURATION LOCALPATH LOCKDIR
 EOF
diff --git a/source3/script/tests/test_printing_var_exp.sh b/source3/script/tests/test_printing_var_exp.sh
index 5729344be2e..87f80e711aa 100755
--- a/source3/script/tests/test_printing_var_exp.sh
+++ b/source3/script/tests/test_printing_var_exp.sh
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-if [ $# -lt 4 ]; then
+if [ $# -lt 5 ]; then
 	cat <<EOF
 Usage: test_printing_var_exp.sh SERVER SERVER_IP DOMAIN USERNAME PASSWORD
 EOF
diff --git a/source3/script/tests/test_smb1_lanman_plaintext.sh b/source3/script/tests/test_smb1_lanman_plaintext.sh
index 669a22e5f4c..6931857bef7 100755
--- a/source3/script/tests/test_smb1_lanman_plaintext.sh
+++ b/source3/script/tests/test_smb1_lanman_plaintext.sh
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-if [ $# -lt 3 ]; then
+if [ $# -lt 4 ]; then
 	cat <<EOF
 Usage: test_smb1_lanman_plaintext.sh SERVER USERNAME PASSWORD
 EOF
diff --git a/source3/script/tests/test_smbclient_basic.sh b/source3/script/tests/test_smbclient_basic.sh
index 6e2a17caf46..1dcb5cad29e 100755
--- a/source3/script/tests/test_smbclient_basic.sh
+++ b/source3/script/tests/test_smbclient_basic.sh
@@ -2,7 +2,7 @@
 
 # this runs the file serving tests that are expected to pass with samba3 against shares with various options
 
-if [ $# -lt 5 ]; then
+if [ $# -lt 6 ]; then
 	cat <<EOF
 Usage: test_smbclient_basic.sh SERVER SERVER_IP DOMAIN USERNAME PASSWORD SMBCLIENT <smbclient arguments>
 EOF
diff --git a/source3/script/tests/test_smbclient_krb5.sh b/source3/script/tests/test_smbclient_krb5.sh
index 98fa7890b3c..b19cb71ecf3 100755
--- a/source3/script/tests/test_smbclient_krb5.sh
+++ b/source3/script/tests/test_smbclient_krb5.sh
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-if [ $# -lt 1 ]; then
+if [ $# -lt 3 ]; then
 	cat <<EOF
 Usage: test_smbclient_krb5.sh ccache smbclient3 server <smbclient args>
 EOF
diff --git a/source3/script/tests/test_smbclient_large_file.sh b/source3/script/tests/test_smbclient_large_file.sh
index 3a384e2c1ba..a5db0e3831b 100755
--- a/source3/script/tests/test_smbclient_large_file.sh
+++ b/source3/script/tests/test_smbclient_large_file.sh
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-if [ $# -lt 1 ]; then
+if [ $# -lt 4 ]; then
 	cat <<EOF
 Usage: test_smbclient_large_file.sh ccache smbclient3 server prefix <smbclient args>
 EOF
diff --git a/source3/script/tests/test_smbclient_log_basename.sh b/source3/script/tests/test_smbclient_log_basename.sh
index f29009fe2bc..4f3b00d32ce 100755
--- a/source3/script/tests/test_smbclient_log_basename.sh
+++ b/source3/script/tests/test_smbclient_log_basename.sh
@@ -2,7 +2,7 @@
 
 # this test checks whether smbclient can log into -l log-basename
 
-if [ $# -lt 2 ]; then
+if [ $# -lt 3 ]; then
 	cat <<EOF
 Usage: test_smbclient_log_basename.sh SERVER SMBCLIENT PREFIX <smbclient arguments>
 EOF
diff --git a/source3/script/tests/test_smbclient_machine_auth.sh b/source3/script/tests/test_smbclient_machine_auth.sh
index c89f84892e7..372c58fe3c5 100755
--- a/source3/script/tests/test_smbclient_machine_auth.sh
+++ b/source3/script/tests/test_smbclient_machine_auth.sh
@@ -2,7 +2,7 @@
 
 # this runs the file serving tests that are expected to pass with samba3 against shares with various options
 
-if [ $# -lt 2 ]; then
+if [ $# -lt 3 ]; then
 	cat <<EOF
 Usage: test_smbclient_machine_auth.sh SERVER SMBCLIENT CONFIGURATION <smbclient arguments>
 EOF
diff --git a/source3/script/tests/test_smbclient_ntlm.sh b/source3/script/tests/test_smbclient_ntlm.sh
index 1e53b1eab3d..5bda503f122 100755
--- a/source3/script/tests/test_smbclient_ntlm.sh
+++ b/source3/script/tests/test_smbclient_ntlm.sh
@@ -2,7 +2,7 @@
 
 # this runs a smbclient based authentication tests
 
-if [ $# -lt 6 ]; then
+if [ $# -lt 7 ]; then
 	cat <<EOF
 Usage: test_smbclient_ntlm.sh SERVER USERNAME PASSWORD MAPTOGUEST SMBCLIENT PROTOCOL CONFIGURATION <smbclient arguments>
 EOF
diff --git a/source3/script/tests/test_smbd_no_krb5.sh b/source3/script/tests/test_smbd_no_krb5.sh
index faa46c90833..31695ce36fd 100755
--- a/source3/script/tests/test_smbd_no_krb5.sh
+++ b/source3/script/tests/test_smbd_no_krb5.sh
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-if [ $# -lt 1 ]; then
+if [ $# -lt 5 ]; then
 	cat <<EOF
 Usage: test_smbd_no_krb5.sh SERVER USERNAME PASSWORD PREFIX
 EOF
diff --git a/source3/script/tests/test_smbget.sh b/source3/script/tests/test_smbget.sh
index b8e6200fbe1..4ef3871c630 100755
--- a/source3/script/tests/test_smbget.sh
+++ b/source3/script/tests/test_smbget.sh
@@ -3,7 +3,7 @@
 # Blackbox test for smbget.
 #
 
-if [ $# -lt 8 ]; then
+if [ $# -lt 10 ]; then
 	cat <<EOF
 Usage: test_smbget SERVER SERVER_IP DOMAIN REALM USERNAME PASSWORD WORKDIR SMBGET
 EOF
diff --git a/source3/script/tests/test_smbspool.sh b/source3/script/tests/test_smbspool.sh
index 7f777174d64..fb4dc772fc3 100755
--- a/source3/script/tests/test_smbspool.sh
+++ b/source3/script/tests/test_smbspool.sh
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-if [ $# -lt 4 ]; then
+if [ $# -lt 5 ]; then
 	cat <<EOF
 Usage: test_smbspool.sh SERVER SERVER_IP USERNAME PASSWORD TARGET_ENV
 EOF
diff --git a/source3/script/tests/test_update_keytab.sh b/source3/script/tests/test_update_keytab.sh
index f218fbe93c0..0771718792c 100755
--- a/source3/script/tests/test_update_keytab.sh
+++ b/source3/script/tests/test_update_keytab.sh
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-if [ $# -lt 1 ]; then
+if [ $# -lt 2 ]; then
 cat <<EOF
 Usage: test_update_keytab.sh DOMAIN CONFIGURATION
 EOF
diff --git a/source3/script/tests/test_update_keytab_clustered.sh b/source3/script/tests/test_update_keytab_clustered.sh
index 045c67063ae..df4eb067b03 100755
--- a/source3/script/tests/test_update_keytab_clustered.sh
+++ b/source3/script/tests/test_update_keytab_clustered.sh
@@ -1,8 +1,8 @@
 #!/bin/sh
 
-if [ $# -lt 1 ]; then
+if [ $# -lt 2 ]; then
 cat <<EOF
-Usage: test_update_keytab.sh DOMAIN CONFIGURATION
+Usage: test_update_keytab_clustered.sh DOMAIN CONFIGURATION
 EOF
 exit 1
 fi
-- 
2.47.3