From ca1049b2f36be42a6daa9c04289d51c481cb7b52 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Tue, 20 Feb 2018 13:59:29 +0100 Subject: [PATCH] Improve the way cache contents are searched for "ns.flushtest.example" During the "check flushtree clears adb correctly" check, expecting "ns.flushtest.example" to always be the first name in the ADB dump is fragile, because in a certain corner case "a.root-servers.nil" will be the first name instead. As the purpose of the relevant check is to ensure "ns.flushtest.example" is removed from ADB by "rndc flushtree flushtest.example", search the entire list of names present in ADB instead of just the first entry when looking for "ns.flushtest.example". --- bin/tests/system/cacheclean/tests.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/tests/system/cacheclean/tests.sh b/bin/tests/system/cacheclean/tests.sh index 002f61f3efa..56f96e667c0 100644 --- a/bin/tests/system/cacheclean/tests.sh +++ b/bin/tests/system/cacheclean/tests.sh @@ -221,11 +221,11 @@ ret=0 load_cache dump_cache mv ns2/named_dump.db.$n ns2/named_dump.db.$n.a -awk '/plain success\/timeout/ {getline; getline; if ($2 == "ns.flushtest.example") exit(0); exit(1); }' ns2/named_dump.db.$n.a || ret=1 +sed -n '/plain success\/timeout/,/Unassociated entries/p' ns2/named_dump.db.$n.a | grep 'ns.flushtest.example' > /dev/null 2>&1 || ret=1 $RNDC $RNDCOPTS flushtree flushtest.example || ret=1 dump_cache mv ns2/named_dump.db.$n ns2/named_dump.db.$n.b -awk '/plain success\/timeout/ {getline; getline; if ($2 == "ns.flushtest.example") exit(1); exit(0); }' ns2/named_dump.db.$n.b || ret=1 +sed -n '/plain success\/timeout/,/Unassociated entries/p' ns2/named_dump.db.$n.b | grep 'ns.flushtest.example' > /dev/null 2>&1 && ret=1 if [ $ret != 0 ]; then echo "I:failed"; fi status=`expr $status + $ret` -- 2.47.3