From eeaffbe07d0e402cefd730e82aa1b4b9e984a618 Mon Sep 17 00:00:00 2001 From: Mark Andrews Date: Tue, 11 Feb 2020 07:44:21 +1100 Subject: [PATCH] Silence Coverity CHECKED_RETURN warnings CID 1458403 (#1 of 1): Unchecked return value (CHECKED_RETURN) 8. check_return: Calling isc_socket_recv without checking return value (as is done elsewhere 14 out of 17 times). 121 isc_socket_recv(sock, &dev->region, 1, task, my_recv, event->ev_arg); CID 1458402 (#1 of 1): Unchecked return value (CHECKED_RETURN) 2. check_return: Calling isc_socket_recv without checking return value (as is done elsewhere 14 out of 17 times). 149 isc_socket_recv(sock, &dev->region, 1, task, my_recv, event->ev_arg); CID 1458401 (#1 of 1): Unchecked return value (CHECKED_RETURN) 6. check_return: Calling isc_socket_recv without checking return value (as is done elsewhere 14 out of 17 times). 226 isc_socket_recv(dev->newsocket, ®ion, 1, 227 newtask, my_recv, event->ev_arg); --- bin/tests/optional/sock_test.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/bin/tests/optional/sock_test.c b/bin/tests/optional/sock_test.c index f13a3ffe64c..4bd11e95ffb 100644 --- a/bin/tests/optional/sock_test.c +++ b/bin/tests/optional/sock_test.c @@ -118,7 +118,9 @@ my_recv(isc_task_t *task, isc_event_t *event) { (int)dev->n, (char *)region.base); } - isc_socket_recv(sock, &dev->region, 1, task, my_recv, event->ev_arg); + RUNTIME_CHECK(isc_socket_recv(sock, &dev->region, 1, task, + my_recv, event->ev_arg) + == ISC_R_SUCCESS); isc_event_free(&event); } @@ -146,7 +148,9 @@ my_http_get(isc_task_t *task, isc_event_t *event) { return; } - isc_socket_recv(sock, &dev->region, 1, task, my_recv, event->ev_arg); + RUNTIME_CHECK(isc_socket_recv(sock, &dev->region, 1, task, + my_recv, event->ev_arg) + == ISC_R_SUCCESS); isc_event_free(&event); } @@ -223,8 +227,9 @@ my_listen(isc_task_t *task, isc_event_t *event) { newtask = NULL; RUNTIME_CHECK(isc_task_create(manager, 0, &newtask) == ISC_R_SUCCESS); - isc_socket_recv(dev->newsocket, ®ion, 1, - newtask, my_recv, event->ev_arg); + RUNTIME_CHECK(isc_socket_recv(dev->newsocket, ®ion, 1, + newtask, my_recv, event->ev_arg) + == ISC_R_SUCCESS); isc_task_detach(&newtask); } else { printf("detaching from socket %p\n", event->ev_sender); -- 2.47.3