git.ipfire.org Git - thirdparty/openwrt.git/blob

   1 From e19fbe3996aae35a467ebad35ff2b8d84975a65c Mon Sep 17 00:00:00 2001
   2 From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
   3 Date: Tue, 11 Jun 2024 15:54:33 +0200
   4 Subject: net: dsa: lantiq_gswip: Update comments in
   5  gswip_port_vlan_filtering()
   6
   7 Update the comments in gswip_port_vlan_filtering() so it's clear that
   8 there are two separate cases, one for "tag based VLAN" and another one
   9 for "port based VLAN".
  10
  11 Suggested-by: Martin Schiller <ms@dev.tdt.de>
  12 Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
  13 Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
  14 Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
  15 Signed-off-by: Martin Schiller <ms@dev.tdt.de>
  16 Link: https://lore.kernel.org/r/20240611135434.3180973-12-ms@dev.tdt.de
  17 Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  18 ---
  19  drivers/net/dsa/lantiq_gswip.c | 4 ++--
  20  1 file changed, 2 insertions(+), 2 deletions(-)
  21
  22 --- a/drivers/net/dsa/lantiq_gswip.c
  23 +++ b/drivers/net/dsa/lantiq_gswip.c
  24 @@ -773,7 +773,7 @@ static int gswip_port_vlan_filtering(str
  25         }
  26
  27         if (vlan_filtering) {
  28 -               /* Use port based VLAN tag */
  29 +               /* Use tag based VLAN */
  30                 gswip_switch_mask(priv,
  31                                   GSWIP_PCE_VCTRL_VSR,
  32                                   GSWIP_PCE_VCTRL_UVR | GSWIP_PCE_VCTRL_VIMR |
  33 @@ -782,7 +782,7 @@ static int gswip_port_vlan_filtering(str
  34                 gswip_switch_mask(priv, GSWIP_PCE_PCTRL_0_TVM, 0,
  35                                   GSWIP_PCE_PCTRL_0p(port));
  36         } else {
  37 -               /* Use port based VLAN tag */
  38 +               /* Use port based VLAN */
  39                 gswip_switch_mask(priv,
  40                                   GSWIP_PCE_VCTRL_UVR | GSWIP_PCE_VCTRL_VIMR |
  41                                   GSWIP_PCE_VCTRL_VEMR,