git.ipfire.org Git - thirdparty/openwrt.git/blob

   1 From dd6d364e1895211df8a8fe02c2a5a0b2a7049957 Mon Sep 17 00:00:00 2001
   2 From: Martin Schiller <ms@dev.tdt.de>
   3 Date: Tue, 11 Jun 2024 15:54:25 +0200
   4 Subject: net: dsa: lantiq_gswip: add terminating \n where missing
   5
   6 Some dev_err are missing the terminating \n. Let's add that.
   7
   8 Suggested-by: Vladimir Oltean <olteanv@gmail.com>
   9 Signed-off-by: Martin Schiller <ms@dev.tdt.de>
  10 Reviewed-by: Andrew Lunn <andrew@lunn.ch>
  11 Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
  12 Link: https://lore.kernel.org/r/20240611135434.3180973-4-ms@dev.tdt.de
  13 Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  14 ---
  15  drivers/net/dsa/lantiq_gswip.c | 14 +++++++-------
  16  1 file changed, 7 insertions(+), 7 deletions(-)
  17
  18 --- a/drivers/net/dsa/lantiq_gswip.c
  19 +++ b/drivers/net/dsa/lantiq_gswip.c
  20 @@ -829,7 +829,7 @@ static int gswip_setup(struct dsa_switch
  21
  22         err = gswip_pce_load_microcode(priv);
  23         if (err) {
  24 -               dev_err(priv->dev, "writing PCE microcode failed, %i", err);
  25 +               dev_err(priv->dev, "writing PCE microcode failed, %i\n", err);
  26                 return err;
  27         }
  28
  29 @@ -1780,7 +1780,7 @@ static u32 gswip_bcm_ram_entry_read(stru
  30         err = gswip_switch_r_timeout(priv, GSWIP_BM_RAM_CTRL,
  31                                      GSWIP_BM_RAM_CTRL_BAS);
  32         if (err) {
  33 -               dev_err(priv->dev, "timeout while reading table: %u, index: %u",
  34 +               dev_err(priv->dev, "timeout while reading table: %u, index: %u\n",
  35                         table, index);
  36                 return 0;
  37         }
  38 @@ -2009,7 +2009,7 @@ static void gswip_gphy_fw_remove(struct
  39
  40         ret = regmap_write(priv->rcu_regmap, gphy_fw->fw_addr_offset, 0);
  41         if (ret)
  42 -               dev_err(priv->dev, "can not reset GPHY FW pointer");
  43 +               dev_err(priv->dev, "can not reset GPHY FW pointer\n");
  44
  45         clk_disable_unprepare(gphy_fw->clk_gate);
  46
  47 @@ -2038,7 +2038,7 @@ static int gswip_gphy_fw_list(struct gsw
  48                         priv->gphy_fw_name_cfg = &xrx200a2x_gphy_data;
  49                         break;
  50                 default:
  51 -                       dev_err(dev, "unknown GSWIP version: 0x%x", version);
  52 +                       dev_err(dev, "unknown GSWIP version: 0x%x\n", version);
  53                         return -ENOENT;
  54                 }
  55         }
  56 @@ -2048,7 +2048,7 @@ static int gswip_gphy_fw_list(struct gsw
  57                 priv->gphy_fw_name_cfg = match->data;
  58
  59         if (!priv->gphy_fw_name_cfg) {
  60 -               dev_err(dev, "GPHY compatible type not supported");
  61 +               dev_err(dev, "GPHY compatible type not supported\n");
  62                 return -ENOENT;
  63         }
  64
  65 @@ -2150,7 +2150,7 @@ static int gswip_probe(struct platform_d
  66                         return -EINVAL;
  67                 break;
  68         default:
  69 -               dev_err(dev, "unknown GSWIP version: 0x%x", version);
  70 +               dev_err(dev, "unknown GSWIP version: 0x%x\n", version);
  71                 return -ENOENT;
  72         }
  73
  74 @@ -2181,7 +2181,7 @@ static int gswip_probe(struct platform_d
  75                 goto mdio_bus;
  76         }
  77         if (!dsa_is_cpu_port(priv->ds, priv->hw_info->cpu_port)) {
  78 -               dev_err(dev, "wrong CPU port defined, HW only supports port: %i",
  79 +               dev_err(dev, "wrong CPU port defined, HW only supports port: %i\n",
  80                         priv->hw_info->cpu_port);
  81                 err = -EINVAL;
  82                 goto disable_switch;