]> git.ipfire.org Git - thirdparty/openvpn.git/commit
tls-crypt-v2: fix server memory leak
authorSteffan Karger <steffan@karger.me>
Thu, 3 Dec 2020 18:22:30 +0000 (19:22 +0100)
committerGert Doering <gert@greenie.muc.de>
Fri, 4 Dec 2020 10:15:34 +0000 (11:15 +0100)
commit06e769552481729ddae28ee46b30f2dc8ca77509
tree1d9cdcbe02d0d58e84eaab73c526fea8fa99c7a8
parent570f0564afb34ede41c99bf66f1f369bcf38b138
tls-crypt-v2: fix server memory leak

tls-crypt-v2 was developed in parallel with the changes that allowed to
use tls-auth/tls-crypt in connection blocks. The tls-crypt-v2 patch set
was never updated to the new reality after commit 5817b49b, causing a
memory leak of about 600 bytes for each connecting client.

It would be nicer to not reload the tls-crypt-v2 server key for each
connecting client, but that requires more refactoring (and thus more time
to get right). So for now just plug the leak by free'ing the memory when
we close a client connection.

To test this easily, compile openvpn with -fsanity=address, run a server
with tls-crypt-v2, connect a client, stop the server.

Signed-off-by: Steffan Karger <steffan@karger.me>
Acked-by: Antonio Quartulli <antonio@openvpn.net>
Message-Id: <20201203182230.33552-1-steffan@karger.me>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg21310.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit fb169c3b8fdfa9792c0eee8441956f062dfd7982)
src/openvpn/init.c