]> git.ipfire.org Git - thirdparty/openvpn.git/commit
make t_client robust against sudoers misconfiguration
authorGert Doering <gert@greenie.muc.de>
Sun, 2 Oct 2016 13:19:23 +0000 (15:19 +0200)
committerGert Doering <gert@greenie.muc.de>
Tue, 4 Oct 2016 09:32:12 +0000 (11:32 +0200)
commit0bd4ef0a18c65bfbd4e5b08735d7bb67dd010b97
tree36a639f949e1bb08a5c701f60908e2d518b9104d
parentbeca355525fd250f660b5c400edd3ba83d25f171
make t_client robust against sudoers misconfiguration

Instead of testing (and priming) sudo with "true", prime with
"kill -0 $$" (just test signalling ourselves).  If this fails,
we won't be able to kill the openvpn process we're going to
start later on -> thus, SKIP on failure.

This helps with misconfigured setups (especially on the buildbots)
that can correctly start openvpn but then not stop it later on -
leaving openvpn processes dangling around, requiring manual
intervention.

Signed-off-by: Gert Doering <gert@greenie.muc.de>
Acked-by: Arne Schwabe <arne@rfc2549.org>
Message-Id: <20161002131923.36681-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg12585.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit 8ca29af7c6d4759ce019ec9d0cd3eae4511a6804)
tests/t_client.sh.in