]> git.ipfire.org Git - thirdparty/samba.git/commit
s3: smbd: Ensure in the directory scanning loops inside rmdir_internals() we don...
authorJeremy Allison <jra@samba.org>
Thu, 4 Nov 2021 02:02:36 +0000 (19:02 -0700)
committerRalph Boehme <slow@samba.org>
Thu, 4 Nov 2021 09:10:27 +0000 (09:10 +0000)
commit141f3f5f9a5ef556cc7864b2afbf8ad48b7ebe77
tree6c991a25ff084371b78b3a8d3402054d063f51f2
parentadfad6390962022277cc6aacaa388af86e46b71c
s3: smbd: Ensure in the directory scanning loops inside rmdir_internals() we don't overwrite the 'ret' variable.

If we overwrite with ret=0, we return NT_STATUS_OK even when we goto err.

This function should be restructured to use NT_STATUS internally,
and make 'int ret' transitory, but that's a patch for another
time.

Remove knownfail.

BUG: BUG: https://bugzilla.samba.org/show_bug.cgi?id=14892

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu Nov  4 09:10:27 UTC 2021 on sn-devel-184
selftest/knownfail.d/del_on_close_nonempty [deleted file]
source3/smbd/close.c