]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix timestamp of sent message for write context in logical decoding
authorMichael Paquier <michael@paquier.xyz>
Wed, 6 Nov 2019 07:12:56 +0000 (16:12 +0900)
committerMichael Paquier <michael@paquier.xyz>
Wed, 6 Nov 2019 07:12:56 +0000 (16:12 +0900)
commit15d90a02a0cefbc89d9533287f904f2aea7034ed
tree205af44d43e638da20aa6fb243ea248c46c752e7
parent00ac1eced6204656ae393a719063fbef99a2cf4b
Fix timestamp of sent message for write context in logical decoding

When sending data for logical decoding using the streaming replication
protocol via a WAL sender, the timestamp of the sent write message is
allocated at the beginning of the message when preparing for the write,
and actually computed when the write message is ready to be sent.

The timestamp was getting computed after sending the message.  This
impacts anything using logical decoding, causing for example logical
replication to report mostly NULL for last_msg_send_time in
pg_stat_subscription.

This commit makes sure that the timestamp is computed before sending the
message.  This is wrong since 5a991ef, so backpatch down to 9.4.

Author: Jeff Janes
Discussion: https://postgr.es/m/CAMkU=1z=WMn8jt7iEdC5sYNaPgAgOASb_OW5JYv-vMdYaJSL-w@mail.gmail.com
Backpatch-through: 9.4
src/backend/replication/walsender.c