]> git.ipfire.org Git - thirdparty/FORT-validator.git/commit
Another RRDP review, startup
authorAlberto Leiva Popper <ydahhrk@gmail.com>
Tue, 7 Nov 2023 21:25:06 +0000 (15:25 -0600)
committerAlberto Leiva Popper <ydahhrk@gmail.com>
Wed, 8 Nov 2023 15:53:59 +0000 (09:53 -0600)
commit17b140d5ffa6e5cf9d8626a419b170eb34a30afe
tree67e38f27da7d30bdd5a1aacf3d076eb409fb5f0f
parent84874cec1f9b6a9d354c31a7ef58d630a6f7d9ea
Another RRDP review, startup

- Improve usage of `xmlChar *`
  (Was being casted to/from `char *` rather contract-breakingly.)
- Bunch of renames
- notification_metadata -> rrdp_session
  (These are not exclusive to Notifications.)
- delta_head -> notification_delta
  (The object specifically refers to Notification delta tags,
  I don't know what "head" is supposed to allude.)
- rdr_snapshot_ctx, rdr_delta_ctx -> rrdp_ctx
  (Slightly tweaked the semantics of this, to reduce argument
  lists.)
- Remove redundant fnstack pushes and pops
  (Rather comically, snapshots and deltas were being stacked twice:
  parse_snapshot() + rrdp_parse_snapshot(), parse_delta() +
  process_delta().)

There are still a few FIXMEs in RRDP yet.
src/rrdp.c
test/rrdp_test.c