]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core-contrib.git/commit
insane.bbclass: Don't let warnings make previous errors non-fatal
authorOlof Johansson <olof.johansson@axis.com>
Mon, 25 Jun 2018 11:34:46 +0000 (13:34 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 28 Jun 2018 08:22:30 +0000 (09:22 +0100)
commit21d015f6c9927598d64c48c925638619b25cf232
treeb75700084f7596867324733b9168fcae9ceb9af6
parentda29440633706fb7a346391d97894d6f2cbb0d01
insane.bbclass: Don't let warnings make previous errors non-fatal

package_qa_handle_error() returns True on non-fatal issues and False on
fatal issues. But the current usage has been to do

  sane = package_qa_handle_error(...)

which would always reset sanity status to be that of the last issue
identified. This change the assignments to use the &= operator instead:

  sane &= package_qa_handle_error(...)

As far as I can tell, this is not a real problem in practice, because
warnings of different levels (WARN_QA, ERROR_QA) does not seem to have
been mixed in a way that triggered this issue.

Signed-off-by: Olof Johansson <olofjn@axis.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/insane.bbclass