]> git.ipfire.org Git - thirdparty/asterisk.git/commit
pjsip: Make modify_local_offer2 tolerate previous failed SDP.
authorJoshua C. Colp <jcolp@sangoma.com>
Fri, 5 Feb 2021 11:26:02 +0000 (07:26 -0400)
committerJoshua Colp <jcolp@sangoma.com>
Thu, 18 Feb 2021 15:53:20 +0000 (09:53 -0600)
commit239573734a8a5f79c9ed1fabcdb330b3f275d7e1
tree1fe73ad7fcd04b0c0fa49b44244ccf0a8dd4632d
parent3fb4c584c293db5ffe7933df4e8080ac7f45e028
pjsip: Make modify_local_offer2 tolerate previous failed SDP.

If a remote side is broken and sends an SDP that can not be
negotiated the call will be torn down but there is a window
where a second 183 Session Progress or 200 OK that is forked
can be received that also attempts to negotiate SDP. Since
the code marked the SDP negotiation as being done and complete
prior to this it assumes that there is an active local and remote
SDP which it can modify, while in fact there is not as the SDP
did not successfully negotiate. Since there is no local or remote
SDP a crash occurs.

This patch changes the pjmedia_sdp_neg_modify_local_offer2
function to no longer assume that a previous SDP negotiation
was successful.

ASTERISK-29196

Change-Id: I22de45916d3b05fdc2a67da92b3a38271ee5949e
third-party/pjproject/patches/0080-fix-sdp-neg-modify-local-offer.patch [new file with mode: 0644]