]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Don't reflect unescaped cert data to the logs
authorPeter Eisentraut <peter@eisentraut.org>
Tue, 13 Sep 2022 14:10:50 +0000 (16:10 +0200)
committerPeter Eisentraut <peter@eisentraut.org>
Tue, 13 Sep 2022 14:10:50 +0000 (16:10 +0200)
commit257eb57b50f7c65467bfc2f4d579622fa13f3370
tree74fe36325c4c07f18fba7f6906dc1ef442088bab
parent45b1a67a0fcb3f1588df596431871de4c93cb76f
Don't reflect unescaped cert data to the logs

Commit 3a0e385048 introduced a new path for unauthenticated bytes from
the client certificate to be printed unescaped to the logs. There are a
handful of these already, but it doesn't make sense to keep making the
problem worse. \x-escape any unprintable bytes.

The test case introduces a revoked UTF-8 certificate. This requires the
addition of the `-utf8` flag to `openssl req`. Since the existing
certificates all use an ASCII subset, this won't modify the existing
certificates' subjects if/when they get regenerated; this was verified
experimentally with

    $ make sslfiles-clean
    $ make sslfiles

Unfortunately the test can't be run in the CI yet due to a test timing
issue; see 55828a6b60.

Author: Jacob Champion <jchampion@timescale.com>
Discussion: https://www.postgresql.org/message-id/CAAWbhmgsvHrH9wLU2kYc3pOi1KSenHSLAHBbCVmmddW6-mc_=w@mail.gmail.com
src/backend/libpq/be-secure-openssl.c
src/test/ssl/conf/client-revoked-utf8.config [new file with mode: 0644]
src/test/ssl/ssl/client-crldir/9bb9e3c3.r0
src/test/ssl/ssl/client-revoked-utf8.crt [new file with mode: 0644]
src/test/ssl/ssl/client-revoked-utf8.key [new file with mode: 0644]
src/test/ssl/ssl/client.crl
src/test/ssl/ssl/root+client-crldir/9bb9e3c3.r0
src/test/ssl/ssl/root+client.crl
src/test/ssl/sslfiles.mk
src/test/ssl/t/001_ssltests.pl
src/test/ssl/t/SSL/Backend/OpenSSL.pm