]> git.ipfire.org Git - thirdparty/samba.git/commit
dns scavenging: ensure usual ownership of element values
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Mon, 29 Mar 2021 00:11:01 +0000 (13:11 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Sun, 20 Jun 2021 23:26:32 +0000 (23:26 +0000)
commit2d98d733ab7e782e454d19dbc92cab669d89bd58
tree5fbd586c0097d1a1f35cbbdc3a6de39ffd0739f3
parent2c6a0265f2b577be485744edc5e8951f31d7ecfd
dns scavenging: ensure usual ownership of element values

An ldb message, its elements, and their values usually all share a
little talloc sub-tree with each other and nobody else. It is
conceivable that somewhere we rely on that.

In this case we were sharing an out-of-subtree values array across
multiple messages, which seems to be asking for trouble.

Also, add a comment explaining what we want.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/dsdb/kcc/scavenge_dns_records.c