]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
[gdb/python] Handle failure to initialize without exiting
authorTom de Vries <tdevries@suse.de>
Fri, 22 Nov 2024 18:34:24 +0000 (19:34 +0100)
committerTom de Vries <tdevries@suse.de>
Fri, 22 Nov 2024 18:34:24 +0000 (19:34 +0100)
commit372d0a4c9655127da2677dabf70e8e51de24c382
tree079001f526e3e7cf799a45f1662792a1ce112b8b
parent9d3785a8ac15dcc369b8c0b1074c5ca7145cdda7
[gdb/python] Handle failure to initialize without exiting

I tried out making python initialization fail by passing an incorrect
PYTHONHOME, and got:
...
$ PYTHONHOME=foo ./gdb.sh -q
Python path configuration:
  PYTHONHOME = 'foo'
  ...
Python initialization failed: \
  failed to get the Python codec of the filesystem encoding
Python not initialized
$
...

The relevant part of the code is:
...
static void
gdbpy_initialize (const struct extension_language_defn *extlang)
{
  if (!do_start_initialization () && py_isinitialized && PyErr_Occurred ())
    gdbpy_print_stack ();

   gdbpy_enter enter_py;
...

What happens is:
- gdbpy_enter::gdbpy_enter () is called, where we run into:
  'if (!gdb_python_initialized) error (_("Python not initialized"));'
- the error propagates to gdb's toplevel
- gdb print the error and exits.

It seems unnecesssary that we exit gdb.  We could continue the
session without python support.

Fix this by:
- bailing out of gdbpy_initialize if !do_start_initialization
- bailing out of finalize_python if !gdb_python_initialized

This gets us instead:
...
$ PYTHONHOME=foo gdb -q
Python path configuration:
  PYTHONHOME = 'foo'
  ...
Python initialization failed: \
  failed to get the Python codec of the filesystem encoding
(gdb) python print (1)
Python not initialized
(gdb)
...

Tested on aarch64-linux.

Approved-By: Tom Tromey <tom@tromey.com>
gdb/python/python.c
gdb/testsuite/gdb.python/py-failed-init.exp [new file with mode: 0644]