]> git.ipfire.org Git - thirdparty/public-inbox.git/commit
nntp: avoid modifying $_[0] in RE conversions
authorEric Wong <e@80x24.org>
Thu, 27 Mar 2025 23:20:45 +0000 (23:20 +0000)
committerEric Wong <e@80x24.org>
Sun, 30 Mar 2025 18:19:32 +0000 (18:19 +0000)
commit3988b91d29ea037df1f1790ca18d4457e833d87b
treee494600847cb8375938ad601c2934a77a79a7726
parentce698d1583761eb5b0d0fd401ec615b7bc173625
nntp: avoid modifying $_[0] in RE conversions

I've been getting occasional t/nntp.t warnings about
uninitialized variables which I'm not able to reproduce
reliably.  My current theory is that modifying $_[0] may get
wonky when it's happening across several layers of the call
stack, so stop doing it since it's unlikely to yield any
real world speedups and only made the code more difficult
to understand, here.
lib/PublicInbox/NNTP.pm
t/nntp.t