]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Be more wary of corrupt data in pageinspect's heap_page_items().
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 19 Apr 2025 20:37:43 +0000 (16:37 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 19 Apr 2025 20:37:43 +0000 (16:37 -0400)
commit3c2ea65bd85f16d563f896398251dd1337fc5856
tree63c782f6ebd0612426c3a6a34d62901028dc6194
parent148cc0105dce93b52fe9e801f51ae0e3fbf96af1
Be more wary of corrupt data in pageinspect's heap_page_items().

The original intent in heap_page_items() was to return nulls, not
throw an error or crash, if an item was sufficiently corrupt that
we couldn't safely extract data from it.  However, commit d6061f83a
utterly missed that memo, and not only put in an un-length-checked
copy of the tuple's data section, but also managed to break the check
on sane nulls-bitmap length.  Either mistake could possibly lead to
a SIGSEGV crash if the tuple is corrupt.

Bug: #18896
Reported-by: Dmitry Kovalenko <d.kovalenko@postgrespro.ru>
Author: Dmitry Kovalenko <d.kovalenko@postgrespro.ru>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/18896-add267b8e06663e3@postgresql.org
Backpatch-through: 13
contrib/pageinspect/heapfuncs.c