]> git.ipfire.org Git - thirdparty/grub.git/commit
tests/util/grub-shell: Default qemuopts to envvar $GRUB_QEMU_OPTS
authorGlenn Washburn <development@efficientek.com>
Thu, 6 Mar 2025 06:48:13 +0000 (00:48 -0600)
committerDaniel Kiper <daniel.kiper@oracle.com>
Wed, 26 Mar 2025 13:04:49 +0000 (14:04 +0100)
commit3fd163e453b577b6728babe80f8f77c981a67b08
tree40da2760772252e3522365e8cefa9e885415dbc0
parentff7f5530713c203c90a7dea2b7c56d403673548b
tests/util/grub-shell: Default qemuopts to envvar $GRUB_QEMU_OPTS

Fix a regression where qemuopts was mistakenly defaulted to the empty
string. This prevents the sending of arbitrary QEMU options to tests,
which may be desirable for overriding the machine type. There was a
concern that allowing the tester to accept arbitrary options would add
headaches for another developer trying to diagnose why a test failed on
the testers machine because he could not be sure if any additional
options were passed to make the test fail. However, all the options are
recorded in the run.sh generated script, so this concern is unwarranted.

Fixes: 6d729ced70 (tests/util/grub-shell: Add $GRUB_QEMU_OPTS to run.sh to easily see unofficial QEMU arguments)
Signed-off-by: Glenn Washburn <development@efficientek.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
tests/util/grub-shell.in